Skip to contentSkip to conversation

ARM64: Enable SP805 WDT support for FSL LS2080A

PATCH Superseded Bhupesh Sharma 6 participants 11 messages Dec 15, 2015 – Jan 12, 2016

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover ARM64: Enable SP805 WDT support for FSL LS2080A

This is the v3 of patchset which adds the support for SP805 WDT on FSL LS2080A and also adds the missing documentation of SP805 WDT device-tree bindings.

Rebased against arm-soc/next/dt

Changes since v2:
(v2 can be viewed here: http://permalink.gmane.org/gmane.linux.ports.arm.kernel/463141)
- Addressed Rob's comments regarding the second mandatory CLK source's (WDOGCLK) name in the bindings.

Changes since v1:
(v1 can be viewed here: http://www.spinics.net/lists/devicetree/msg102487.html)

- Addressed Rob and Mark's comments regarding the mandatory CLK sources
- Removed interrupt property from the bindings for now (as discussed
with Mark on IRC) till Will's patch proceeds further and enables handling the WDOG interrupts for each core connected to the same PPI line (http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/391616.html)

Bhupesh Sharma (2):
Documentation: DT: Add entry for ARM SP805-WDT dts/ls2080a: Update DTSI to add support of SP805 WDT

 .../devicetree/bindings/watchdog/sp805-wdt.txt     |   29 ++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi     |   56 ++++++++++++++++++++
 2 files changed, 85 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v3 1/2 Documentation: DT: Add entry for ARM SP805-WDT

This patch adds a devicetree binding documentation for ARM's SP805 WatchDog Timer.

---
 .../devicetree/bindings/watchdog/sp805-wdt.txt     |   29 ++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
Documentation/devicetree/bindings/watchdog/sp805-wdt.txt new file +29 -0
new file mode 100644
index 0000000..45b5afc
@@ -0,0 +1,29 @@
+* ARM SP805 Watchdog Timer (WDT) Controller
+
+SP805 WDT is a ARM Primecell Peripheral and has a standard-id register that
+can be used to identify the peripheral type, vendor, and revision.
+This value can be used for driver matching.
+
+As SP805 WDT is a primecell IP, it follows the base bindings specified in
+'arm/primecell.txt'
+
+Required properties:
+- compatible : Should be "arm,sp805-wdt", "arm,primecell"
+- reg : Base address and size of the watchdog timer registers.
+- clocks : From common clock binding.
+           First clock is PCLK and the second is WDOGCLK.
+           WDOGCLK can be equal to or be a sub-multiple of the PCLK frequency.
+- clock-names : From common clock binding. Shall be "apb_pclk" for first clock.
+
+Optional properties:
+- interrupts : Should specify WDT interrupt number.
+
+Examples:
+
+		cluster1_core0_watchdog: wdt at c000000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc000000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
Signature · 1 line
1.7.9.5
maintainer
#2 lore raw

PATCH v3 1/2 Documentation: DT: Add entry for ARM SP805-WDT

Quoted 8 lines · Bhupesh Sharma

This patch adds a devicetree binding documentation for ARM's SP805 WatchDog Timer.

---
 .../devicetree/bindings/watchdog/sp805-wdt.txt     |   29 ++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
#3 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

In reply to Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56 ++++++++++++++++++++++++
 1 file changed, 56 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi +56 -0
index e81cd48..7b0f411 100644
@@ -193,6 +193,62 @@
 			interrupts = <0 32 0x4>; /* Level high type */
 		};
 
+		cluster1_core0_watchdog: wdt at c000000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc000000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster1_core1_watchdog: wdt at c010000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc010000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster2_core0_watchdog: wdt at c100000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc100000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster2_core1_watchdog: wdt at c110000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc110000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster3_core0_watchdog: wdt at c200000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc200000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster3_core1_watchdog: wdt at c210000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc210000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster4_core0_watchdog: wdt at c300000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc300000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
+		cluster4_core1_watchdog: wdt at c310000 {
+			compatible = "arm,sp805-wdt", "arm,primecell";
+			reg = <0x0 0xc310000 0x0 0x1000>;
+			clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+			clock-names = "apb_pclk", "wdog_clk";
+		};
+
 		fsl_mc: fsl-mc at 80c000000 {
 			compatible = "fsl,qoriq-mc";
 			reg = <0x00000008 0x0c000000 0 0x40>,	 /* MC portal base */
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

Hi Arnd, Olof, Kevin

Quoted 8 lines · Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56 ++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

Since Rob has acked the SP805 WDT binding documentation patch (patch 1/2 of this series),
can this DTSI change, please be considered for absorption in the arm-soc tree.

Regards,
Bhupesh

Quoted 72 lines
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi +56 -1
index e81cd48..7b0f411 100644
@@ -193,6 +193,62 @@
                        interrupts = <0 32 0x4>; /* Level high type */
                };
 
+               cluster1_core0_watchdog: wdt at c000000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc000000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster1_core1_watchdog: wdt at c010000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc010000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster2_core0_watchdog: wdt at c100000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc100000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster2_core1_watchdog: wdt at c110000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc110000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster3_core0_watchdog: wdt at c200000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc200000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster3_core1_watchdog: wdt at c210000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc210000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster4_core0_watchdog: wdt at c300000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc300000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
+               cluster4_core1_watchdog: wdt at c310000 {
+                       compatible = "arm,sp805-wdt", "arm,primecell";
+                       reg = <0x0 0xc310000 0x0 0x1000>;
+                       clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+                       clock-names = "apb_pclk", "wdog_clk";
+               };
+
                fsl_mc: fsl-mc at 80c000000 {
                        compatible = "fsl,qoriq-mc";
                        reg = <0x00000008 0x0c000000 0 0x40>,    /* MC portal base */
--

1.7.9.5

#5 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 9 lines · Bhupesh SHARMA

Hi Arnd, Olof, Kevin

Quoted 4 lines · Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

Quoted 8 lines
Quoted 4 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56 ++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

Since Rob has acked the SP805 WDT binding documentation patch (patch 1/2 of this series),
can this DTSI change, please be considered for absorption in the arm-soc tree.

Sure, please submit it for inclusion. Who is the maintainer for arch/arm64/boot/dts/freescale/ ? Can they pick up all the freescale related dts changes and submit them as a pull request? Should they go through Shawn's tree maybe?

Arnd

#6 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 32 lines

-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Thursday, December 24, 2015 3:49 PM
To: Bhupesh SHARMA
Cc: Sharma Bhupesh-B45370; Mark Rutland; linux-arm-
kernel at lists.infradead.org; Olof Johansson; devicetree at vger.kernel.org; Rob Herring; Will Deacon; Catalin Marinas; Li Yang-Leo-R58472; Wood Scott-B07421; Yoder Stuart-B08248; shawn.guo at linaro.org
Subject: Re: [PATCH v3 2/2] dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 12 lines · Bhupesh SHARMA

Hi Arnd, Olof, Kevin

Quoted 7 lines · Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56

++++++++++++++++++++++++

Quoted 5 lines
Quoted 1 line
 1 file changed, 56 insertions(+)

Since Rob has acked the SP805 WDT binding documentation patch (patch 1/2 of this series),
can this DTSI change, please be considered for absorption in the arm-

Quoted 6 lines

soc tree.

Sure, please submit it for inclusion. Who is the maintainer for arch/arm64/boot/dts/freescale/ ? Can they pick up all the freescale related dts changes and submit them as a pull request? Should they go through Shawn's tree maybe?

Thanks Arnd. For now, may-be I can send this patchset with Rob's Acked-by added for 1/2 to 'arm at kernel.org'. So that this can be picked by via the arm-soc tree. Shawn, I hope it's ok with you.

In the meanwhile, I will discuss internally as to how we can have in place a freescale maintainer, who can submit the pull requests to the 'arm-soc' tree.

Regards,
Bhupesh

#7 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 34 lines · Sharma Bhupesh
Quoted 34 lines

-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Thursday, December 24, 2015 3:49 PM
To: Bhupesh SHARMA
Cc: Sharma Bhupesh-B45370; Mark Rutland; linux-arm-
kernel at lists.infradead.org; Olof Johansson; devicetree at vger.kernel.org; Rob Herring; Will Deacon; Catalin Marinas; Li Yang-Leo-R58472; Wood Scott-B07421; Yoder Stuart-B08248; shawn.guo at linaro.org
Subject: Re: [PATCH v3 2/2] dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 12 lines · Bhupesh SHARMA

Hi Arnd, Olof, Kevin

Quoted 7 lines · Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56

++++++++++++++++++++++++

Quoted 5 lines
Quoted 1 line
 1 file changed, 56 insertions(+)

Since Rob has acked the SP805 WDT binding documentation patch (patch 1/2 of this series),
can this DTSI change, please be considered for absorption in the arm-

soc tree.

Quoted 8 lines
Quoted 4 lines

Sure, please submit it for inclusion. Who is the maintainer for arch/arm64/boot/dts/freescale/ ? Can they pick up all the freescale related dts changes and submit them as a pull request? Should they go through Shawn's tree maybe?

Thanks Arnd. For now, may-be I can send this patchset with Rob's Acked-by added for 1/2 to 'arm at kernel.org'. So that this can be picked by via the arm-soc tree. Shawn, I hope it's ok with you.

Yeah. I'm maintaining a git tree, collecting all Freescale arm32 platform patches, and sending them to arm-soc for each merge window. If I can be copied on those arm64 patches, I do not mind handling them together with arm32 ones.

Shawn

#8 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 40 lines · Shawn Guo
Quoted 39 lines · Sharma Bhupesh
Quoted 38 lines

-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Thursday, December 24, 2015 3:49 PM
To: Bhupesh SHARMA
Cc: Sharma Bhupesh-B45370; Mark Rutland; linux-arm-
kernel at lists.infradead.org; Olof Johansson; devicetree at vger.kernel.org; Rob Herring; Will Deacon; Catalin Marinas; Li Yang-Leo-R58472; Wood Scott-B07421; Yoder Stuart-B08248; shawn.guo at linaro.org
Subject: Re: [PATCH v3 2/2] dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 12 lines · Bhupesh SHARMA

Hi Arnd, Olof, Kevin

Quoted 7 lines · Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56

++++++++++++++++++++++++

Quoted 5 lines
Quoted 1 line
 1 file changed, 56 insertions(+)

Since Rob has acked the SP805 WDT binding documentation patch (patch 1/2 of this series),
can this DTSI change, please be considered for absorption in the arm-

soc tree.

Sure, please submit it for inclusion. Who is the maintainer for arch/arm64/boot/dts/freescale/ ? Can they pick up all the freescale related dts changes and submit them as a pull request? Should they go through Shawn's tree maybe?

Quoted 8 lines
Quoted 3 lines

Thanks Arnd. For now, may-be I can send this patchset with Rob's Acked-by added for 1/2 to 'arm at kernel.org'. So that this can be picked by via the arm-soc tree. Shawn, I hope it's ok with you.

Yeah. I'm maintaining a git tree, collecting all Freescale arm32 platform patches, and sending them to arm-soc for each merge window. If I can be copied on those arm64 patches, I do not mind handling them together with arm32 ones.

Thanks Shawn. Sure, I will make sure to remember the same for future arm64 patches.

Regards,
Bhupesh

#9 lore raw

PATCH v3 2/2 dts/ls2080a: Update DTSI to add support of SP805 WDT

In reply to Shawn Guo
Quoted 40 lines · Shawn Guo
Quoted 39 lines · Sharma Bhupesh
Quoted 38 lines

-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Thursday, December 24, 2015 3:49 PM
To: Bhupesh SHARMA
Cc: Sharma Bhupesh-B45370; Mark Rutland; linux-arm-
kernel at lists.infradead.org; Olof Johansson; devicetree at vger.kernel.org; Rob Herring; Will Deacon; Catalin Marinas; Li Yang-Leo-R58472; Wood Scott-B07421; Yoder Stuart-B08248; shawn.guo at linaro.org
Subject: Re: [PATCH v3 2/2] dts/ls2080a: Update DTSI to add support of SP805 WDT

Quoted 12 lines · Bhupesh SHARMA

Hi Arnd, Olof, Kevin

Quoted 7 lines · Bhupesh Sharma

This patch updates the LS2080a DTSI (DTS Include) file to add support for eight SP805 Watchdog units which can be used to reset the eight Cortex-A57 cores available on LS2080A.

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |   56

++++++++++++++++++++++++

Quoted 5 lines
Quoted 1 line
 1 file changed, 56 insertions(+)

Since Rob has acked the SP805 WDT binding documentation patch (patch 1/2 of this series),
can this DTSI change, please be considered for absorption in the arm-

soc tree.

Sure, please submit it for inclusion. Who is the maintainer for arch/arm64/boot/dts/freescale/ ? Can they pick up all the freescale related dts changes and submit them as a pull request? Should they go through Shawn's tree maybe?

Quoted 8 lines
Quoted 3 lines

Thanks Arnd. For now, may-be I can send this patchset with Rob's Acked-by added for 1/2 to 'arm at kernel.org'. So that this can be picked by via the arm-soc tree. Shawn, I hope it's ok with you.

Yeah. I'm maintaining a git tree, collecting all Freescale arm32 platform patches, and sending them to arm-soc for each merge window. If I can be copied on those arm64 patches, I do not mind handling them together with arm32 ones.

Shawn, Thanks a lot for offering to help.

Sorry for a very delayed response as I was on vacation. I have recently been made responsible by the company to push and track the upstreaming of all armv8 related software within the Digital Networking group of FSL/NXP which is currently the only business unit to use ARMv8 cores. We also agreed in an internal discussion that it will be good for me to also help organize patches for upstream acceptance. I think I can help to make it more effective in communicating community requirements and feedback to all related developers and their management. And I can also help to enable the internal test team to better test the staging patches before they hit the mainline.

Regards,
Leo

#10 lore raw

v3 cover ARM64: Enable SP805 WDT support for FSL LS2080A

In reply to Bhupesh Sharma

Hi Rob, Mark,

Quoted 2 lines · Bhupesh Sharma

This is the v3 of patchset which adds the support for SP805 WDT on FSL LS2080A and also adds the missing documentation of SP805 WDT device-tree bindings.

Any comments on this version, or does it seems fine for integration into the arm-soc tree.

Regards,
Bhupesh

Quoted 29 lines

Rebased against arm-soc/next/dt

Changes since v2:
(v2 can be viewed here: http://permalink.gmane.org/gmane.linux.ports.arm.kernel/463141)
- Addressed Rob's comments regarding the second mandatory CLK source's (WDOGCLK) name in the bindings.

Changes since v1:
(v1 can be viewed here: http://www.spinics.net/lists/devicetree/msg102487.html)

- Addressed Rob and Mark's comments regarding the mandatory CLK sources
- Removed interrupt property from the bindings for now (as discussed
with Mark on IRC) till Will's patch proceeds further and enables handling the WDOG interrupts for each core connected to the same PPI line (http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/391616.html)

Bhupesh Sharma (2):
Documentation: DT: Add entry for ARM SP805-WDT dts/ls2080a: Update DTSI to add support of SP805 WDT

 .../devicetree/bindings/watchdog/sp805-wdt.txt     |   29 ++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi     |   56 ++++++++++++++++++++
 2 files changed, 85 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/sp805-wdt.txt

--
1.7.9.5