Skip to contentSkip to conversation

f2fs: support data flush in ioctl

PATCH In review Chao Yu 3 participants 3 messages Dec 24, 2015 – Dec 26, 2015 F2FS file system

lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH 4/5 f2fs: support data flush in ioctl

Sometimes user want to sync all data belong to superblock into storage for persistence, 'syncfs' syscall is one option, still f2fs supports similar one through ioctl, difference is that sb releted kworker is online for writebacking concurrently.

---
 fs/f2fs/file.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
fs/f2fs/file.c +10 -0
index a60d088..91997a5 100644
@@ -1621,6 +1621,7 @@ static int f2fs_ioc_write_checkpoint(struct file *filp, unsigned long arg)
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
 	struct cp_control cpc;
 	int err;
+	int flush_data;
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
@@ -1628,6 +1629,15 @@ static int f2fs_ioc_write_checkpoint(struct file *filp, unsigned long arg)
 	if (f2fs_readonly(sbi->sb))
 		return -EROFS;
 
+	if (get_user(flush_data, (__u32 __user *)arg))
+		return -EFAULT;
+
+	if (flush_data) {
+		err = sync_dirty_inodes(sbi, FILE_INODE);
+		if (err)
+			return err;
+	}
+
 	cpc.reason = __get_cp_reason(sbi);
 
 	mutex_lock(&sbi->gc_mutex);
Signature · 1 line
2.6.3
maintainer
#1 lore raw

Hi Chao,

Quoted 4 lines · Chao Yu

Sometimes user want to sync all data belong to superblock into storage for persistence, 'syncfs' syscall is one option, still f2fs supports similar one through ioctl, difference is that sb releted kworker is online for writebacking concurrently.

There is compatibility issue, since you're trying to change pre-defined ioctl; it needs to change F2FS_IOC_WRITE_CHECKPOINT too, right? I'm in doubt that we really need to expose this too.

Thanks,

Quoted 37 lines
---
 fs/f2fs/file.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
fs/f2fs/file.c +10 -0
index a60d088..91997a5 100644
@@ -1621,6 +1621,7 @@ static int f2fs_ioc_write_checkpoint(struct file *filp, unsigned long arg)
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
 	struct cp_control cpc;
 	int err;
+	int flush_data;
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
@@ -1628,6 +1629,15 @@ static int f2fs_ioc_write_checkpoint(struct file *filp, unsigned long arg)
 	if (f2fs_readonly(sbi->sb))
 		return -EROFS;
 
+	if (get_user(flush_data, (__u32 __user *)arg))
+		return -EFAULT;
+
+	if (flush_data) {
+		err = sync_dirty_inodes(sbi, FILE_INODE);
+		if (err)
+			return err;
+	}
+
 	cpc.reason = __get_cp_reason(sbi);
 
 	mutex_lock(&sbi->gc_mutex);
Signature · 1 line
2.6.3
maintainer
#2 lore raw

Hi Jaegeuk,

Quoted 10 lines · Jaegeuk Kim

Hi Chao,

Quoted 4 lines · Chao Yu

Sometimes user want to sync all data belong to superblock into storage for persistence, 'syncfs' syscall is one option, still f2fs supports similar one through ioctl, difference is that sb releted kworker is online for writebacking concurrently.

There is compatibility issue, since you're trying to change pre-defined ioctl;

Agreed.

Quoted 1 line

it needs to change F2FS_IOC_WRITE_CHECKPOINT too, right?

Yes, maybe F2FS_IOC_WRITE_CHECKPOINT_V2 if we have to change this interface.

Quoted 1 line

I'm in doubt that we really need to expose this too.

There is no obviously demands, but for Marc Lehmann's scenario I expect this can provide less latency by concurrently writebacking when syncing the whole f2fs partition.

Thanks,

Quoted 47 lines

Thanks,

Quoted 37 lines
---
 fs/f2fs/file.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
fs/f2fs/file.c +10 -0
index a60d088..91997a5 100644
@@ -1621,6 +1621,7 @@ static int f2fs_ioc_write_checkpoint(struct file *filp, unsigned long arg)
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
 	struct cp_control cpc;
 	int err;
+	int flush_data;
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
@@ -1628,6 +1629,15 @@ static int f2fs_ioc_write_checkpoint(struct file *filp, unsigned long arg)
 	if (f2fs_readonly(sbi->sb))
 		return -EROFS;
 
+	if (get_user(flush_data, (__u32 __user *)arg))
+		return -EFAULT;
+
+	if (flush_data) {
+		err = sync_dirty_inodes(sbi, FILE_INODE);
+		if (err)
+			return err;
+	}
+
 	cpc.reason = __get_cp_reason(sbi);
 
 	mutex_lock(&sbi->gc_mutex);
Signature · 1 line
2.6.3

------------------------------------------------------------------------------
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel