core: add defconfig to .gitignore
PATCH v2 1/1 core: add defconfig to .gitignore
From: Karoly Kasza <[email protected]>
After using "make safedefconfig", a defconfig file appears which is an extract of the .config file. When running git, it incorrectly detects it as a source code change.
Add /defconfig to .gitignore.
---
Changes v1 -> v2:
- do not remove on distclean
--- .gitignore | 1 + 1 file changed, 1 insertion(+)
.gitignore +1 -0
@@ -5,6 +5,7 @@ /.config.old /..config.tmp /.config +/defconfig *.depend *.o /*.patch
Signature · 1 line
1.9.1
PATCH v2 1/1 core: add defconfig to .gitignore
Yann,
Quoted 11 lines · Yann E. MORIN
From: Karoly Kasza <[email protected]>
After using "make safedefconfig", a defconfig file appears which is an extract of the .config file. When running git, it incorrectly detects it as a source code change.
Add /defconfig to .gitignore.
Signed-off-by Karoly Kasza <[email protected]>[yann.morin.1998 at free.fr: do not remove on distclean]Signed-off-by "Yann E. MORIN" <[email protected]>
I continue to question whether this is the right thing to do. "defconfig" is really only the default name, and it can be changed to anything by changing BR2_DEFCONFIG. So should we gitignore the default name, but not any other name?
I'm for the principle of least surprise, and I would personally find it odd that we gitignore the default name only. Since we can't gitignore all defconfigs, I'd prefer to not gitignore any of them.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 core: add defconfig to .gitignore
Thomas, All,
On 2015-12-29 09:19 +0100, Thomas Petazzoni spake thusly:
Quoted 13 lines · Yann E. MORIN
Quoted 11 lines
From: Karoly Kasza <[email protected]>
After using "make safedefconfig", a defconfig file appears which is an extract of the .config file. When running git, it incorrectly detects it as a source code change.
Add /defconfig to .gitignore.
Signed-off-by Karoly Kasza <[email protected]>[yann.morin.1998 at free.fr: do not remove on distclean]Signed-off-by "Yann E. MORIN" <[email protected]>
Quoted 8 lines
I continue to question whether this is the right thing to do. "defconfig" is really only the default name, and it can be changed to anything by changing
BR2_DEFCONFIG. So should we gitignore the default name, but not any other name?I'm for the principle of least surprise, and I would personally find it odd that we gitignore the default name only. Since we can't gitignore all defconfigs, I'd prefer to not gitignore any of them.
Yes, and I guess with the recent ML issues you did not catch my reply in
the initial thread;
http://lists.busybox.net/pipermail/buildroot/2015-December/148452.htmlAnd since I did respin that patch before you replied there, this is now moot. At that time, that patch did not appear on Pathwork when I wanted to mark it reject. I guess it is now marked Rejected in Patchwork? ;-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 core: add defconfig to .gitignore
Yann,
Quoted 7 lines · Yann E. MORIN
Yes, and I guess with the recent ML issues you did not catch my reply in
the initial thread; http://lists.busybox.net/pipermail/buildroot/2015-December/148452.htmlAnd since I did respin that patch before you replied there, this is now moot. At that time, that patch did not appear on Pathwork when I wanted to mark it reject. I guess it is now marked Rejected in Patchwork? ;-)
I think you can mark it as rejected indeed.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 core: add defconfig to .gitignore
Thomas, K?roly, All,
On 2015-12-29 18:07 +0100, Thomas Petazzoni spake thusly:
Quoted 10 lines · Yann E. MORIN
Quoted 7 lines
Yes, and I guess with the recent ML issues you did not catch my reply in
the initial thread; http://lists.busybox.net/pipermail/buildroot/2015-December/148452.htmlAnd since I did respin that patch before you replied there, this is now moot. At that time, that patch did not appear on Pathwork when I wanted to mark it reject. I guess it is now marked Rejected in Patchwork? ;-)
I think you can mark it as rejected indeed.
Done.
Thanks!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'