Skip to contentSkip to conversation

Fix compile error when CONFIG_UBI_SILENCE_MSG defined

PATCH New Ladislav Michl 2 participants 4 messages Dec 30, 2015 – Jan 4, 2016

Subsystems (2)
Memory technology devices (MTD) Unsorted block images (UBI)
lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH 1/1 Fix compile error when CONFIG_UBI_SILENCE_MSG defined

Signed-off-by Ladislav Michl <[email protected]>
---
 drivers/mtd/ubi/io.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mtd/ubi/io.c +0 -1
index d1bdec3..0be9c5a 100644
@@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
 		ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
 			pnum, offset, len);
 		ubi_msg(ubi, "data differ at position %d", i);
-		dump_len = max_t(int, 128, len - i);
 		ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
 			i, i + dump_len);
 		print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/1 UBI: Fix compile error when CONFIG_UBI_SILENCE_MSG defined

drivers/mtd/ubi/io.c:1354:3: error: 'dump_len' undeclared (first use in this function)
dump_len = max_t(int, 128, len - i);

Signed-off-by Ladislav Michl <[email protected]>
---
 drivers/mtd/ubi/io.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mtd/ubi/io.c +0 -1
index d1bdec3..0be9c5a 100644
@@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
 		ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
 			pnum, offset, len);
 		ubi_msg(ubi, "data differ at position %d", i);
-		dump_len = max_t(int, 128, len - i);
 		ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
 			i, i + dump_len);
 		print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
Signature · 1 line
2.1.4
#2 lore raw

PATCH 1/1 UBI: Fix compile error when CONFIG_UBI_SILENCE_MSG defined

Hello Ladislav Michl

Am 03.01.2016 um 22:05 schrieb Ladislav Michl:

Quoted 8 lines

drivers/mtd/ubi/io.c:1354:3: error: 'dump_len' undeclared (first use in this function)

    dump_len = max_t(int, 128, len - i);
Signed-off-by Ladislav Michl <[email protected]>
---
  drivers/mtd/ubi/io.c | 1 -
  1 file changed, 1 deletion(-)

You sended this patch twice? Old version here:

http://patchwork.ozlabs.org/patch/561670/

removed this patch from patchwork.

bye,
Heiko

Quoted 14 lines
drivers/mtd/ubi/io.c +0 -1
index d1bdec3..0be9c5a 100644
@@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
  		ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
  			pnum, offset, len);
  		ubi_msg(ubi, "data differ at position %d", i);
-		dump_len = max_t(int, 128, len - i);
  		ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
  			i, i + dump_len);
  		print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 1/1 UBI: Fix compile error when CONFIG_UBI_SILENCE_MSG defined

In reply to Ladislav Michl

Hello Ladislav Michl,

Am 03.01.2016 um 22:05 schrieb Ladislav Michl:

Quoted 8 lines

drivers/mtd/ubi/io.c:1354:3: error: 'dump_len' undeclared (first use in this function)

    dump_len = max_t(int, 128, len - i);
Signed-off-by Ladislav Michl <[email protected]>
---
  drivers/mtd/ubi/io.c | 1 -
  1 file changed, 1 deletion(-)

Thanks!

Applied to u-boot-ubi.git

bye,
Heiko

Quoted 14 lines
drivers/mtd/ubi/io.c +0 -1
index d1bdec3..0be9c5a 100644
@@ -1351,7 +1351,6 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
  		ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
  			pnum, offset, len);
  		ubi_msg(ubi, "data differ at position %d", i);
-		dump_len = max_t(int, 128, len - i);
  		ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
  			i, i + dump_len);
  		print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany