Skip to contentSkip to conversation

python-paho-mqtt: add new package

PATCH New Davide Viti 2 participants 2 messages Dec 30, 2015

lore
Share & tools
lore

Davide Viti

author
#0 lore raw

PATCH v3 1/1 python-paho-mqtt: add new package

Reviewed-by Yegor Yefremov <[email protected]>
Signed-off-by Davide Viti <[email protected]>

v1 -> v2:
- Provide official md5 (suggested by Yegor Yefremov)
- Reword package description (suggested by Thomas Petazzoni)
- Use "distutils" setup type (suggested by Yegor Yefremov)
- Add "depends on BR2_PACKAGE_PYTHON" in Config.in
- Test with Python3 (suggested by Yegor Yefremov)

v2 -> v3:
- Remove dependency on BR2_PACKAGE_PYTHON since the package builds fine against Python 3 (suggested by Yegor Yefremov)

---
 package/Config.in                              |  1 +
 package/python-paho-mqtt/Config.in             |  9 +++++++++
 package/python-paho-mqtt/python-paho-mqtt.hash |  3 +++
 package/python-paho-mqtt/python-paho-mqtt.mk   | 14 ++++++++++++++
 4 files changed, 27 insertions(+)
 create mode 100644 package/python-paho-mqtt/Config.in
 create mode 100644 package/python-paho-mqtt/python-paho-mqtt.hash
 create mode 100644 package/python-paho-mqtt/python-paho-mqtt.mk
package/Config.in +1 -0
index dd44743..aab1958 100644
@@ -659,6 +659,7 @@ menu "External python modules"
 	source "package/python-networkmanager/Config.in"
 	source "package/python-nfc/Config.in"
 	source "package/python-numpy/Config.in"
+	source "package/python-paho-mqtt/Config.in"
 	source "package/python-pam/Config.in"
 	source "package/python-posix-ipc/Config.in"
 	source "package/python-protobuf/Config.in"
package/python-paho-mqtt/Config.in new file +9 -0
new file mode 100644
index 0000000..79d8b33
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_PAHO_MQTT
+	bool "python-paho-mqtt"
+	help
+	  The Paho Python Client provides a client class with support
+	  for both MQTT v3.1 and v3.1.1 on Python 2.7 or 3.x. It also
+	  provides some helper functions to make publishing messages
+	  to an MQTT server very straightforward.
+
+	  https://pypi.python.org/pypi/paho-mqtt
package/python-paho-mqtt/python-paho-mqtt.hash new file +3 -0
new file mode 100644
index 0000000..52729cc
@@ -0,0 +1,3 @@
+# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=a6407b74eb5e5411e157be1de5c11366, sha256 locally computed
+md5     a6407b74eb5e5411e157be1de5c11366  paho-mqtt-1.1.tar.gz
+sha256  0f7a629efe6e3a2c61b59d3550aa9f2c4529b5689a65fde45e6f1ac36b9a261e  paho-mqtt-1.1.tar.gz
package/python-paho-mqtt/python-paho-mqtt.mk new file +14 -0
new file mode 100644
index 0000000..01da2b3
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-paho-mqtt
+#
+################################################################################
+
+PYTHON_PAHO_MQTT_VERSION = 1.1
+PYTHON_PAHO_MQTT_SOURCE = paho-mqtt-$(PYTHON_PAHO_MQTT_VERSION).tar.gz
+PYTHON_PAHO_MQTT_SITE = https://pypi.python.org/packages/source/p/paho-mqtt
+PYTHON_PAHO_MQTT_LICENSE = EPLv1.0 or EDLv1.0
+PYTHON_PAHO_MQTT_LICENSE_FILES = LICENSE.txt edl-v10 epl-v10
+PYTHON_PAHO_MQTT_SETUP_TYPE = distutils
+
+$(eval $(python-package))
Signature · 1 line
2.1.4
#1 lore raw

PATCH v3 1/1 python-paho-mqtt: add new package

Dear Davide Viti,

Quoted 1 line · Davide Viti
Reviewed-by Yegor Yefremov <[email protected]>

Yegor didn't give you his Reviewed-by. It is not because someone commented on your patch that this person is giving you his formal Reviewed-by.

See
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L539
for the meaning of Reviewed-by.

And specifically, if someone has made comments, it indicates that your patch wasn't fully correct, and therefore this person is *not* giving you his Reviewed-by.

Quoted 9 lines
Signed-off-by Davide Viti <[email protected]>

v1 -> v2:
- Provide official md5 (suggested by Yegor Yefremov)
- Reword package description (suggested by Thomas Petazzoni)
- Use "distutils" setup type (suggested by Yegor Yefremov)
- Add "depends on BR2_PACKAGE_PYTHON" in Config.in
- Test with Python3 (suggested by Yegor Yefremov)

Quoted 3 lines

v2 -> v3:
- Remove dependency on BR2_PACKAGE_PYTHON since the package builds fine against Python 3 (suggested by Yegor Yefremov)

Such changelog is very good, but should be place below the "---" sign...

Quoted 2 lines

---

here.

If you don't do this, when I apply the patch, the changelog is kept in the commit log, which we don't want.

I've fixed those two minor issues, and applied your patch.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com