btrfs:Fix incorrect return statement if failure occurs in the function btrfs_mark_extent_written
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 17 lines · Nicholas Krause
This fixes the incorrect return statement if failure occurs by returning 0 rather then the variable ret which may hold a error code to signal when a failure has occurred in the function
btrfs_mark_extent_writtento its callers rather then always making this function appear to run successfully to its callers by always returning zero.Signed-off-by Nicholas Krause <[email protected]>--- fs/btrfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/btrfs/file.c +0
-0
fs/btrfs/file.c again: · line 1280
Quoted 6 lines
fs/btrfs/file.c +1
-1@@ -1276,7 +1276,7 @@ again: } out:btrfs_free_path (path); -return 0 ; +return ret; }
We're checking ret higher up and aborting the transaction properly. There is at least one place ret will be non-zero above that isn't an error, but you're passing it to the caller here making them think it has gone wrong.
-chris