all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Subsystems (2)
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the Kconfig keywords) to automatically arrange the sub-options into sub-menus;
- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
Using 'menuconfig' (like bar, below) instead of 'config'+'menu' (like foo, below) provides a nicer layout (but that's just my taste!):
[*] foo
foo sub-menu --->
[*] bar --->Finally, moving 5-or-more sub-options to sub-menus also provides for a nicer layout. Of course, I choose 5 arbitrarily; we can refine this value, but 5 looked obvious to me.
Last note: I did try to hunt fro all packages, but it is not possible to either:
- review all Config.in, or
- see all packages in the menuconfig UI (because of arch dependencies for example)
So, I may have missed a few... These can be fixed later.
This series is just an RFC, and is not available in Patchwork. If we decide that we do want it, I'll rebase it and re-submit. However, applyingg 84 patches from Patchwork is probably a bit cumbersome, so the series is also available for git-pull (see below).
Regards,
Yann E. MORIN.
The following changes since commit 3068555c47c15afb62988d35e5e148dc691c6eb9:
python-ipaddress: new package (2015-12-25 19:48:22 +0100)
are available in the git repository at:
git://git.busybox.net/~ymorin/git/buildroot yem/menuconfig
for you to fetch changes up to a93897991f9d246db5f8b92c18e4edce191ec6d6:
boot/uboot: use 'menuconfig' (2015-12-25 20:00:20 +0100)
----------------------------------------------------------------
Yann E. MORIN (84):
package/alsa-lib: move comment around, to keep proper indentation package/gstreamer: move comment around, to keep proper indentation package/gstreamer1: move comment around, to keep proper indentation package/nodejs: move comment around, to keep proper indentation package/tcl: move comment around, to keep proper indentation package/udpcast: move comment around, to keep proper indentation package/alsa-lib: use 'menuconfig' instad of 'config'+'menu' package/alsa-utils: use 'menuconfig' instead of 'config'+'menu' package/angularjs: use 'menuconfig' instad of 'config'+'menu' package/angularjs: simplify modules selection package/collectd: use 'menuconfig' instead of 'config'+'menu' package/gd: use 'menuconfig' instad of 'config'+'menu' package/gpsd: use 'menuconfig' instead of 'config'+'menu' package/jquery: include external plugins from jquery's Config.in package/libdrm: move tests programs to the bottom package/libdrm: use 'menuconfig' instad of 'config'+'menu' package/mono: use 'menuconfig' instead of 'config'+'menu' package/ncftp: use 'menuconfig' instad of 'config'+'menu' package/nfs-utils: use 'menuconfig' instead of 'config'+'menu' package/nodejs: use 'menuconfig' instead of 'config'+'menu' package/ola: use 'menuconfig' instead of 'config'+'menu' package/perl: use 'menuconfig' instead of 'config'+'menu' package/php: move list of extensions after interface selection package/php: use 'menuconfig' instad of 'config'+'menu' package/python: use 'menuconfig' instad of 'config'+'menu' package/python3: use 'menuconfig' instad of 'config'+'menu' package/python{,3}: move inclusion of external python modules package/sdl_image: use 'menuconfig' instead of 'config'+'menu' package/tcl: use 'menuconfig' instad of 'config'+'menu' package/tiff: use 'menuconfig' instad of 'config'+'menu' package/udpcast: use 'menuconfig' instad of 'config'+'menu' package/gstreamer: include plugins from gstreamer's real Config.in package/gstreamer: use 'menuconfig' instead of 'config'+'menu' package/gstreamer1: include plugins from gstreamer1's real Config.in package/gstreamer1: use 'menuconfig' instead of 'config'+'menu' docs/manual: slightly compactify a paragraph docs/manual: add ordering of kconfig options' attributes docs/manual: add example about sub-options
docs/manual: use 'menuconfig' when there are more than 5 sub-options package/valgrind: use 'menuconfig'
package/e2fsprogs: use 'menuconfig'
package/mtd: use 'menuconfig'
package/squashfs: use 'menuconfig'
package/dejavu: use 'menuconfig' package/google-material-design-icons: use 'menuconfig' package/directfb: use 'menuconfig'
package/efl: use 'menuconfig'
package/sdl: use 'menuconfig'
package/sdl: include SDL external libraries from sdl's Config.in package/sdl_*: remove redundant dependency package/lm-sensors: use 'menuconfig'
package/openocd: use 'menuconfig'
package/erlang: include Erlang libraries from erlang's Config.in package/lua{,jit}: move inclusion of external libraries/modules package/sqlite: use 'menuconfig'
package/cairo: use 'menuconfig'
package/imlib2: use 'menuconfig'
package/libiio: use 'menuconfig'
package/flot: use 'menuconfig'
package/boost: use 'menuconfig'
package/poco: use 'menuconfig'
package/ncurses: use 'menuconfig'
package/dovecot: use 'menuconfig'
package/gnuradio: use 'menuconfig'
package/gnuradio: split long omment
package/connman: use 'menuconfig'
package/dnsmasq: use 'menuconfig'
package/dropbear: use 'menuconfig'
package/igh-ethercat: use 'menuconfig' package/ipsec-tools: use 'menuconfig'
package/lftp: use 'menuconfig'
package/lighttpd: use 'menuconfig'
package/ndisc6: use 'menuconfig'
package/netsnmp: use 'menuconfig'
package/ntp: use 'menuconfig'
package/openobex: use 'menuconfig'
package/quagga: use 'menuconfig'
package/transmission: use 'menuconfig' package/wpa-supplicant: use 'menuconfig' boot/at91bootstrap3: use 'menuconfig'
boot/barebox: use 'menuconfig'
boot/grub: use 'menuconfig'
boot/mxs-bootlets: use 'menuconfig'
boot/uboot: use 'menuconfig'
boot/at91bootstrap3/Config.in | 2 +- boot/barebox/Config.in | 3 +- boot/grub/Config.in | 10 +- boot/mxs-bootlets/Config.in | 2 +- boot/uboot/Config.in | 3 +- docs/manual/adding-packages-directory.txt | 73 +++++++- package/Config.in | 250 ------------------------- package/alsa-lib/Config.in | 12 +- package/alsa-utils/Config.in | 7 +- package/angularjs/Config.in | 37 ++-- package/angularjs/angularjs.mk | 24 ++- package/boost/Config.in | 2 +- package/cairo/Config.in | 2 +- package/collectd/Config.in | 21 +-- package/connman/Config.in | 2 +- package/dejavu/Config.in | 2 +- package/directfb/Config.in | 2 +- package/dnsmasq/Config.in | 2 +- package/dovecot/Config.in | 2 +- package/dropbear/Config.in | 2 +- package/e2fsprogs/Config.in | 3 +- package/efl/Config.in | 2 +- package/erlang/Config.in | 17 +- package/flot/Config.in | 4 +- package/gd/Config.in | 6 +- package/gnuradio/Config.in | 9 +- package/google-material-design-icons/Config.in | 2 +- package/gpsd/Config.in | 25 +-- package/gstreamer/Config.in | 12 -- package/gstreamer/gstreamer/Config.in | 20 +- package/gstreamer1/Config.in | 11 -- package/gstreamer1/gstreamer1/Config.in | 19 +- package/igh-ethercat/Config.in | 2 +- package/imlib2/Config.in | 3 +- package/ipsec-tools/Config.in | 2 +- package/jquery/Config.in | 17 +- package/lftp/Config.in | 2 +- package/libdrm/Config.in | 14 +- package/libiio/Config.in | 2 +- package/lighttpd/Config.in | 2 +- package/lm-sensors/Config.in | 3 +- package/lua/Config.ext | 49 +++++ package/lua/Config.in | 4 +- package/luajit/Config.ext | 1 + package/luajit/Config.in | 4 +- package/mono/Config.in | 8 +- package/mtd/Config.in | 3 +- package/ncftp/Config.in | 6 +- package/ncurses/Config.in | 2 +- package/ndisc6/Config.in | 2 +- package/netsnmp/Config.in | 2 +- package/nfs-utils/Config.in | 6 +- package/nodejs/Config.in | 20 +- package/ntp/Config.in | 2 +- package/ola/Config.in | 14 +- package/openobex/Config.in | 2 +- package/openocd/Config.in | 4 +- package/perl/Config.in | 48 ++++- package/php/Config.ext | 20 +- package/php/Config.in | 6 +- package/poco/Config.in | 4 +- package/python/Config.ext | 96 ++++++++++ package/python/Config.in | 6 +- package/python3/Config.ext | 1 + package/python3/Config.in | 6 +- package/quagga/Config.in | 2 +- package/sdl/Config.in | 11 +- package/sdl_gfx/Config.in | 1 - package/sdl_image/Config.in | 7 +- package/sdl_mixer/Config.in | 1 - package/sdl_net/Config.in | 1 - package/sdl_sound/Config.in | 1 - package/sdl_ttf/Config.in | 1 - package/sqlite/Config.in | 2 +- package/squashfs/Config.in | 2 +- package/tcl/Config.in | 15 +- package/tiff/Config.in | 4 +- package/transmission/Config.in | 3 +- package/udpcast/Config.in | 14 +- package/valgrind/Config.in | 2 +- package/wpa_supplicant/Config.in | 2 +- 81 files changed, 526 insertions(+), 496 deletions(-) create mode 100644 package/lua/Config.ext create mode 120000 package/luajit/Config.ext create mode 100644 package/python/Config.ext create mode 120000 package/python3/Config.ext
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 1/84 package/alsa-lib: move comment around, to keep proper indentation
In Kconfig, when there is an item (lie a comment) between a symbol and its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in the menuconfig.
--- package/alsa-lib/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
package/alsa-lib/Config.in +3 -3
@@ -1,3 +1,6 @@ +comment "alsa-lib needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS + config BR2_PACKAGE_ALSA_LIB bool "alsa-lib" # Temporary until
@@ -15,9 +18,6 @@ config BR2_PACKAGE_ALSA_LIB http://www.alsa-project.org/ -comment "alsa-lib needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS - if BR2_PACKAGE_ALSA_LIB config BR2_PACKAGE_ALSA_LIB_PYTHON
Signature · 1 line
1.9.1
RFC PATCH 2/84 package/gstreamer: move comment around, to keep proper indentation
In reply to Yann E. MORINIn Kconfig, when there is an item (lie a comment) between a symbol and its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in the menuconfig.
In this case, it means the gstremaer plugins are not indented below the main gstreamer prompt.
--- package/gstreamer/gstreamer/Config.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
package/gstreamer/gstreamer/Config.in +4 -4
@@ -1,3 +1,7 @@ +comment "gstreamer 0.10 needs a toolchain w/ wchar, threads" + depends on BR2_USE_MMU + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS + config BR2_PACKAGE_GSTREAMER bool "gstreamer 0.10" depends on BR2_USE_WCHAR # glib2
@@ -30,7 +34,3 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY the launch-time for a GStreamer application. endif - -comment "gstreamer 0.10 needs a toolchain w/ wchar, threads" - depends on BR2_USE_MMU - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.9.1
RFC PATCH 3/84 package/gstreamer1: move comment around, to keep proper indentation
In reply to Yann E. MORINIn Kconfig, when there is an item (lie a comment) between a symbol and its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in the menuconfig.
In this case, it means the gstremaer1 plugins are not indented below the main gstreamer1 prompt.
--- package/gstreamer1/gstreamer1/Config.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
package/gstreamer1/gstreamer1/Config.in +4 -4
@@ -1,3 +1,7 @@ +comment "gstreamer 1.x needs a toolchain w/ wchar, threads" + depends on BR2_USE_MMU + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS + config BR2_PACKAGE_GSTREAMER1 bool "gstreamer 1.x" depends on BR2_USE_WCHAR # glib2
@@ -49,7 +53,3 @@ config BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS additional space on the target. endif - -comment "gstreamer 1.x needs a toolchain w/ wchar, threads" - depends on BR2_USE_MMU - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.9.1
RFC PATCH 4/84 package/nodejs: move comment around, to keep proper indentation
In reply to Yann E. MORINIn Kconfig, when there is an item (like a comment) between a symbol and its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in the menuconfig.
--- package/nodejs/Config.in | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
package/nodejs/Config.in +7 -7
@@ -1,3 +1,10 @@ +comment "nodejs needs a toolchain w/ C++, dynamic library, threads" + depends on BR2_USE_MMU + depends on BR2_arm || BR2_i386 || BR2_x86_64 || BR2_mipsel + depends on !BR2_MIPS_SOFT_FLOAT + depends on !BR2_ARM_CPU_ARMV4 + depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS + config BR2_PACKAGE_NODEJS bool "nodejs" depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -17,13 +24,6 @@ config BR2_PACKAGE_NODEJS http://nodejs.org/ -comment "nodejs needs a toolchain w/ C++, dynamic library, threads" - depends on BR2_USE_MMU - depends on BR2_arm || BR2_i386 || BR2_x86_64 || BR2_mipsel - depends on !BR2_MIPS_SOFT_FLOAT - depends on !BR2_ARM_CPU_ARMV4 - depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS - if BR2_PACKAGE_NODEJS # Starting with 0.12.x, on ARM, V8 (the JS engine)
Signature · 1 line
1.9.1
RFC PATCH 5/84 package/tcl: move comment around, to keep proper indentation
In reply to Yann E. MORINIn Kconfig, when there is an item (like a comment) between a symbol and its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in the menuconfig.
--- package/tcl/Config.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
package/tcl/Config.in +4 -4
@@ -1,3 +1,7 @@ +comment "tcl needs a toolchain w/ threads, dynamic library" + depends on BR2_USE_MMU + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + config BR2_PACKAGE_TCL bool "tcl" # fork()
@@ -11,10 +15,6 @@ config BR2_PACKAGE_TCL http://www.tcl.tk -comment "tcl needs a toolchain w/ threads, dynamic library" - depends on BR2_USE_MMU - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - if BR2_PACKAGE_TCL config BR2_PACKAGE_TCL_DEL_ENCODINGS
Signature · 1 line
1.9.1
RFC PATCH 6/84 package/udpcast: move comment around, to keep proper indentation
In reply to Yann E. MORINIn Kconfig, when there is an item (lie a comment) between a symbol and its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in the menuconfig.
--- package/udpcast/Config.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
package/udpcast/Config.in +4 -4
@@ -1,3 +1,7 @@ +comment "udpcast needs a toolchain w/ threads" + depends on BR2_USE_MMU + depends on !BR2_TOOLCHAIN_HAS_THREADS + config BR2_PACKAGE_UDPCAST bool "udpcast" depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -8,10 +12,6 @@ config BR2_PACKAGE_UDPCAST http://www.udpcast.linux.lu/ -comment "udpcast needs a toolchain w/ threads" - depends on BR2_USE_MMU - depends on !BR2_TOOLCHAIN_HAS_THREADS - if BR2_PACKAGE_UDPCAST menu "udpcast tools selection"
Signature · 1 line
1.9.1
RFC PATCH 7/84 package/alsa-lib: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN--- package/alsa-lib/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
package/alsa-lib/Config.in +1 -5
@@ -1,7 +1,7 @@ comment "alsa-lib needs a toolchain w/ threads" depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_ALSA_LIB +menuconfig BR2_PACKAGE_ALSA_LIB bool "alsa-lib" # Temporary until # https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4913
@@ -29,8 +29,6 @@ config BR2_PACKAGE_ALSA_LIB_PYTHON in the target directory http://www.alsa-project.org/ -menu "ALSA lib selection" - config BR2_PACKAGE_ALSA_LIB_DEVDIR string "directory with ALSA device files" default "/dev/snd"
@@ -77,6 +75,4 @@ config BR2_PACKAGE_ALSA_LIB_OLD_SYMBOLS bool "old-symbols" default y -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 8/84 package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORIN--- package/alsa-utils/Config.in | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
package/alsa-utils/Config.in +3 -4
@@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads" depends on BR2_USE_MMU # fork depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_ALSA_UTILS +menuconfig BR2_PACKAGE_ALSA_UTILS bool "alsa-utils" depends on BR2_USE_MMU # fork depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
@@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS http://www.alsa-project.org/ if BR2_PACKAGE_ALSA_UTILS -menu "ALSA utils selection" + +comment "ALSA utils selection" config BR2_PACKAGE_ALSA_UTILS_ALSACONF bool "alsaconf"
@@ -85,6 +86,4 @@ config BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST select BR2_PACKAGE_ALSA_LIB_PCM bool "speaker-test" -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 8/84 package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'
Quoted 19 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/alsa-utils/Config.in | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)package/alsa-utils/Config.in +1
-1@@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads" depends on BR2_USE_MMU # fork depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_ALSA_UTILS +menuconfig BR2_PACKAGE_ALSA_UTILS bool "alsa-utils" depends on BR2_USE_MMU # fork depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
package/alsa-utils/Config.in config BR2_PACKAGE_ALSA_UTILS · line 19
Quoted 6 lines
package/alsa-utils/Config.in +2
-1@@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS http://www.alsa-project.org/ if BR2_PACKAGE_ALSA_UTILS -menu "ALSA utils selection" + +comment "ALSA utils selection"
I don't think this comment is needed. Also, why do you do it for alsa-utils but
not alsa-lib?
Regards,
Arnout
Quoted 11 lines
package/alsa-utils/Config.in +0
-2config BR2_PACKAGE_ALSA_UTILS_ALSACONF bool "alsaconf"@@ -85,6 +86,4 @@ config BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST select BR2_PACKAGE_ALSA_LIB_PCM bool "speaker-test" -endmenu - endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 8/84 package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'
Arnout, All,
On 2015-12-31 00:03 +0100, Arnout Vandecappelle spake thusly:
Quoted 22 lines · Yann E. MORIN
Quoted 21 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/alsa-utils/Config.in | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)package/alsa-utils/Config.in +1
-1@@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads" depends on BR2_USE_MMU # fork depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_ALSA_UTILS +menuconfig BR2_PACKAGE_ALSA_UTILS bool "alsa-utils" depends on BR2_USE_MMU # fork depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib@@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS http://www.alsa-project.org/
Quoted 6 lines
package/alsa-utils/Config.in config BR2_PACKAGE_ALSA_UTILS · line 19
Quoted 4 lines
package/alsa-utils/Config.in +2
-1if BR2_PACKAGE_ALSA_UTILS -menu "ALSA utils selection" + +comment "ALSA utils selection"I don't think this comment is needed.
I don't care about that comment either. ;-)
Quoted 2 lines
Also, why do you do it for alsa-utils but
not alsa-lib?
Because I skimmed through the menuconfig UI, seeeking those constructs, and alsa-utils is very early, with alsa-lib much later, with a lot of packages between the two, and I may have changed my mind in-between.
This does not really appear in the series, because I then rebased it and re-ordered alphabetically on packages' names.
I agree that, when there is a single 'category', there's no need for a comment. I will drop.
Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 9/84 package/angularjs: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN... and change the modules 'menuconfig' to a simple 'config'
--- package/angularjs/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/angularjs/Config.in +2 -2
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_ANGULARJS +menuconfig BR2_PACKAGE_ANGULARJS bool "angularjs" help AngularJS web application framework.
@@ -7,7 +7,7 @@ config BR2_PACKAGE_ANGULARJS if BR2_PACKAGE_ANGULARJS -menuconfig BR2_ANGULARJS_MODULES +config BR2_ANGULARJS_MODULES bool "angularjs modules" help Select which modules to install. If disabled, all modules
Signature · 1 line
1.9.1
RFC PATCH 10/84 package/angularjs: simplify modules selection
In reply to Yann E. MORINRemove the superfluous config option, and make all modules default to 'y', which provides exactly the same functionality.
simplify (and slightly beautofy) the handling of modules in the .mk:
since the modules' symbols are always meaningful now, we can get rid of the else-clause, and always build the list of modules using the Kconfig options.
Re-order the list alphabetically (message <-> message-format).
--- package/angularjs/Config.in | 35 +++++++++++++++++++++-------------- package/angularjs/angularjs.mk | 24 +++++++++++++++--------- 2 files changed, 36 insertions(+), 23 deletions(-)
package/angularjs/Config.in +21 -14
@@ -7,16 +7,17 @@ menuconfig BR2_PACKAGE_ANGULARJS if BR2_PACKAGE_ANGULARJS -config BR2_ANGULARJS_MODULES - bool "angularjs modules" - help - Select which modules to install. If disabled, all modules - will be installed. +# All the modules default to 'y' to keep backward-compatibility +# Keep this list in sync and in the same (alphabetical) order as # the +# one in angularjs.mk. However, always keep 'angular' first in the list. -if BR2_ANGULARJS_MODULES +config BR2_ANGULARJS_MODULE_ANGULAR + bool + default y config BR2_ANGULARJS_MODULE_ANIMATE bool "animate" + default y help The ngAnimate module provides support for CSS-based animations (keyframes and transitions) as well as JavaScript-based animations
@@ -26,6 +27,7 @@ config BR2_ANGULARJS_MODULE_ANIMATE config BR2_ANGULARJS_MODULE_ARIA bool "aria" + default y help The ngAria module provides support for common ARIA attributes that convey state or semantic information about the application for users
@@ -33,47 +35,52 @@ config BR2_ANGULARJS_MODULE_ARIA config BR2_ANGULARJS_MODULE_COOKIES bool "cookies" + default y help The ngCookies module provides a convenient wrapper for reading and writing browser cookies. -config BR2_ANGULARJS_MODULE_MESSAGE_FORMAT - bool "message-format" - help - The ngMessageFormat module is used recognize MessageFormat extensions - in interpolation expressions. - config BR2_ANGULARJS_MODULE_MESSAGES bool "messages" + default y help The ngMessages module provides enhanced support for displaying messages within templates (typically within forms or when rendering message objects that return key/value data). +config BR2_ANGULARJS_MODULE_MESSAGE_FORMAT + bool "message-format" + default y + help + The ngMessageFormat module is used recognize MessageFormat extensions + in interpolation expressions. + config BR2_ANGULARJS_MODULE_RESOURCE bool "resource" + default y help The ngResource module provides interaction support with RESTful services via the $resource service. config BR2_ANGULARJS_MODULE_ROUTE bool "route" + default y help The ngRoute module provides routing and deeplinking services and directives for angular apps. config BR2_ANGULARJS_MODULE_SANITIZE bool "sanitize" + default y help The ngSanitize module provides functionality to sanitize HTML. config BR2_ANGULARJS_MODULE_TOUCH bool "touch" + default y help The ngTouch module provides touch events and other helpers for touch-enabled devices. The implementation is based on jQuery Mobile touch event handling (jquerymobile.com). endif - -endif
package/angularjs/angularjs.mk +15 -9
@@ -17,18 +17,24 @@ define ANGULARJS_EXTRACT_CMDS rmdir $(@D)/angular-$(ANGULARJS_VERSION) endef -ANGULARJS_FILES = angular +# This list mirrors the list of available modules from Config.in. +# Keep this list in sync and in the same (alphabetical) order as the +# one in Config.in. However, always keep 'angular' first in the list. +ANGULARJS_MODULES = \ + angular \ + animate \ + aria \ + cookies \ + messages \ + message-format \ + resource \ + route \ + sanitize \ + touch -ANGULARJS_MODULES = animate aria cookies message-format messages resource \ - route sanitize touch - -ifeq ($(BR2_ANGULARJS_MODULES),y) -ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),\ +ANGULARJS_FILES = $(foreach mod,$(ANGULARJS_MODULES),\ $(if $(BR2_ANGULARJS_MODULE_$(call UPPERCASE,$(mod))),\ angular-$(mod))) -else -ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),angular-$(mod)) -endif define ANGULARJS_INSTALL_TARGET_CMDS $(foreach f,$(ANGULARJS_FILES),\
Signature · 1 line
1.9.1
RFC PATCH 10/84 package/angularjs: simplify modules selection
Quoted 21 lines · Yann E. MORIN
Remove the superfluous config option, and make all modules default to 'y', which provides exactly the same functionality.
simplify (and slightly beautofy) the handling of modules in the .mk:
since the modules' symbols are always meaningful now, we can get rid of the else-clause, and always build the list of modules using theKconfigoptions.Re-order the list alphabetically (message <-> message-format).
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/angularjs/Config.in | 35 +++++++++++++++++++++-------------- package/angularjs/angularjs.mk | 24 +++++++++++++++--------- 2 files changed, 36 insertions(+), 23 deletions(-)package/angularjs/Config.in +0
-0
package/angularjs/Config.in menuconfig BR2_PACKAGE_ANGULARJS · line 10
Quoted 9 lines
package/angularjs/Config.in +1
-5@@ -7,16 +7,17 @@ menuconfig BR2_PACKAGE_ANGULARJS if BR2_PACKAGE_ANGULARJS -config BR2_ANGULARJS_MODULES - bool "angularjs modules" - help - Select which modules to install. If disabled, all modules - will be installed. +# All the modules default to 'y' to keep backward-compatibility
I don't think this comment is needed, because it will no longer be true in the
future.
package/angularjs/Config.in menuconfig BR2_PACKAGE_ANGULARJS · line 12
Quoted 2 lines
package/angularjs/Config.in +2
-0+# Keep this list in sync and in the same (alphabetical) order as # the +# one in angularjs.mk. However, always keep 'angular' first in the list.
I don't think this comment is needed either. We don't have something like that
at the top of package/Config.in for instance. And it's not that things stop to work if it's not alphabetical.
package/angularjs/Config.in menuconfig BR2_PACKAGE_ANGULARJS · line 16
Quoted 5 lines
package/angularjs/Config.in +3
-1-if BR2_ANGULARJS_MODULES +config BR2_ANGULARJS_MODULE_ANGULAR + bool + default y
I don't like this part either, see below.
[snip]
package/angularjs/angularjs.mk define ANGULARJS_EXTRACT_CMDS · line 20
Quoted 9 lines
package/angularjs/angularjs.mk +0
-1@@ -17,18 +17,24 @@ define ANGULARJS_EXTRACT_CMDS rmdir $(@D)/angular-$(ANGULARJS_VERSION) endef -ANGULARJS_FILES = angular
I prefered it like this, with the angular bit always there and the rest added
by Kconfig options. Simpler than adding a dummy Kconfig option for angular itself.
Regards,
Arnout
Quoted 30 lines
package/angularjs/angularjs.mk +15
-8+# This list mirrors the list of available modules from Config.in. +# Keep this list in sync and in the same (alphabetical) order as the +# one in Config.in. However, always keep 'angular' first in the list. +ANGULARJS_MODULES = \ + angular \ + animate \ + aria \ + cookies \ + messages \ + message-format \ + resource \ + route \ + sanitize \ + touch -ANGULARJS_MODULES = animate aria cookies message-format messages resource \ - route sanitize touch - -ifeq ($(BR2_ANGULARJS_MODULES),y) -ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),\ +ANGULARJS_FILES = $(foreach mod,$(ANGULARJS_MODULES),\ $(if $(BR2_ANGULARJS_MODULE_$(call UPPERCASE,$(mod))),\ angular-$(mod))) -else -ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),angular-$(mod)) -endif define ANGULARJS_INSTALL_TARGET_CMDS $(foreach f,$(ANGULARJS_FILES),\
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 10/84 package/angularjs: simplify modules selection
Arnout, All,
On 2015-12-31 00:27 +0100, Arnout Vandecappelle spake thusly:
Quoted 60 lines · Yann E. MORIN
Quoted 21 lines
Remove the superfluous config option, and make all modules default to 'y', which provides exactly the same functionality.
simplify (and slightly beautofy) the handling of modules in the .mk:
since the modules' symbols are always meaningful now, we can get rid of the else-clause, and always build the list of modules using theKconfigoptions.Re-order the list alphabetically (message <-> message-format).
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/angularjs/Config.in | 35 +++++++++++++++++++++-------------- package/angularjs/angularjs.mk | 24 +++++++++++++++--------- 2 files changed, 36 insertions(+), 23 deletions(-)package/angularjs/Config.in +0
-0package/angularjs/Config.in menuconfig BR2_PACKAGE_ANGULARJS · line 10
Quoted 9 lines
package/angularjs/Config.in +1
-5@@ -7,16 +7,17 @@ menuconfig BR2_PACKAGE_ANGULARJS if BR2_PACKAGE_ANGULARJS -config BR2_ANGULARJS_MODULES - bool "angularjs modules" - help - Select which modules to install. If disabled, all modules - will be installed. +# All the modules default to 'y' to keep backward-compatibilityI don't think this comment is needed, because it will no longer be true in the
future.package/angularjs/Config.in menuconfig BR2_PACKAGE_ANGULARJS · line 12
Quoted 2 lines
package/angularjs/Config.in +2
-0+# Keep this list in sync and in the same (alphabetical) order as # the +# one in angularjs.mk. However, always keep 'angular' first in the list.I don't think this comment is needed either. We don't have something like that
at the top of package/Config.in for instance. And it's not that things stop to work if it's not alphabetical.package/angularjs/Config.in menuconfig BR2_PACKAGE_ANGULARJS · line 16
Quoted 5 lines
package/angularjs/Config.in +3
-1-if BR2_ANGULARJS_MODULES +config BR2_ANGULARJS_MODULE_ANGULAR + bool + default yI don't like this part either, see below.
[snip]
Quoted 8 lines
package/angularjs/angularjs.mk +0
-0@@ -17,18 +17,24 @@ define ANGULARJS_EXTRACT_CMDS rmdir $(@D)/angular-$(ANGULARJS_VERSION) endef
Quoted 4 lines
package/angularjs/angularjs.mk define ANGULARJS_EXTRACT_CMDS · line 20
Quoted 1 line
package/angularjs/angularjs.mk +0
-1-ANGULARJS_FILES = angularI prefered it like this, with the angular bit always there and the rest added
byKconfigoptions. Simpler than adding a dummyKconfigoption for angular itself.
I was not 100% sure either, so I'll revert it.
Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 11/84 package/collectd: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINSince there were multiple sub-menus, keep their prompts as a comment, to properly separate all famillies of plugins.
--- package/collectd/Config.in | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-)
package/collectd/Config.in +6 -15
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_COLLECTD +menuconfig BR2_PACKAGE_COLLECTD bool "collectd" # Uses fork() depends on BR2_USE_MMU
@@ -13,7 +13,7 @@ config BR2_PACKAGE_COLLECTD if BR2_PACKAGE_COLLECTD -menu "match plugins" +comment "match plugins" config BR2_PACKAGE_COLLECTD_EMPTY_COUNTER bool "empty counter"
@@ -39,9 +39,8 @@ config BR2_PACKAGE_COLLECTD_VALUE bool "value" help Select values by their data sources' values. -endmenu -menu "misc plugins" +comment "misc plugins" config BR2_PACKAGE_COLLECTD_AGGREGATION bool "aggregation"
@@ -86,9 +85,7 @@ config BR2_PACKAGE_COLLECTD_THRESHOLD Checks values against configured thresholds and creates notifications if values are out of bounds. -endmenu - -menu "read plugins" +comment "read plugins" comment "Select at least one for collectd to be useful"
@@ -455,9 +452,7 @@ config BR2_PACKAGE_COLLECTD_ZOOKEEPER help Read data from Zookeeper's MNTR command. -endmenu - -menu "target plugins" +comment "target plugins" config BR2_PACKAGE_COLLECTD_NOTIFICATION bool "notification"
@@ -479,9 +474,7 @@ config BR2_PACKAGE_COLLECTD_SET help Set (overwrite) entire parts of an identifier. -endmenu - -menu "write plugins" +comment "write plugins" comment "Select at least one for collectd to be useful"
@@ -550,8 +543,6 @@ config BR2_PACKAGE_COLLECTD_WRITETSDB Sends data OpenTSDB, a scalable no master, no shared state time series database. -endmenu - endif comment "collectd needs a toolchain w/ threads, dynamic library"
Signature · 1 line
1.9.1
RFC PATCH 12/84 package/gd: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN--- package/gd/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/gd/Config.in +2 -4
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_GD +menuconfig BR2_PACKAGE_GD bool "gd" help GD is a graphics library. It allows your code to quickly
@@ -12,7 +12,7 @@ config BR2_PACKAGE_GD if BR2_PACKAGE_GD -menu "gd tools" +comment "gd tools" config BR2_PACKAGE_GD_ANNOTATE bool "annotate"
@@ -57,6 +57,4 @@ config BR2_PACKAGE_GD_WEBPNG bool "webpng" select BR2_PACKAGE_LIBPNG -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 12/84 package/gd: use 'menuconfig' instad of 'config'+'menu'
In the subject: instad -> instead.
Regards,
Arnout
Quoted 32 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gd/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)package/gd/Config.in +2
-4@@ -1,4 +1,4 @@ -config BR2_PACKAGE_GD +menuconfig BR2_PACKAGE_GD bool "gd" help GD is a graphics library. It allows your code to quickly@@ -12,7 +12,7 @@ config BR2_PACKAGE_GD if BR2_PACKAGE_GD -menu "gd tools" +comment "gd tools" config BR2_PACKAGE_GD_ANNOTATE bool "annotate"@@ -57,6 +57,4 @@ config BR2_PACKAGE_GD_WEBPNG bool "webpng" select BR2_PACKAGE_LIBPNG -endmenu - endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 13/84 package/gpsd: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINSince there were multiple sub-menus, their prompts are turned into comments.
Some option were missing a prompt, so add one. Add separating lines around options.
--- package/gpsd/Config.in | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
package/gpsd/Config.in +13 -12
@@ -2,7 +2,7 @@ comment "gpsd needs a toolchain w/ threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS -config BR2_PACKAGE_GPSD +menuconfig BR2_PACKAGE_GPSD bool "gpsd" # Uses fork() depends on BR2_USE_MMU
@@ -25,7 +25,7 @@ config BR2_PACKAGE_GPSD_DEVICES string "Where to look for GPSes" default "/dev/ttyS1" -menu "Features" +comment "Features" config BR2_PACKAGE_GPSD_CLIENT_DEBUG bool "client debugging support"
@@ -50,36 +50,41 @@ config BR2_PACKAGE_GPSD_PPS config BR2_PACKAGE_GPSD_USER bool "GPSD privilege revocation user" + config BR2_PACKAGE_GPSD_USER_VALUE - string "" + string "user to run as" default "nobody" depends on BR2_PACKAGE_GPSD_USER config BR2_PACKAGE_GPSD_GROUP bool "GPSD privilege revocation group" + config BR2_PACKAGE_GPSD_GROUP_VALUE - string "" + string "group to run as" default "nobody" depends on BR2_PACKAGE_GPSD_GROUP config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED bool "compile with fixed serial port speed" + config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED_VALUE - string "" + int "serial port speed" default "9600" depends on BR2_PACKAGE_GPSD_FIXED_PORT_SPEED config BR2_PACKAGE_GPSD_MAX_CLIENT bool "compile with limited maximum clients" + config BR2_PACKAGE_GPSD_MAX_CLIENT_VALUE - string "compile with limited maximum clients" + int "maximum number of clients" default "10" depends on BR2_PACKAGE_GPSD_MAX_CLIENT config BR2_PACKAGE_GPSD_MAX_DEV bool "compile with maximum allowed devices" + config BR2_PACKAGE_GPSD_MAX_DEV_VALUE - string "compile with maximum allowed devices" + int "maximum allowed devices" default "2" depends on BR2_PACKAGE_GPSD_MAX_DEV
@@ -94,9 +99,7 @@ config BR2_PACKAGE_GPSD_CONTROLSEND config BR2_PACKAGE_GPSD_SQUELCH bool "squelch gpsd_report and gpsd_hexdump to save cpu" -endmenu - -menu "Protocols" +comment "Protocols" config BR2_PACKAGE_GPSD_AIVDM bool "Aivdm"
@@ -231,6 +234,4 @@ config BR2_PACKAGE_GPSD_UBX help uBlox UBX binary support -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 14/84 package/jquery: include external plugins from jquery's Config.in
In reply to Yann E. MORIN... and make it a menuconfig instead of a 'config'+'menu'.
--- package/Config.in | 12 ------------ package/jquery/Config.in | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 13 deletions(-)
package/Config.in +0 -12
@@ -951,18 +951,6 @@ menu "Javascript" source "package/explorercanvas/Config.in" source "package/flot/Config.in" source "package/jquery/Config.in" -if BR2_PACKAGE_JQUERY -menu "External jQuery plugins" - source "package/jquery-datetimepicker/Config.in" - source "package/jquery-keyboard/Config.in" - source "package/jquery-mobile/Config.in" - source "package/jquery-sidebar/Config.in" - source "package/jquery-sparkline/Config.in" - source "package/jquery-ui/Config.in" - source "package/jquery-ui-themes/Config.in" - source "package/jquery-validation/Config.in" -endmenu -endif source "package/jsmin/Config.in" source "package/json-javascript/Config.in" endmenu
package/jquery/Config.in +16 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_JQUERY +menuconfig BR2_PACKAGE_JQUERY bool "jQuery" help jQuery is a fast and concise JavaScript Library that
@@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY animating, and Ajax interactions for rapid web development. http://jquery.com + +if BR2_PACKAGE_JQUERY + +comment "External jQuery plugins" + +source "package/jquery-datetimepicker/Config.in" +source "package/jquery-keyboard/Config.in" +source "package/jquery-mobile/Config.in" +source "package/jquery-sidebar/Config.in" +source "package/jquery-sparkline/Config.in" +source "package/jquery-ui/Config.in" +source "package/jquery-ui-themes/Config.in" +source "package/jquery-validation/Config.in" + +endif
Signature · 1 line
1.9.1
RFC PATCH 14/84 package/jquery: include external plugins from jquery's Config.in
Quoted 1 line · Yann E. MORIN
... and make it a menuconfig instead of a 'config'+'menu'.
I don't agree with this change, because these are really separate packages, not
suboptions of the jquery package. Similar for python, where it is even more obvious because as indicated by the symlink hack for python3.
Regards,
Arnout
Quoted 60 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 12 ------------ package/jquery/Config.in | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 13 deletions(-)package/Config.in +0
-12@@ -951,18 +951,6 @@ menu "Javascript" source "package/explorercanvas/Config.in" source "package/flot/Config.in" source "package/jquery/Config.in" -if BR2_PACKAGE_JQUERY -menu "External jQuery plugins" - source "package/jquery-datetimepicker/Config.in" - source "package/jquery-keyboard/Config.in" - source "package/jquery-mobile/Config.in" - source "package/jquery-sidebar/Config.in" - source "package/jquery-sparkline/Config.in" - source "package/jquery-ui/Config.in" - source "package/jquery-ui-themes/Config.in" - source "package/jquery-validation/Config.in" -endmenu -endif source "package/jsmin/Config.in" source "package/json-javascript/Config.in" endmenupackage/jquery/Config.in +16
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_JQUERY +menuconfig BR2_PACKAGE_JQUERY bool "jQuery" help jQuery is a fast and concise JavaScript Library that@@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY animating, and Ajax interactions for rapid web development. http://jquery.com + +if BR2_PACKAGE_JQUERY + +comment "External jQuery plugins" + +source "package/jquery-datetimepicker/Config.in" +source "package/jquery-keyboard/Config.in" +source "package/jquery-mobile/Config.in" +source "package/jquery-sidebar/Config.in" +source "package/jquery-sparkline/Config.in" +source "package/jquery-ui/Config.in" +source "package/jquery-ui-themes/Config.in" +source "package/jquery-validation/Config.in" + +endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 14/84 package/jquery: include external plugins from jquery's Config.in
Arnout, All,
On 2015-12-31 00:45 +0100, Arnout Vandecappelle spake thusly:
Quoted 6 lines · Yann E. MORIN
Quoted 1 line
... and make it a menuconfig instead of a 'config'+'menu'.
I don't agree with this change, because these are really separate packages, not
suboptions of the jquery package. Similar for python, where it is even more obvious because as indicated by the symlink hack for python3.
That they are separate packages is irrelevant, to the _user_.
It makes sense for us, packagers and BR developpers, but it should not have an impact on the user experience.
What is relevant to the user, is that they are jquery stuff, and they don't even make sense without jquery. Whether they are "built-in" or "external" modules should not be of his concerns.
And, as you argue, if they should be treated like "nornmal" packages, why do we have them in a submenu?
Note also that what I propose here is what we already do for a few other packages:
- Kodi
- freescale-imx
- matchbox
- nvidia-tegra23
- to a lesser extent, Qt5
Please have a look *as a user* to the menuconfig before and after this series, and tell me you really prefer the previous layout. Yes, this new one means we need to source packages "modules" (perl, php, python...) from the package's own Config.in rather than from the /main/ Config.in, but I do believe it is better in three ways:
- those "modules" are only meaningful in combination with the corresponding package [0],
- it removes the (relative) complexity of the dependency knowledge out of the main package/Config.in [1] and move it to the best location where it can be handled, i.e. the package itself,
- the resulting menuconfig (UI) layout is more appealing to an end user (IMHO).
[0] this implies the python/python3 symlink trick, yes.
[1] I would also like to get rid of the if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS from package/Config.in and move it to the packages themselves. Not that we are not even consistent with that one either, like for systemd or tovid.
So I will maintain this patch in the series, if at least to get more feedback from others.
Thanks for your opinion! ;-)
(This reply is valid for all you other NAKs about this topic. ;-) )
Regards,
Yann E. MORIN.
Quoted 72 lines
Regards,
ArnoutQuoted 60 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 12 ------------ package/jquery/Config.in | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 13 deletions(-)package/Config.in +0
-12@@ -951,18 +951,6 @@ menu "Javascript" source "package/explorercanvas/Config.in" source "package/flot/Config.in" source "package/jquery/Config.in" -if BR2_PACKAGE_JQUERY -menu "External jQuery plugins" - source "package/jquery-datetimepicker/Config.in" - source "package/jquery-keyboard/Config.in" - source "package/jquery-mobile/Config.in" - source "package/jquery-sidebar/Config.in" - source "package/jquery-sparkline/Config.in" - source "package/jquery-ui/Config.in" - source "package/jquery-ui-themes/Config.in" - source "package/jquery-validation/Config.in" -endmenu -endif source "package/jsmin/Config.in" source "package/json-javascript/Config.in" endmenupackage/jquery/Config.in +16
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_JQUERY +menuconfig BR2_PACKAGE_JQUERY bool "jQuery" help jQuery is a fast and concise JavaScript Library that@@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY animating, and Ajax interactions for rapid web development. http://jquery.com + +if BR2_PACKAGE_JQUERY + +comment "External jQuery plugins" + +source "package/jquery-datetimepicker/Config.in" +source "package/jquery-keyboard/Config.in" +source "package/jquery-mobile/Config.in" +source "package/jquery-sidebar/Config.in" +source "package/jquery-sparkline/Config.in" +source "package/jquery-ui/Config.in" +source "package/jquery-ui-themes/Config.in" +source "package/jquery-validation/Config.in" + +endifSignature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 14/84 package/jquery: include external plugins from jquery's Config.in
Quoted 15 lines · Yann E. MORIN
Arnout, All,
On 2015-12-31 00:45 +0100, Arnout Vandecappelle spake thusly:
Quoted 6 lines · Yann E. MORIN
Quoted 1 line
... and make it a menuconfig instead of a 'config'+'menu'.
I don't agree with this change, because these are really separate packages, not
suboptions of the jquery package. Similar for python, where it is even more obvious because as indicated by the symlink hack for python3.That they are separate packages is irrelevant, to the _user_.
It makes sense for us, packagers and BR developpers, but it should not have an impact on the user experience.
Quoted 6 lines
What is relevant to the user, is that they are jquery stuff, and they don't even make sense without jquery. Whether they are "built-in" or "external" modules should not be of his concerns.
And, as you argue, if they should be treated like "nornmal" packages, why do we have them in a submenu?
I've taken another look at the two versions, and basically what I had objection
with is the submenu itself (the existing one). However, removing the menu would be even worse (overcrowding the menu above it.
So I'll go back through the NACK'ed patch and re-review them.
Regards,
Arnout
Quoted 41 lines
Note also that what I propose here is what we already do for a few other packages:
- Kodi
- freescale-imx
- matchbox
- nvidia-tegra23
- to a lesser extent, Qt5Please have a look *as a user* to the menuconfig before and after this series, and tell me you really prefer the previous layout. Yes, this new one means we need to source packages "modules" (perl, php, python...) from the package's own Config.in rather than from the /main/ Config.in, but I do believe it is better in three ways:
- those "modules" are only meaningful in combination with the corresponding package [0],
- it removes the (relative) compjquerylexity of the dependency knowledge out of the main package/Config.in [1] and move it to the best location where it can be handled, i.e. the package itself,
- the resulting menuconfig (UI) layout is more appealing to an end user (IMHO).
[0] this implies the python/python3 symlink trick, yes.
[1] I would also like to get rid of the ifBR2_PACKAGE_BUSYBOX_SHOW_OTHERSfrom package/Config.in and move it to the packages themselves. Not that we are not even consistent with that one either, like for systemd or tovid.So I will maintain this patch in the series, if at least to get more feedback from others.
Thanks for your opinion! ;-)
(This reply is valid for all you other NAKs about this topic. ;-) )
Regards,
Yann E. MORIN.
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 14/84 package/jquery: include external plugins from jquery's Config.in
In reply to Yann E. MORINQuoted 3 lines · Yann E. MORIN
... and make it a menuconfig instead of a 'config'+'menu'.
Signed-off-by "Yann E. MORIN" <[email protected]>
Regards,
Arnout
Quoted 58 lines
--- package/Config.in | 12 ------------ package/jquery/Config.in | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 13 deletions(-)package/Config.in +0
-12@@ -951,18 +951,6 @@ menu "Javascript" source "package/explorercanvas/Config.in" source "package/flot/Config.in" source "package/jquery/Config.in" -if BR2_PACKAGE_JQUERY -menu "External jQuery plugins" - source "package/jquery-datetimepicker/Config.in" - source "package/jquery-keyboard/Config.in" - source "package/jquery-mobile/Config.in" - source "package/jquery-sidebar/Config.in" - source "package/jquery-sparkline/Config.in" - source "package/jquery-ui/Config.in" - source "package/jquery-ui-themes/Config.in" - source "package/jquery-validation/Config.in" -endmenu -endif source "package/jsmin/Config.in" source "package/json-javascript/Config.in" endmenupackage/jquery/Config.in +16
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_JQUERY +menuconfig BR2_PACKAGE_JQUERY bool "jQuery" help jQuery is a fast and concise JavaScript Library that@@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY animating, and Ajax interactions for rapid web development. http://jquery.com + +if BR2_PACKAGE_JQUERY + +comment "External jQuery plugins" + +source "package/jquery-datetimepicker/Config.in" +source "package/jquery-keyboard/Config.in" +source "package/jquery-mobile/Config.in" +source "package/jquery-sidebar/Config.in" +source "package/jquery-sparkline/Config.in" +source "package/jquery-ui/Config.in" +source "package/jquery-ui-themes/Config.in" +source "package/jquery-validation/Config.in" + +endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 15/84 package/libdrm: move tests programs to the bottom
In reply to Yann E. MORINTests programs are not that important; at least, they're probably less important than the drivers selection.
Move it down to after the drivers selection.
--- package/libdrm/Config.in | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
package/libdrm/Config.in +5 -5
@@ -9,11 +9,6 @@ config BR2_PACKAGE_LIBDRM if BR2_PACKAGE_LIBDRM -config BR2_PACKAGE_LIBDRM_INSTALL_TESTS - bool "Install test programs" - help - This option allows to install the libdrm test programs. - menu "DRM Drivers" config BR2_PACKAGE_LIBDRM_INTEL
@@ -71,6 +66,11 @@ config BR2_PACKAGE_LIBDRM_TEGRA endmenu +config BR2_PACKAGE_LIBDRM_INSTALL_TESTS + bool "Install test programs" + help + This option allows to install the libdrm test programs. + endif comment "libdrm needs a toolchain w/ threads"
Signature · 1 line
1.9.1
RFC PATCH 16/84 package/libdrm: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORINTransform the menu prompt into a comment.
--- package/libdrm/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/libdrm/Config.in +2 -4
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_LIBDRM +menuconfig BR2_PACKAGE_LIBDRM bool "libdrm" select BR2_PACKAGE_LIBPTHREAD_STUBS depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
@@ -9,7 +9,7 @@ config BR2_PACKAGE_LIBDRM if BR2_PACKAGE_LIBDRM -menu "DRM Drivers" +comment "DRM Drivers" config BR2_PACKAGE_LIBDRM_INTEL bool "intel"
@@ -64,8 +64,6 @@ config BR2_PACKAGE_LIBDRM_TEGRA help Install NVIDIA Tegra driver using an experimental API. -endmenu - config BR2_PACKAGE_LIBDRM_INSTALL_TESTS bool "Install test programs" help
Signature · 1 line
1.9.1
RFC PATCH 16/84 package/libdrm: use 'menuconfig' instad of 'config'+'menu'
Quoted 18 lines · Yann E. MORIN
Transform the menu prompt into a comment.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/libdrm/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)package/libdrm/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_LIBDRM +menuconfig BR2_PACKAGE_LIBDRM bool "libdrm" select BR2_PACKAGE_LIBPTHREAD_STUBS depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
package/libdrm/Config.in config BR2_PACKAGE_LIBDRM · line 12
Quoted 5 lines
package/libdrm/Config.in +1
-1@@ -9,7 +9,7 @@ config BR2_PACKAGE_LIBDRM if BR2_PACKAGE_LIBDRM -menu "DRM Drivers" +comment "DRM Drivers"
Comment can be dropped.
Regards,
Arnout
Quoted 13 lines
package/libdrm/Config.in +0
-2config BR2_PACKAGE_LIBDRM_INTEL bool "intel"@@ -64,8 +64,6 @@ config BR2_PACKAGE_LIBDRM_TEGRA help Install NVIDIA Tegra driver using an experimental API. -endmenu - config BR2_PACKAGE_LIBDRM_INSTALL_TESTS bool "Install test programs" help
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 17/84 package/mono: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINThis is a bit overkill, as there is only one sub-item. However, this commit is not about judging whether it makes sense or not to have a sub-menu, but to cleanup the 'config'+'menu' situation.
--- package/Config.in | 5 ----- package/mono/Config.in | 8 +++++++- 2 files changed, 7 insertions(+), 6 deletions(-)
package/Config.in +0 -5
@@ -539,11 +539,6 @@ endif source "package/micropython-lib/Config.in" source "package/moarvm/Config.in" source "package/mono/Config.in" -if BR2_PACKAGE_MONO -menu "Mono libraries/modules" - source "package/mono-gtksharp3/Config.in" -endmenu -endif source "package/nodejs/Config.in" source "package/perl/Config.in" if BR2_PACKAGE_PERL
package/mono/Config.in +7 -1
@@ -3,7 +3,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) -config BR2_PACKAGE_MONO +menuconfig BR2_PACKAGE_MONO bool "mono" depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -14,6 +14,12 @@ config BR2_PACKAGE_MONO http://download.mono-project.com/sources/mono/ +if BR2_PACKAGE_MONO + +source "package/mono-gtksharp3/Config.in" + +endif + comment "mono needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
Signature · 1 line
1.9.1
RFC PATCH 17/84 package/mono: use 'menuconfig' instead of 'config'+'menu'
Quoted 3 lines · Yann E. MORIN
This is a bit overkill, as there is only one sub-item. However, this commit is not about judging whether it makes sense or not to have a sub-menu, but to cleanup the 'config'+'menu' situation.
NACK, like jquery.
Regards,
Arnout
Quoted 50 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 5 ----- package/mono/Config.in | 8 +++++++- 2 files changed, 7 insertions(+), 6 deletions(-)package/Config.in +0
-5@@ -539,11 +539,6 @@ endif source "package/micropython-lib/Config.in" source "package/moarvm/Config.in" source "package/mono/Config.in" -if BR2_PACKAGE_MONO -menu "Mono libraries/modules" - source "package/mono-gtksharp3/Config.in" -endmenu -endif source "package/nodejs/Config.in" source "package/perl/Config.in" if BR2_PACKAGE_PERLpackage/mono/Config.in +7
-1@@ -3,7 +3,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) -config BR2_PACKAGE_MONO +menuconfig BR2_PACKAGE_MONO bool "mono" depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_THREADS@@ -14,6 +14,12 @@ config BR2_PACKAGE_MONO http://download.mono-project.com/sources/mono/ +if BR2_PACKAGE_MONO + +source "package/mono-gtksharp3/Config.in" + +endif + comment "mono needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 17/84 package/mono: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINQuoted 3 lines · Yann E. MORIN
This is a bit overkill, as there is only one sub-item. However, this commit is not about judging whether it makes sense or not to have a sub-menu, but to cleanup the 'config'+'menu' situation.
Definitely overkill, since it is even empty when gtk3 isn't selected...
But as you say, that's not what this patch is about, so
Regards,
Arnout
Quoted 50 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 5 ----- package/mono/Config.in | 8 +++++++- 2 files changed, 7 insertions(+), 6 deletions(-)package/Config.in +0
-5@@ -539,11 +539,6 @@ endif source "package/micropython-lib/Config.in" source "package/moarvm/Config.in" source "package/mono/Config.in" -if BR2_PACKAGE_MONO -menu "Mono libraries/modules" - source "package/mono-gtksharp3/Config.in" -endmenu -endif source "package/nodejs/Config.in" source "package/perl/Config.in" if BR2_PACKAGE_PERLpackage/mono/Config.in +7
-1@@ -3,7 +3,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) -config BR2_PACKAGE_MONO +menuconfig BR2_PACKAGE_MONO bool "mono" depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_THREADS@@ -14,6 +14,12 @@ config BR2_PACKAGE_MONO http://download.mono-project.com/sources/mono/ +if BR2_PACKAGE_MONO + +source "package/mono-gtksharp3/Config.in" + +endif + comment "mono needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 18/84 package/ncftp: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN--- package/ncftp/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/ncftp/Config.in +2 -4
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_NCFTP +menuconfig BR2_PACKAGE_NCFTP bool "ncftp" # fork() depends on BR2_USE_MMU
@@ -10,7 +10,7 @@ config BR2_PACKAGE_NCFTP if BR2_PACKAGE_NCFTP -menu "ncFTP tools selection" +comment "tools selection" config BR2_PACKAGE_NCFTP_GET bool "NcFTPGet - command-line utility program"
@@ -32,6 +32,4 @@ config BR2_PACKAGE_NCFTP_BOOKMARKS bool "NcFTPBookmarks - ncurses based Bookmark Editor" select BR2_PACKAGE_NCURSES -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 18/84 package/ncftp: use 'menuconfig' instad of 'config'+'menu'
Quoted 16 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/ncftp/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)package/ncftp/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_NCFTP +menuconfig BR2_PACKAGE_NCFTP bool "ncftp" # fork() depends on BR2_USE_MMU
package/ncftp/Config.in config BR2_PACKAGE_NCFTP · line 13
Quoted 5 lines
package/ncftp/Config.in +1
-1@@ -10,7 +10,7 @@ config BR2_PACKAGE_NCFTP if BR2_PACKAGE_NCFTP -menu "ncFTP tools selection" +comment "tools selection"
Comment not needed.
Regards,
Arnout
Quoted 11 lines
package/ncftp/Config.in +0
-2config BR2_PACKAGE_NCFTP_GET bool "NcFTPGet - command-line utility program"@@ -32,6 +32,4 @@ config BR2_PACKAGE_NCFTP_BOOKMARKS bool "NcFTPBookmarks - ncurses based Bookmark Editor" select BR2_PACKAGE_NCURSES -endmenu - endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 19/84 package/nfs-utils: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORIN--- package/nfs-utils/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
package/nfs-utils/Config.in +1 -5
@@ -2,7 +2,7 @@ comment "nfs-utils needs a toolchain w/ threads" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_NFS_UTILS +menuconfig BR2_PACKAGE_NFS_UTILS bool "nfs-utils" depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
@@ -15,8 +15,6 @@ config BR2_PACKAGE_NFS_UTILS if BR2_PACKAGE_NFS_UTILS -menu "NFS utilities selection" - config BR2_PACKAGE_NFS_UTILS_RPCDEBUG bool "rpcdebug" help
@@ -32,6 +30,4 @@ config BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD help NFS remote quota server -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 20/84 package/nodejs: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORIN--- package/nodejs/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/nodejs/Config.in +2 -4
@@ -5,7 +5,7 @@ comment "nodejs needs a toolchain w/ C++, dynamic library, threads" depends on !BR2_ARM_CPU_ARMV4 depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_NODEJS +menuconfig BR2_PACKAGE_NODEJS bool "nodejs" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPP
@@ -62,7 +62,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING default "0.10.41" if BR2_PACKAGE_NODEJS_0_10_X default "5.3.0" if BR2_PACKAGE_NODEJS_5_X -menu "Module Selection" +comment "Module Selection" config BR2_PACKAGE_NODEJS_NPM bool "NPM for the target"
@@ -118,6 +118,4 @@ config BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL_DEPS 'libcurl' here, to ensure that buildroot builds the libcurl package, and does so before building your node modules. -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 20/84 package/nodejs: use 'menuconfig' instead of 'config'+'menu'
Quoted 19 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/nodejs/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)package/nodejs/Config.in +1
-1@@ -5,7 +5,7 @@ comment "nodejs needs a toolchain w/ C++, dynamic library, threads" depends on !BR2_ARM_CPU_ARMV4 depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_NODEJS +menuconfig BR2_PACKAGE_NODEJS bool "nodejs" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPP
package/nodejs/Config.in config BR2_PACKAGE_NODEJS_VERSION_STRING · line 65
Quoted 5 lines
package/nodejs/Config.in +1
-1@@ -62,7 +62,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING default "0.10.41" if BR2_PACKAGE_NODEJS_0_10_X default "5.3.0" if BR2_PACKAGE_NODEJS_5_X -menu "Module Selection" +comment "Module Selection"
Comment not needed.
Regards,
Arnout
Quoted 11 lines
package/nodejs/Config.in +0
-2config BR2_PACKAGE_NODEJS_NPM bool "NPM for the target"@@ -118,6 +118,4 @@ config BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL_DEPS 'libcurl' here, to ensure that buildroot builds the libcurl package, and does so before building your node modules. -endmenu - endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 21/84 package/ola: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINSince there were multiple sub-menus, their prompts are turned into comments.
--- package/ola/Config.in | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
package/ola/Config.in +4 -10
@@ -3,7 +3,7 @@ comment "ola needs a toolchain w/ C++, threads, wchar, dynamic library" || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 -config BR2_PACKAGE_OLA +menuconfig BR2_PACKAGE_OLA bool "ola (open lighting architecture)" select BR2_PACKAGE_PROTOBUF select BR2_PACKAGE_UTIL_LINUX_LIBUUID
@@ -24,7 +24,7 @@ config BR2_PACKAGE_OLA if BR2_PACKAGE_OLA -menu "bindings and interface" +comment "bindings and interface" config BR2_PACKAGE_OLA_WEB bool "http interface"
@@ -44,9 +44,7 @@ config BR2_PACKAGE_OLA_SLP help Build OLA with slp tools. -endmenu - -menu "tests and examples" +comment "tests and examples" config BR2_PACKAGE_OLA_EXAMPLES bool "examples"
@@ -60,9 +58,7 @@ config BR2_PACKAGE_OLA_RDM_TESTS help Build OLA RDM tests. -endmenu - -menu "plugin selections" +comment "plugin selections" config BR2_PACKAGE_OLA_PLUGIN_E131 bool "acn E131"
@@ -132,6 +128,4 @@ config BR2_PACKAGE_OLA_PLUGIN_USBPRO help Build UsbPro plugin for OLA. -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 22/84 package/perl: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINMove the perl library/modules inclusion to the perl's Config.in.
--- package/Config.in | 47 ----------------------------------------------- package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 47 insertions(+), 48 deletions(-)
package/Config.in +0 -47
@@ -541,53 +541,6 @@ endif source "package/mono/Config.in" source "package/nodejs/Config.in" source "package/perl/Config.in" -if BR2_PACKAGE_PERL -menu "Perl libraries/modules" - source "package/perl-crypt-openssl-random/Config.in" - source "package/perl-crypt-openssl-rsa/Config.in" - source "package/perl-datetime-tiny/Config.in" - source "package/perl-db-file/Config.in" - source "package/perl-digest-hmac/Config.in" - source "package/perl-digest-sha1/Config.in" - source "package/perl-encode-detect/Config.in" - source "package/perl-encode-locale/Config.in" - source "package/perl-file-listing/Config.in" - source "package/perl-file-util/Config.in" - source "package/perl-gd/Config.in" - source "package/perl-gdgraph/Config.in" - source "package/perl-gdtextutil/Config.in" - source "package/perl-html-parser/Config.in" - source "package/perl-html-tagset/Config.in" - source "package/perl-http-cookies/Config.in" - source "package/perl-http-daemon/Config.in" - source "package/perl-http-date/Config.in" - source "package/perl-http-message/Config.in" - source "package/perl-http-negotiate/Config.in" - source "package/perl-io-html/Config.in" - source "package/perl-io-socket-ssl/Config.in" - source "package/perl-json-tiny/Config.in" - source "package/perl-libwww-perl/Config.in" - source "package/perl-lwp-mediatypes/Config.in" - source "package/perl-mail-dkim/Config.in" - source "package/perl-mailtools/Config.in" - source "package/perl-mime-base64/Config.in" - source "package/perl-mojolicious/Config.in" - source "package/perl-net-dns/Config.in" - source "package/perl-net-http/Config.in" - source "package/perl-net-ssleay/Config.in" - source "package/perl-netaddr-ip/Config.in" - source "package/perl-path-tiny/Config.in" - source "package/perl-time-hires/Config.in" - source "package/perl-timedate/Config.in" - source "package/perl-try-tiny/Config.in" - source "package/perl-uri/Config.in" - source "package/perl-www-robotrules/Config.in" - source "package/perl-xml-libxml/Config.in" - source "package/perl-xml-namespacesupport/Config.in" - source "package/perl-xml-sax/Config.in" - source "package/perl-xml-sax-base/Config.in" -endmenu -endif source "package/php/Config.in" if BR2_PACKAGE_PHP if !BR2_STATIC_LIBS
package/perl/Config.in +47 -1
55 lines not on this page · raw message
Signature · 1 line
1.9.1
RFC PATCH 22/84 package/perl: use 'menuconfig' instead of 'config'+'menu'
Quoted 1 line · Yann E. MORIN
Move the perl library/modules inclusion to the perl's Config.in.
NACK, like jquery.
Regards,
Arnout
Quoted 127 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 47 ----------------------------------------------- package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 47 insertions(+), 48 deletions(-)package/Config.in +0
-47@@ -541,53 +541,6 @@ endif source "package/mono/Config.in" source "package/nodejs/Config.in" source "package/perl/Config.in" -if BR2_PACKAGE_PERL -menu "Perl libraries/modules" - source "package/perl-crypt-openssl-random/Config.in" - source "package/perl-crypt-openssl-rsa/Config.in" - source "package/perl-datetime-tiny/Config.in" - source "package/perl-db-file/Config.in" - source "package/perl-digest-hmac/Config.in" - source "package/perl-digest-sha1/Config.in" - source "package/perl-encode-detect/Config.in" - source "package/perl-encode-locale/Config.in" - source "package/perl-file-listing/Config.in" - source "package/perl-file-util/Config.in" - source "package/perl-gd/Config.in" - source "package/perl-gdgraph/Config.in" - source "package/perl-gdtextutil/Config.in" - source "package/perl-html-parser/Config.in" - source "package/perl-html-tagset/Config.in" - source "package/perl-http-cookies/Config.in" - source "package/perl-http-daemon/Config.in" - source "package/perl-http-date/Config.in" - source "package/perl-http-message/Config.in" - source "package/perl-http-negotiate/Config.in" - source "package/perl-io-html/Config.in" - source "package/perl-io-socket-ssl/Config.in" - source "package/perl-json-tiny/Config.in" - source "package/perl-libwww-perl/Config.in" - source "package/perl-lwp-mediatypes/Config.in" - source "package/perl-mail-dkim/Config.in" - source "package/perl-mailtools/Config.in" - source "package/perl-mime-base64/Config.in" - source "package/perl-mojolicious/Config.in" - source "package/perl-net-dns/Config.in" - source "package/perl-net-http/Config.in" - source "package/perl-net-ssleay/Config.in" - source "package/perl-netaddr-ip/Config.in" - source "package/perl-path-tiny/Config.in" - source "package/perl-time-hires/Config.in" - source "package/perl-timedate/Config.in" - source "package/perl-try-tiny/Config.in" - source "package/perl-uri/Config.in" - source "package/perl-www-robotrules/Config.in" - source "package/perl-xml-libxml/Config.in" - source "package/perl-xml-namespacesupport/Config.in" - source "package/perl-xml-sax/Config.in" - source "package/perl-xml-sax-base/Config.in" -endmenu -endif source "package/php/Config.in" if BR2_PACKAGE_PHP if !BR2_STATIC_LIBSpackage/perl/Config.in +47
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_PERL +menuconfig BR2_PACKAGE_PERL bool "perl" depends on BR2_USE_MMU # fork() help@@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES Leave empty for all modules (as far as the external libraries are available). +comment "Perl libraries/modules" + +source "package/perl-crypt-openssl-random/Config.in" +source "package/perl-crypt-openssl-rsa/Config.in" +source "package/perl-datetime-tiny/Config.in" +source "package/perl-db-file/Config.in" +source "package/perl-digest-hmac/Config.in" +source "package/perl-digest-sha1/Config.in" +source "package/perl-encode-detect/Config.in" +source "package/perl-encode-locale/Config.in" +source "package/perl-file-listing/Config.in" +source "package/perl-file-util/Config.in" +source "package/perl-gd/Config.in" +source "package/perl-gdgraph/Config.in" +source "package/perl-gdtextutil/Config.in" +source "package/perl-html-parser/Config.in" +source "package/perl-html-tagset/Config.in" +source "package/perl-http-cookies/Config.in" +source "package/perl-http-daemon/Config.in" +source "package/perl-http-date/Config.in" +source "package/perl-http-message/Config.in" +source "package/perl-http-negotiate/Config.in" +source "package/perl-io-html/Config.in" +source "package/perl-io-socket-ssl/Config.in" +source "package/perl-json-tiny/Config.in" +source "package/perl-libwww-perl/Config.in" +source "package/perl-lwp-mediatypes/Config.in" +source "package/perl-mail-dkim/Config.in" +source "package/perl-mailtools/Config.in" +source "package/perl-mime-base64/Config.in" +source "package/perl-mojolicious/Config.in" +source "package/perl-net-dns/Config.in" +source "package/perl-net-http/Config.in" +source "package/perl-net-ssleay/Config.in" +source "package/perl-netaddr-ip/Config.in" +source "package/perl-path-tiny/Config.in" +source "package/perl-time-hires/Config.in" +source "package/perl-timedate/Config.in" +source "package/perl-try-tiny/Config.in" +source "package/perl-uri/Config.in" +source "package/perl-www-robotrules/Config.in" +source "package/perl-xml-libxml/Config.in" +source "package/perl-xml-namespacesupport/Config.in" +source "package/perl-xml-sax/Config.in" +source "package/perl-xml-sax-base/Config.in" + endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 22/84 package/perl: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORINQuoted 8 lines · Yann E. MORIN
Move the perl library/modules inclusion to the perl's Config.in.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 47 ----------------------------------------------- package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 47 insertions(+), 48 deletions(-)
[snip]
Quoted 11 lines
package/perl/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_PERL +menuconfig BR2_PACKAGE_PERL bool "perl" depends on BR2_USE_MMU # fork() help
package/perl/Config.in config BR2_PACKAGE_PERL_MODULES · line 27
Quoted 4 lines
package/perl/Config.in +1
-0@@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES Leave empty for all modules (as far as the external libraries are available). +comment "Perl libraries/modules"
This comment looks pretty weird in xconfig, but OK in menuconfig and something
definitely needs to be put in there, so OK.
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 22/84 package/perl: use 'menuconfig' instead of 'config'+'menu'
Arnout, All,
On 2016-01-02 01:33 +0100, Arnout Vandecappelle spake thusly:
Quoted 24 lines · Yann E. MORIN
Quoted 8 lines
Move the perl library/modules inclusion to the perl's Config.in.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 47 ----------------------------------------------- package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 47 insertions(+), 48 deletions(-)[snip]
Quoted 14 lines
package/perl/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_PERL +menuconfig BR2_PACKAGE_PERL bool "perl" depends on BR2_USE_MMU # fork() help@@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES Leave empty for all modules (as far as the external libraries are available).
Quoted 4 lines
package/perl/Config.in config BR2_PACKAGE_PERL_MODULES · line 27
Quoted 1 line
package/perl/Config.in +1
-0+comment "Perl libraries/modules"This comment looks pretty weird in xconfig, but OK in menuconfig and something
definitely needs to be put in there, so OK.
Hmm.. I never use xconfig, because I think xconfig already looks weird to me. ;-) But indeed it looks weird. But the "custom modules selection" looks weird as well (well, I guess all 'string' and 'int' look weird in xconfig, and gconfig is only so slightly better).
What I'm a bit worried for xconfig and gconfig, is that, if we remove the "Perl libraries/modules" comment, the "custom modules selection" just above would seem to indicate that the custom modules are listed below, which it is not since it is a string option, not a comment.
But Eh... Graybeard speaking... ;-)
Quoted 1 line
Thanks! I appreciate you re-reviewed the series! :-)
Regards,
Yann E. MORIN.
Quoted 14 lines
Regards,
Arnout[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 23/84 package/php: move list of extensions after interface selection
In reply to Yann E. MORIN--- package/php/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/php/Config.in +2 -2
@@ -9,8 +9,6 @@ config BR2_PACKAGE_PHP if BR2_PACKAGE_PHP -source "package/php/Config.ext" - config BR2_PACKAGE_PHP_CLI bool
@@ -66,4 +64,6 @@ config BR2_PACKAGE_PHP_SAPI_CLI_FPM endchoice +source "package/php/Config.ext" + endif
Signature · 1 line
1.9.1
RFC PATCH 24/84 package/php: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORINMove the external extensions selection into the bundled extensions' Config.in.
Make the menu prompt a comment, reword it so that it is more in line with the following comments.
--- package/Config.in | 16 ---------------- package/php/Config.ext | 20 ++++++++++++++++++-- package/php/Config.in | 2 +- 3 files changed, 19 insertions(+), 19 deletions(-)
package/Config.in +0 -16
@@ -542,22 +542,6 @@ endif source "package/nodejs/Config.in" source "package/perl/Config.in" source "package/php/Config.in" -if BR2_PACKAGE_PHP -if !BR2_STATIC_LIBS -menu "External php extensions" - source "package/php-geoip/Config.in" - source "package/php-gnupg/Config.in" - source "package/php-imagick/Config.in" - source "package/php-memcached/Config.in" - source "package/php-ssh2/Config.in" - source "package/php-yaml/Config.in" - source "package/php-zmq/Config.in" -endmenu -endif -if BR2_STATIC_LIBS -comment "External PHP extensions need a toolchain w/ dynamic library" -endif -endif source "package/python/Config.in" source "package/python3/Config.in" if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
package/php/Config.ext +18 -2
@@ -1,4 +1,4 @@ -menu "Extensions" +comment "Generic extensions" config BR2_PACKAGE_PHP_EXT_CALENDAR bool "Calendar"
@@ -400,4 +400,20 @@ config BR2_PACKAGE_PHP_EXT_XSL help XSL transformation support -endmenu +if !BR2_STATIC_LIBS + +comment "External extensions" + +source "package/php-geoip/Config.in" +source "package/php-gnupg/Config.in" +source "package/php-imagick/Config.in" +source "package/php-memcached/Config.in" +source "package/php-ssh2/Config.in" +source "package/php-yaml/Config.in" +source "package/php-zmq/Config.in" + +endif # !STATIC_LIBS + +if BR2_STATIC_LIBs +comment "External PHP extensions need a toolchain w/ dynamic library" +endif
package/php/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_PHP +menuconfig BR2_PACKAGE_PHP bool "php" help PHP is a widely-used general-purpose scripting
Signature · 1 line
1.9.1
RFC PATCH 24/84 package/php: use 'menuconfig' instad of 'config'+'menu'
Quoted 5 lines · Yann E. MORIN
Move the external extensions selection into the bundled extensions' Config.in.
Make the menu prompt a comment, reword it so that it is more in line with the following comments.
Yet another NACK, and here you can see another reason why it's not good IMHO:
the internal extension have prompts like "XSL", while the external extensions are called "php-yaml", which looks inconsistent.
Regards,
Arnout
Quoted 78 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 16 ---------------- package/php/Config.ext | 20 ++++++++++++++++++-- package/php/Config.in | 2 +- 3 files changed, 19 insertions(+), 19 deletions(-)package/Config.in +0
-16@@ -542,22 +542,6 @@ endif source "package/nodejs/Config.in" source "package/perl/Config.in" source "package/php/Config.in" -if BR2_PACKAGE_PHP -if !BR2_STATIC_LIBS -menu "External php extensions" - source "package/php-geoip/Config.in" - source "package/php-gnupg/Config.in" - source "package/php-imagick/Config.in" - source "package/php-memcached/Config.in" - source "package/php-ssh2/Config.in" - source "package/php-yaml/Config.in" - source "package/php-zmq/Config.in" -endmenu -endif -if BR2_STATIC_LIBS -comment "External PHP extensions need a toolchain w/ dynamic library" -endif -endif source "package/python/Config.in" source "package/python3/Config.in" if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3package/php/Config.ext +18
-2@@ -1,4 +1,4 @@ -menu "Extensions" +comment "Generic extensions" config BR2_PACKAGE_PHP_EXT_CALENDAR bool "Calendar"@@ -400,4 +400,20 @@ config BR2_PACKAGE_PHP_EXT_XSL help XSL transformation support -endmenu +if !BR2_STATIC_LIBS + +comment "External extensions" + +source "package/php-geoip/Config.in" +source "package/php-gnupg/Config.in" +source "package/php-imagick/Config.in" +source "package/php-memcached/Config.in" +source "package/php-ssh2/Config.in" +source "package/php-yaml/Config.in" +source "package/php-zmq/Config.in" + +endif # !STATIC_LIBS + +if BR2_STATIC_LIBs +comment "External PHP extensions need a toolchain w/ dynamic library" +endifpackage/php/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_PHP +menuconfig BR2_PACKAGE_PHP bool "php" help PHP is a widely-used general-purpose scripting
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 24/84 package/php: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORINQuoted 7 lines · Yann E. MORIN
Move the external extensions selection into the bundled extensions' Config.in.
Make the menu prompt a comment, reword it so that it is more in line with the following comments.
Signed-off-by "Yann E. MORIN" <[email protected]>
I still think it looks really weird that you have XSL and then php-geoip.
Perhaps we should consider letting go of the rule that the prompt should be the exact package name, and instead make it plain geoip. But that's more churn...
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 24/84 package/php: use 'menuconfig' instad of 'config'+'menu'
Arnout, All,
On 2016-01-02 01:48 +0100, Arnout Vandecappelle spake thusly:
Quoted 12 lines · Yann E. MORIN
Quoted 7 lines
Move the external extensions selection into the bundled extensions' Config.in.
Make the menu prompt a comment, reword it so that it is more in line with the following comments.
Signed-off-by "Yann E. MORIN" <[email protected]>I still think it looks really weird that you have XSL and then php-geoip.
Well, it looks a bit different, indeed. But I think it is a good thing, since they are external extensions and thus stand out in the list.
Quoted 2 lines
Perhaps we should consider letting go of the rule that the prompt should be the exact package name, and instead make it plain geoip. But that's more churn...
By 'the exact package name', did you mean 'the way we named it in Buildroot' or 'the way upstream named it' ? Speaking about 'package' can quickly get really confusing! ;-)
However, I think we should really use the way upstream names it, whatever we call it in Buildroot.
But s you said, it's more churn, and we can work on it later. If needed.
Thanks!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 25/84 package/python: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN--- package/python/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/python/Config.in +2 -4
@@ -2,7 +2,7 @@ comment "python needs a toolchain w/ wchar, threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS -config BR2_PACKAGE_PYTHON +menuconfig BR2_PACKAGE_PYTHON bool "python" depends on BR2_USE_WCHAR # uses fork()
@@ -34,7 +34,7 @@ config BR2_PACKAGE_PYTHON_PY_PYC endchoice -menu "core python modules" +comment "core python modules" comment "The following modules are unusual or require extra libraries"
@@ -127,6 +127,4 @@ config BR2_PACKAGE_PYTHON_HASHLIB help hashlib support in Python -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 26/84 package/python3: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN--- package/python3/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/python3/Config.in +2 -4
@@ -2,7 +2,7 @@ comment "python3 needs a toolchain w/ wchar, threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS -config BR2_PACKAGE_PYTHON3 +menuconfig BR2_PACKAGE_PYTHON3 bool "python3" depends on !BR2_PACKAGE_PYTHON depends on BR2_USE_WCHAR
@@ -35,7 +35,7 @@ config BR2_PACKAGE_PYTHON3_PY_PYC endchoice -menu "core python3 modules" +comment "core python3 modules" comment "The following modules are unusual or require extra libraries"
@@ -104,6 +104,4 @@ config BR2_PACKAGE_PYTHON3_ZLIB help zlib support in Python3 -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 27/84 package/python{, 3}: move inclusion of external python modules
In reply to Yann E. MORINIntroduce a Config.ext for external python modules, that both python and python include from there respective sub-menus.
--- package/Config.in | 96 ---------------------------------------------- package/python/Config.ext | 96 ++++++++++++++++++++++++++++++++++++++++++++++ package/python/Config.in | 2 + package/python3/Config.ext | 1 + package/python3/Config.in | 2 + 5 files changed, 101 insertions(+), 96 deletions(-) create mode 100644 package/python/Config.ext create mode 120000 package/python3/Config.ext
package/Config.in +0 -96
@@ -544,102 +544,6 @@ endif source "package/php/Config.in" source "package/python/Config.in" source "package/python3/Config.in" -if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 -menu "External python modules" - source "package/python-alsaaudio/Config.in" - source "package/python-backports-abc/Config.in" - source "package/python-bottle/Config.in" - source "package/python-can/Config.in" - source "package/python-certifi/Config.in" - source "package/python-cffi/Config.in" - source "package/python-cheetah/Config.in" - source "package/python-cherrypy/Config.in" - source "package/python-coherence/Config.in" - source "package/python-configobj/Config.in" - source "package/python-configshell-fb/Config.in" - source "package/python-crc16/Config.in" - source "package/python-daemon/Config.in" - source "package/python-dialog/Config.in" - source "package/python-django/Config.in" - source "package/python-docopt/Config.in" - source "package/python-dpkt/Config.in" - source "package/python-enum/Config.in" - source "package/python-enum34/Config.in" - source "package/python-flask/Config.in" - source "package/python-flup/Config.in" - source "package/python-gobject/Config.in" - source "package/python-httplib2/Config.in" - source "package/python-id3/Config.in" - source "package/python-idna/Config.in" - source "package/python-ipaddr/Config.in" - source "package/python-ipaddress/Config.in" - source "package/python-ipy/Config.in" - source "package/python-ipython/Config.in" - source "package/python-itsdangerous/Config.in" - source "package/python-jinja2/Config.in" - source "package/python-json-schema-validator/Config.in" - source "package/python-keyring/Config.in" - source "package/python-libconfig/Config.in" - source "package/python-lxml/Config.in" - source "package/python-mad/Config.in" - source "package/python-mako/Config.in" - source "package/python-markdown/Config.in" - source "package/python-markupsafe/Config.in" - source "package/python-meld3/Config.in" - source "package/python-msgpack/Config.in" - source "package/python-netifaces/Config.in" - source "package/python-networkmanager/Config.in" - source "package/python-nfc/Config.in" - source "package/python-numpy/Config.in" - source "package/python-pam/Config.in" - source "package/python-posix-ipc/Config.in" - source "package/python-protobuf/Config.in" - source "package/python-psutil/Config.in" - source "package/python-pyasn/Config.in" - source "package/python-pycli/Config.in" - source "package/python-pycrypto/Config.in" - source "package/python-pydal/Config.in" - source "package/python-pyftpdlib/Config.in" - source "package/python-pygame/Config.in" - source "package/python-pyinotify/Config.in" - source "package/python-pyparsing/Config.in" - source "package/python-pypcap/Config.in" - source "package/python-pyqt/Config.in" - source "package/python-pyratemp/Config.in" - source "package/python-pyro/Config.in" - source "package/python-pyroute2/Config.in" - source "package/python-pysendfile/Config.in" - source "package/python-pysmb/Config.in" - source "package/python-pysnmp/Config.in" - source "package/python-pysnmp-apps/Config.in" - source "package/python-pysnmp-mibs/Config.in" - source "package/python-pyudev/Config.in" - source "package/python-pyusb/Config.in" - source "package/python-pyxb/Config.in" - source "package/python-pyxml/Config.in" - source "package/python-pyyaml/Config.in" - source "package/python-pyzmq/Config.in" - source "package/python-requests/Config.in" - source "package/python-rtslib-fb/Config.in" - source "package/python-serial/Config.in" - source "package/python-setuptools/Config.in" - source "package/python-simplejson/Config.in" - source "package/python-singledispatch/Config.in" - source "package/python-sip/Config.in" - source "package/python-six/Config.in" - source "package/python-spidev/Config.in" - source "package/python-thrift/Config.in" - source "package/python-tornado/Config.in" - source "package/python-twisted/Config.in" - source "package/python-urwid/Config.in" - source "package/python-versiontools/Config.in" - source "package/python-web2py/Config.in" - source "package/python-webpy/Config.in" - source "package/python-werkzeug/Config.in" - source "package/python-ws4py/Config.in" - source "package/python-zope-interface/Config.in" -endmenu -endif source "package/ruby/Config.in" source "package/tcl/Config.in" if BR2_PACKAGE_TCL
package/python/Config.ext new file +96 -0
96 lines not on this page · raw message
package/python/Config.in +2 -0
@@ -127,4 +127,6 @@ config BR2_PACKAGE_PYTHON_HASHLIB help hashlib support in Python +source "package/python/Config.ext" + endif
package/python3/Config.ext new file +1 -0
@@ -0,0 +1 @@ +../python/Config.ext
package/python3/Config.in +2 -0
@@ -104,4 +104,6 @@ config BR2_PACKAGE_PYTHON3_ZLIB help zlib support in Python3 +source "package/python3/Config.ext" + endif
Signature · 1 line
1.9.1
RFC PATCH 27/84 package/python{, 3}: move inclusion of external python modules
Quoted 2 lines · Yann E. MORIN
Introduce a Config.ext for external python modules, that both python and python include from there respective sub-menus.
As mentioned before, NACK no this one.
Regards,
Arnout
Quoted 252 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 96 ---------------------------------------------- package/python/Config.ext | 96 ++++++++++++++++++++++++++++++++++++++++++++++ package/python/Config.in | 2 + package/python3/Config.ext | 1 + package/python3/Config.in | 2 + 5 files changed, 101 insertions(+), 96 deletions(-) create mode 100644 package/python/Config.ext create mode 120000 package/python3/Config.extpackage/Config.in +0
-96@@ -544,102 +544,6 @@ endif source "package/php/Config.in" source "package/python/Config.in" source "package/python3/Config.in" -if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 -menu "External python modules" - source "package/python-alsaaudio/Config.in" - source "package/python-backports-abc/Config.in" - source "package/python-bottle/Config.in" - source "package/python-can/Config.in" - source "package/python-certifi/Config.in" - source "package/python-cffi/Config.in" - source "package/python-cheetah/Config.in" - source "package/python-cherrypy/Config.in" - source "package/python-coherence/Config.in" - source "package/python-configobj/Config.in" - source "package/python-configshell-fb/Config.in" - source "package/python-crc16/Config.in" - source "package/python-daemon/Config.in" - source "package/python-dialog/Config.in" - source "package/python-django/Config.in" - source "package/python-docopt/Config.in" - source "package/python-dpkt/Config.in" - source "package/python-enum/Config.in" - source "package/python-enum34/Config.in" - source "package/python-flask/Config.in" - source "package/python-flup/Config.in" - source "package/python-gobject/Config.in" - source "package/python-httplib2/Config.in" - source "package/python-id3/Config.in" - source "package/python-idna/Config.in" - source "package/python-ipaddr/Config.in" - source "package/python-ipaddress/Config.in" - source "package/python-ipy/Config.in" - source "package/python-ipython/Config.in" - source "package/python-itsdangerous/Config.in" - source "package/python-jinja2/Config.in" - source "package/python-json-schema-validator/Config.in" - source "package/python-keyring/Config.in" - source "package/python-libconfig/Config.in" - source "package/python-lxml/Config.in" - source "package/python-mad/Config.in" - source "package/python-mako/Config.in" - source "package/python-markdown/Config.in" - source "package/python-markupsafe/Config.in" - source "package/python-meld3/Config.in" - source "package/python-msgpack/Config.in" - source "package/python-netifaces/Config.in" - source "package/python-networkmanager/Config.in" - source "package/python-nfc/Config.in" - source "package/python-numpy/Config.in" - source "package/python-pam/Config.in" - source "package/python-posix-ipc/Config.in" - source "package/python-protobuf/Config.in" - source "package/python-psutil/Config.in" - source "package/python-pyasn/Config.in" - source "package/python-pycli/Config.in" - source "package/python-pycrypto/Config.in" - source "package/python-pydal/Config.in" - source "package/python-pyftpdlib/Config.in" - source "package/python-pygame/Config.in" - source "package/python-pyinotify/Config.in" - source "package/python-pyparsing/Config.in" - source "package/python-pypcap/Config.in" - source "package/python-pyqt/Config.in" - source "package/python-pyratemp/Config.in" - source "package/python-pyro/Config.in" - source "package/python-pyroute2/Config.in" - source "package/python-pysendfile/Config.in" - source "package/python-pysmb/Config.in" - source "package/python-pysnmp/Config.in" - source "package/python-pysnmp-apps/Config.in" - source "package/python-pysnmp-mibs/Config.in" - source "package/python-pyudev/Config.in" - source "package/python-pyusb/Config.in" - source "package/python-pyxb/Config.in" - source "package/python-pyxml/Config.in" - source "package/python-pyyaml/Config.in" - source "package/python-pyzmq/Config.in" - source "package/python-requests/Config.in" - source "package/python-rtslib-fb/Config.in" - source "package/python-serial/Config.in" - source "package/python-setuptools/Config.in" - source "package/python-simplejson/Config.in" - source "package/python-singledispatch/Config.in" - source "package/python-sip/Config.in" - source "package/python-six/Config.in" - source "package/python-spidev/Config.in" - source "package/python-thrift/Config.in" - source "package/python-tornado/Config.in" - source "package/python-twisted/Config.in" - source "package/python-urwid/Config.in" - source "package/python-versiontools/Config.in" - source "package/python-web2py/Config.in" - source "package/python-webpy/Config.in" - source "package/python-werkzeug/Config.in" - source "package/python-ws4py/Config.in" - source "package/python-zope-interface/Config.in" -endmenu -endif source "package/ruby/Config.in" source "package/tcl/Config.in" if BR2_PACKAGE_TCLpackage/python/Config.ext new file +96
-0@@ -0,0 +1,96 @@ +# This file is included both from python and python3 + +comment "External python modules" + +source "package/python-alsaaudio/Config.in" +source "package/python-backports-abc/Config.in" +source "package/python-bottle/Config.in" +source "package/python-can/Config.in" +source "package/python-certifi/Config.in" +source "package/python-cffi/Config.in" +source "package/python-cheetah/Config.in" +source "package/python-cherrypy/Config.in" +source "package/python-coherence/Config.in" +source "package/python-configobj/Config.in" +source "package/python-configshell-fb/Config.in" +source "package/python-crc16/Config.in" +source "package/python-daemon/Config.in" +source "package/python-dialog/Config.in" +source "package/python-django/Config.in" +source "package/python-docopt/Config.in" +source "package/python-dpkt/Config.in" +source "package/python-enum/Config.in" +source "package/python-enum34/Config.in" +source "package/python-flask/Config.in" +source "package/python-flup/Config.in" +source "package/python-gobject/Config.in" +source "package/python-httplib2/Config.in" +source "package/python-id3/Config.in" +source "package/python-idna/Config.in" +source "package/python-ipaddr/Config.in" +source "package/python-ipaddress/Config.in" +source "package/python-ipy/Config.in" +source "package/python-ipython/Config.in" +source "package/python-itsdangerous/Config.in" +source "package/python-jinja2/Config.in" +source "package/python-json-schema-validator/Config.in" +source "package/python-keyring/Config.in" +source "package/python-libconfig/Config.in" +source "package/python-lxml/Config.in" +source "package/python-mad/Config.in" +source "package/python-mako/Config.in" +source "package/python-markdown/Config.in" +source "package/python-markupsafe/Config.in" +source "package/python-meld3/Config.in" +source "package/python-msgpack/Config.in" +source "package/python-netifaces/Config.in" +source "package/python-networkmanager/Config.in" +source "package/python-nfc/Config.in" +source "package/python-numpy/Config.in" +source "package/python-pam/Config.in" +source "package/python-posix-ipc/Config.in" +source "package/python-protobuf/Config.in" +source "package/python-psutil/Config.in" +source "package/python-pyasn/Config.in" +source "package/python-pycli/Config.in" +source "package/python-pycrypto/Config.in" +source "package/python-pydal/Config.in" +source "package/python-pyftpdlib/Config.in" +source "package/python-pygame/Config.in" +source "package/python-pyinotify/Config.in" +source "package/python-pyparsing/Config.in" +source "package/python-pypcap/Config.in" +source "package/python-pyqt/Config.in" +source "package/python-pyratemp/Config.in" +source "package/python-pyro/Config.in" +source "package/python-pyroute2/Config.in" +source "package/python-pysendfile/Config.in" +source "package/python-pysmb/Config.in" +source "package/python-pysnmp/Config.in" +source "package/python-pysnmp-apps/Config.in" +source "package/python-pysnmp-mibs/Config.in" +source "package/python-pyudev/Config.in" +source "package/python-pyusb/Config.in" +source "package/python-pyxb/Config.in" +source "package/python-pyxml/Config.in" +source "package/python-pyyaml/Config.in" +source "package/python-pyzmq/Config.in" +source "package/python-requests/Config.in" +source "package/python-rtslib-fb/Config.in" +source "package/python-serial/Config.in" +source "package/python-setuptools/Config.in" +source "package/python-simplejson/Config.in" +source "package/python-singledispatch/Config.in" +source "package/python-sip/Config.in" +source "package/python-six/Config.in" +source "package/python-spidev/Config.in" +source "package/python-thrift/Config.in" +source "package/python-tornado/Config.in" +source "package/python-twisted/Config.in" +source "package/python-urwid/Config.in" +source "package/python-versiontools/Config.in" +source "package/python-web2py/Config.in" +source "package/python-webpy/Config.in" +source "package/python-werkzeug/Config.in" +source "package/python-ws4py/Config.in" +source "package/python-zope-interface/Config.in"package/python/Config.in +2
-0@@ -127,4 +127,6 @@ config BR2_PACKAGE_PYTHON_HASHLIB help hashlib support in Python +source "package/python/Config.ext" + endifpackage/python3/Config.ext new file +1
-0@@ -0,0 +1 @@ +../python/Config.extpackage/python3/Config.in +2
-0@@ -104,4 +104,6 @@ config BR2_PACKAGE_PYTHON3_ZLIB help zlib support in Python3 +source "package/python3/Config.ext" + endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 27/84 package/python{, 3}: move inclusion of external python modules
In reply to Yann E. MORINQuoted 4 lines · Yann E. MORIN
Introduce a Config.ext for external python modules, that both python and python include from there respective sub-menus.
Signed-off-by "Yann E. MORIN" <[email protected]>
Regards,
Arnout
Quoted 9 lines
--- package/Config.in | 96 ---------------------------------------------- package/python/Config.ext | 96 ++++++++++++++++++++++++++++++++++++++++++++++ package/python/Config.in | 2 + package/python3/Config.ext | 1 + package/python3/Config.in | 2 + 5 files changed, 101 insertions(+), 96 deletions(-) create mode 100644 package/python/Config.ext create mode 120000 package/python3/Config.ext
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 28/84 package/sdl_image: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORIN--- package/sdl_image/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
package/sdl_image/Config.in +1 -5
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_SDL_IMAGE +menuconfig BR2_PACKAGE_SDL_IMAGE bool "SDL_image" depends on BR2_PACKAGE_SDL help
@@ -10,8 +10,6 @@ config BR2_PACKAGE_SDL_IMAGE if BR2_PACKAGE_SDL_IMAGE -menu "SDL_image file format support" - config BR2_PACKAGE_SDL_IMAGE_BMP bool "enable BMP file format support" default y
@@ -56,6 +54,4 @@ config BR2_PACKAGE_SDL_IMAGE_XPM config BR2_PACKAGE_SDL_IMAGE_XV bool "enable XV file format support" -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 29/84 package/tcl: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORINMove inclusion of Tcl libraries/modules to Tcl's Config.in so that they appear in Tcl's sub-menu.
--- package/Config.in | 6 ------ package/tcl/Config.in | 7 ++++++- 2 files changed, 6 insertions(+), 7 deletions(-)
package/Config.in +0 -6
@@ -546,12 +546,6 @@ endif source "package/python3/Config.in" source "package/ruby/Config.in" source "package/tcl/Config.in" -if BR2_PACKAGE_TCL -menu "Tcl libraries/modules" - source "package/expect/Config.in" - source "package/tcllib/Config.in" -endmenu -endif endmenu menu "Libraries"
package/tcl/Config.in +6 -1
@@ -2,7 +2,7 @@ comment "tcl needs a toolchain w/ threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS -config BR2_PACKAGE_TCL +menuconfig BR2_PACKAGE_TCL bool "tcl" # fork() depends on BR2_USE_MMU
@@ -36,4 +36,9 @@ config BR2_PACKAGE_TCL_SHLIB_ONLY Saves ~14kb. +comment "Tcl libraries/modules" + +source "package/expect/Config.in" +source "package/tcllib/Config.in" + endif
Signature · 1 line
1.9.1
RFC PATCH 29/84 package/tcl: use 'menuconfig' instad of 'config'+'menu'
Quoted 2 lines · Yann E. MORIN
Move inclusion of Tcl libraries/modules to Tcl's Config.in so that they appear in Tcl's sub-menu.
One more NACK :-)
Regards,
Arnout
Quoted 48 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/Config.in | 6 ------ package/tcl/Config.in | 7 ++++++- 2 files changed, 6 insertions(+), 7 deletions(-)package/Config.in +0
-6@@ -546,12 +546,6 @@ endif source "package/python3/Config.in" source "package/ruby/Config.in" source "package/tcl/Config.in" -if BR2_PACKAGE_TCL -menu "Tcl libraries/modules" - source "package/expect/Config.in" - source "package/tcllib/Config.in" -endmenu -endif endmenu menu "Libraries"package/tcl/Config.in +6
-1@@ -2,7 +2,7 @@ comment "tcl needs a toolchain w/ threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS -config BR2_PACKAGE_TCL +menuconfig BR2_PACKAGE_TCL bool "tcl" # fork() depends on BR2_USE_MMU@@ -36,4 +36,9 @@ config BR2_PACKAGE_TCL_SHLIB_ONLY Saves ~14kb. +comment "Tcl libraries/modules" + +source "package/expect/Config.in" +source "package/tcllib/Config.in" + endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 29/84 package/tcl: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORINQuoted 4 lines · Yann E. MORIN
Move inclusion of Tcl libraries/modules to Tcl's Config.in so that they appear in Tcl's sub-menu.
Signed-off-by "Yann E. MORIN" <[email protected]>
Regards,
Arnout
Quoted 4 lines
--- package/Config.in | 6 ------ package/tcl/Config.in | 7 ++++++- 2 files changed, 6 insertions(+), 7 deletions(-)
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 30/84 package/tiff: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORIN--- package/tiff/Config.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
package/tiff/Config.in +1 -3
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_TIFF +menuconfig BR2_PACKAGE_TIFF bool "tiff" help Library for handling TIFF (Tag Image File Format) images.
@@ -6,7 +6,6 @@ config BR2_PACKAGE_TIFF http://www.libtiff.org/ if BR2_PACKAGE_TIFF -menu "tiff Options" config BR2_PACKAGE_TIFF_CCITT bool "CCITT Group 3 & 4 support"
@@ -58,7 +57,6 @@ config BR2_PACKAGE_TIFF_OLD_JPEG config BR2_PACKAGE_TIFF_JBIG bool "JBIG compression" default y -endmenu config BR2_PACKAGE_TIFF_UTILITIES bool "tiff utilities"
Signature · 1 line
1.9.1
RFC PATCH 31/84 package/udpcast: use 'menuconfig' instad of 'config'+'menu'
In reply to Yann E. MORINThis is a bit overkill, as there is only two sub-items. However, this commit is not about judging whether it makes sense or not to have a sub-menu, but to cleanup the 'config'+'menu' situation.
--- package/udpcast/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
package/udpcast/Config.in +1 -5
@@ -2,7 +2,7 @@ comment "udpcast needs a toolchain w/ threads" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_UDPCAST +menuconfig BR2_PACKAGE_UDPCAST bool "udpcast" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork()
@@ -14,8 +14,6 @@ config BR2_PACKAGE_UDPCAST if BR2_PACKAGE_UDPCAST -menu "udpcast tools selection" - config BR2_PACKAGE_UDPCAST_SENDER bool "sender" help
@@ -26,6 +24,4 @@ config BR2_PACKAGE_UDPCAST_RECEIVER help The udpcast receiver. -endmenu - endif
Signature · 1 line
1.9.1
RFC PATCH 31/84 package/udpcast: use 'menuconfig' instad of 'config'+'menu'
Quoted 3 lines · Yann E. MORIN
This is a bit overkill, as there is only two sub-items. However, this commit is not about judging whether it makes sense or not to have a sub-menu, but to cleanup the 'config'+'menu' situation.
Well, you could just as well take this opportunity to replace it with indented
config options. You wrote yourself in your cover text that 5 entries would be the arbitrary cut-off.
That said, it's acceptable to have this as an inbetween step as well.
Regards,
Arnout
Quoted 36 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/udpcast/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)package/udpcast/Config.in +1
-5@@ -2,7 +2,7 @@ comment "udpcast needs a toolchain w/ threads" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_UDPCAST +menuconfig BR2_PACKAGE_UDPCAST bool "udpcast" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork()@@ -14,8 +14,6 @@ config BR2_PACKAGE_UDPCAST if BR2_PACKAGE_UDPCAST -menu "udpcast tools selection" - config BR2_PACKAGE_UDPCAST_SENDER bool "sender" help@@ -26,6 +24,4 @@ config BR2_PACKAGE_UDPCAST_RECEIVER help The udpcast receiver. -endmenu - endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 31/84 package/udpcast: use 'menuconfig' instad of 'config'+'menu'
Arnout, All,
On 2015-12-31 01:08 +0100, Arnout Vandecappelle spake thusly:
Quoted 10 lines · Yann E. MORIN
Quoted 3 lines
This is a bit overkill, as there is only two sub-items. However, this commit is not about judging whether it makes sense or not to have a sub-menu, but to cleanup the 'config'+'menu' situation.
Well, you could just as well take this opportunity to replace it with indented
config options. You wrote yourself in your cover text that 5 entries would be the arbitrary cut-off.That said, it's acceptable to have this as an inbetween step as well.
Well, as I said in the commit, it's not about judging whether it makessense or not, it;s just about changing the 'config'+'menu' into a 'menuconfig'.
However, yes, I can /fix/ it in the second part of the series, when the '5 options or more' concept is introduced.
Regards,
Yann E. MORIN.
Quoted 49 lines
Regards,
ArnoutQuoted 36 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/udpcast/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)package/udpcast/Config.in +1
-5@@ -2,7 +2,7 @@ comment "udpcast needs a toolchain w/ threads" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_UDPCAST +menuconfig BR2_PACKAGE_UDPCAST bool "udpcast" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork()@@ -14,8 +14,6 @@ config BR2_PACKAGE_UDPCAST if BR2_PACKAGE_UDPCAST -menu "udpcast tools selection" - config BR2_PACKAGE_UDPCAST_SENDER bool "sender" help@@ -26,6 +24,4 @@ config BR2_PACKAGE_UDPCAST_RECEIVER help The udpcast receiver. -endmenu - endifSignature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 32/84 package/gstreamer: include plugins from gstreamer's real Config.in
In reply to Yann E. MORINIt is more logical to have a single if-clause, rather than repeat it in another file, possiblty brealking indentation like it previously was.
--- package/gstreamer/Config.in | 12 ------------ package/gstreamer/gstreamer/Config.in | 10 ++++++++++ 2 files changed, 10 insertions(+), 12 deletions(-)
package/gstreamer/Config.in +0 -12
@@ -1,14 +1,2 @@ # Gstreamer 0.10.x & Plugins source "package/gstreamer/gstreamer/Config.in" - -if BR2_PACKAGE_GSTREAMER -source "package/gstreamer/gst-plugins-base/Config.in" -source "package/gstreamer/gst-plugins-good/Config.in" -source "package/gstreamer/gst-plugins-bad/Config.in" -source "package/gstreamer/gst-plugins-ugly/Config.in" -source "package/gstreamer/gst-ffmpeg/Config.in" -source "package/gstreamer/gst-dsp/Config.in" -source "package/gstreamer/gst-fsl-plugins/Config.in" -source "package/gstreamer/gst-omapfb/Config.in" -source "package/gstreamer/gst-plugin-x170/Config.in" -endif
package/gstreamer/gstreamer/Config.in +10 -0
@@ -33,4 +33,14 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY Enable support for the GStreamer plugin registry. This may increase the launch-time for a GStreamer application. +source "package/gstreamer/gst-plugins-base/Config.in" +source "package/gstreamer/gst-plugins-good/Config.in" +source "package/gstreamer/gst-plugins-bad/Config.in" +source "package/gstreamer/gst-plugins-ugly/Config.in" +source "package/gstreamer/gst-ffmpeg/Config.in" +source "package/gstreamer/gst-dsp/Config.in" +source "package/gstreamer/gst-fsl-plugins/Config.in" +source "package/gstreamer/gst-omapfb/Config.in" +source "package/gstreamer/gst-plugin-x170/Config.in" + endif
Signature · 1 line
1.9.1
RFC PATCH 32/84 package/gstreamer: include plugins from gstreamer's real Config.in
Quoted 2 lines · Yann E. MORIN
It is more logical to have a single if-clause, rather than repeat it in another file, possiblty brealking indentation like it previously was.
I actually preferred the way it was indented before. Now there is no
distinction anymore between the gstreamer options and the additional plugin packages. But I don't feel strongly about it.
Regards,
Arnout
Quoted 46 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gstreamer/Config.in | 12 ------------ package/gstreamer/gstreamer/Config.in | 10 ++++++++++ 2 files changed, 10 insertions(+), 12 deletions(-)package/gstreamer/Config.in +0
-12@@ -1,14 +1,2 @@ # Gstreamer 0.10.x & Plugins source "package/gstreamer/gstreamer/Config.in" - -if BR2_PACKAGE_GSTREAMER -source "package/gstreamer/gst-plugins-base/Config.in" -source "package/gstreamer/gst-plugins-good/Config.in" -source "package/gstreamer/gst-plugins-bad/Config.in" -source "package/gstreamer/gst-plugins-ugly/Config.in" -source "package/gstreamer/gst-ffmpeg/Config.in" -source "package/gstreamer/gst-dsp/Config.in" -source "package/gstreamer/gst-fsl-plugins/Config.in" -source "package/gstreamer/gst-omapfb/Config.in" -source "package/gstreamer/gst-plugin-x170/Config.in" -endifpackage/gstreamer/gstreamer/Config.in +10
-0@@ -33,4 +33,14 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY Enable support for the GStreamer plugin registry. This may increase the launch-time for a GStreamer application. +source "package/gstreamer/gst-plugins-base/Config.in" +source "package/gstreamer/gst-plugins-good/Config.in" +source "package/gstreamer/gst-plugins-bad/Config.in" +source "package/gstreamer/gst-plugins-ugly/Config.in" +source "package/gstreamer/gst-ffmpeg/Config.in" +source "package/gstreamer/gst-dsp/Config.in" +source "package/gstreamer/gst-fsl-plugins/Config.in" +source "package/gstreamer/gst-omapfb/Config.in" +source "package/gstreamer/gst-plugin-x170/Config.in" + endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 32/84 package/gstreamer: include plugins from gstreamer's real Config.in
Arnout, All,
On 2015-12-31 01:12 +0100, Arnout Vandecappelle spake thusly:
Quoted 7 lines · Yann E. MORIN
Quoted 2 lines
It is more logical to have a single if-clause, rather than repeat it in another file, possiblty brealking indentation like it previously was.
I actually preferred the way it was indented before. Now there is no
distinction anymore between the gstreamer options and the additional plugin packages.
Yes, that is on-purpose. The gstreamer plugins are really "sub-options" (in the end-user experience) of gstreamer. That they are in fact completely different packages is still irrelevant to him. ;-)
Regards,
Yann E. MORIN.
Quoted 61 lines
But I don't feel strongly about it.
Regards,
ArnoutQuoted 46 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gstreamer/Config.in | 12 ------------ package/gstreamer/gstreamer/Config.in | 10 ++++++++++ 2 files changed, 10 insertions(+), 12 deletions(-)package/gstreamer/Config.in +0
-12@@ -1,14 +1,2 @@ # Gstreamer 0.10.x & Plugins source "package/gstreamer/gstreamer/Config.in" - -if BR2_PACKAGE_GSTREAMER -source "package/gstreamer/gst-plugins-base/Config.in" -source "package/gstreamer/gst-plugins-good/Config.in" -source "package/gstreamer/gst-plugins-bad/Config.in" -source "package/gstreamer/gst-plugins-ugly/Config.in" -source "package/gstreamer/gst-ffmpeg/Config.in" -source "package/gstreamer/gst-dsp/Config.in" -source "package/gstreamer/gst-fsl-plugins/Config.in" -source "package/gstreamer/gst-omapfb/Config.in" -source "package/gstreamer/gst-plugin-x170/Config.in" -endifpackage/gstreamer/gstreamer/Config.in +10
-0@@ -33,4 +33,14 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY Enable support for the GStreamer plugin registry. This may increase the launch-time for a GStreamer application. +source "package/gstreamer/gst-plugins-base/Config.in" +source "package/gstreamer/gst-plugins-good/Config.in" +source "package/gstreamer/gst-plugins-bad/Config.in" +source "package/gstreamer/gst-plugins-ugly/Config.in" +source "package/gstreamer/gst-ffmpeg/Config.in" +source "package/gstreamer/gst-dsp/Config.in" +source "package/gstreamer/gst-fsl-plugins/Config.in" +source "package/gstreamer/gst-omapfb/Config.in" +source "package/gstreamer/gst-plugin-x170/Config.in" + endifSignature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 32/84 package/gstreamer: include plugins from gstreamer's real Config.in
Quoted 7 lines · Yann E. MORIN
Arnout, All,
On 2015-12-31 01:12 +0100, Arnout Vandecappelle spake thusly:
Quoted 4 lines · Yann E. MORIN
Quoted 2 lines
It is more logical to have a single if-clause, rather than repeat it in another file, possiblty brealking indentation like it previously was.
Quoted 7 lines
Quoted 3 lines
I actually preferred the way it was indented before. Now there is no
distinction anymore between the gstreamer options and the additional plugin packages.Yes, that is on-purpose. The gstreamer plugins are really "sub-options" (in the end-user experience) of gstreamer. That they are in fact completely different packages is still irrelevant to him. ;-)
Well, according to that reasoning the packages should not be shown and instead
only the plug-in list should be there. I don't think we're going to do that.
The reason I had less of a concern about gstreamer is because here most of them
are in fact pieces of the same project (like kodi, xorg, matchbox, etc). The others (python, php, ...) are really external plugins. Of course there are also some "external" plugins here, but even those tend to get absorbed by the superproject eventually (like what happened with gst-omx for instance).
Still,
Regards,
Arnout
Quoted 10 lines
Regards,
Yann E. MORIN.Quoted 6 lines
But I don't feel strongly about it.
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 32/84 package/gstreamer: include plugins from gstreamer's real Config.in
Arnout, All,
On 2016-01-02 02:21 +0100, Arnout Vandecappelle spake thusly:
Quoted 12 lines · Yann E. MORIN
Quoted 11 lines
Arnout, All,
On 2015-12-31 01:12 +0100, Arnout Vandecappelle spake thusly:
Quoted 7 lines · Yann E. MORIN
Quoted 2 lines
It is more logical to have a single if-clause, rather than repeat it in another file, possiblty brealking indentation like it previously was.
I actually preferred the way it was indented before. Now there is no
distinction anymore between the gstreamer options and the additional plugin packages.
Quoted 6 lines
Quoted 3 lines
Yes, that is on-purpose. The gstreamer plugins are really "sub-options" (in the end-user experience) of gstreamer. That they are in fact completely different packages is still irrelevant to him. ;-)
Well, according to that reasoning the packages should not be shown and instead
only the plug-in list should be there. I don't think we're going to do that.
No, especially since it is totally possible to use gstreamer even without the base plugins, using only local (aka proprietary) plugins.
Quoted 2 lines
The reason I had less of a concern about gstreamer is because here most of them
are in fact pieces of the same project (like kodi, xorg, matchbox, etc).
OK, I understand now.
But for Kodi, not all the addons are managed by the "Kodi project". For example, most if not all the PVR addons are completely separately developped.
Quoted 4 lines
The
others (python, php, ...) are really external plugins. Of course there are also some "external" plugins here, but even those tend to get absorbed by the superproject eventually (like what happened with gst-omx for instance).
I now see what was the difference for you, thanks!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 33/84 package/gstreamer: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORIN--- package/gstreamer/gstreamer/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/gstreamer/gstreamer/Config.in +1 -1
@@ -2,7 +2,7 @@ comment "gstreamer 0.10 needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_GSTREAMER +menuconfig BR2_PACKAGE_GSTREAMER bool "gstreamer 0.10" depends on BR2_USE_WCHAR # glib2 depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
Signature · 1 line
1.9.1
RFC PATCH 33/84 package/gstreamer: use 'menuconfig' instead of 'config'+'menu'
Subject is wrong: there was no menu originally, you added it.
Again I don't really like it, but I don't feel so strongly about it as about
jquery etc.
Regards,
Arnout
Quoted 19 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gstreamer/gstreamer/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/gstreamer/gstreamer/Config.in +1
-1@@ -2,7 +2,7 @@ comment "gstreamer 0.10 needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_GSTREAMER +menuconfig BR2_PACKAGE_GSTREAMER bool "gstreamer 0.10" depends on BR2_USE_WCHAR # glib2 depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 33/84 package/gstreamer: use 'menuconfig' instead of 'config'+'menu'
On 2015-12-31 01:14 +0100, Arnout Vandecappelle spake thusly:
Quoted 4 lines
Subject is wrong: there was no menu originally, you added it.
Again I don't really like it, but I don't feel so strongly about it as about
jquery etc.
Then you got me confused. What's different for gstreamer from jquery, that makes it acceptable for gstreamer and not jquery?
Really, I'm puzzled...
Regards,
Yann E. MORIN.
Quoted 32 lines
Regards,
ArnoutQuoted 19 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gstreamer/gstreamer/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/gstreamer/gstreamer/Config.in +1
-1@@ -2,7 +2,7 @@ comment "gstreamer 0.10 needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_GSTREAMER +menuconfig BR2_PACKAGE_GSTREAMER bool "gstreamer 0.10" depends on BR2_USE_WCHAR # glib2 depends on BR2_TOOLCHAIN_HAS_THREADS # glib2Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 34/84 package/gstreamer1: include plugins from gstreamer1's real Config.in
In reply to Yann E. MORINIt is more logical to have a single if-clause, rather than repeat it in another file, possiblty brealking indentation like it previously was.
--- package/gstreamer1/Config.in | 11 ----------- package/gstreamer1/gstreamer1/Config.in | 9 +++++++++ 2 files changed, 9 insertions(+), 11 deletions(-)
package/gstreamer1/Config.in +0 -11
@@ -1,13 +1,2 @@ # Gstreamer 1.x & Plugins source "package/gstreamer1/gstreamer1/Config.in" - -if BR2_PACKAGE_GSTREAMER1 -source "package/gstreamer1/gst1-plugins-base/Config.in" -source "package/gstreamer1/gst1-plugins-good/Config.in" -source "package/gstreamer1/gst1-plugins-bad/Config.in" -source "package/gstreamer1/gst1-plugins-ugly/Config.in" -source "package/gstreamer1/gst1-imx/Config.in" -source "package/gstreamer1/gst1-libav/Config.in" -source "package/gstreamer1/gst1-validate/Config.in" -source "package/gstreamer1/gst-omx/Config.in" -endif
package/gstreamer1/gstreamer1/Config.in +9 -0
@@ -52,4 +52,13 @@ config BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS Install the gst-launch and gst-inspect tools. This will take up additional space on the target. +source "package/gstreamer1/gst1-plugins-base/Config.in" +source "package/gstreamer1/gst1-plugins-good/Config.in" +source "package/gstreamer1/gst1-plugins-bad/Config.in" +source "package/gstreamer1/gst1-plugins-ugly/Config.in" +source "package/gstreamer1/gst1-imx/Config.in" +source "package/gstreamer1/gst1-libav/Config.in" +source "package/gstreamer1/gst1-validate/Config.in" +source "package/gstreamer1/gst-omx/Config.in" + endif
Signature · 1 line
1.9.1
RFC PATCH 35/84 package/gstreamer1: use 'menuconfig' instead of 'config'+'menu'
In reply to Yann E. MORIN--- package/gstreamer1/gstreamer1/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/gstreamer1/gstreamer1/Config.in +1 -1
@@ -2,7 +2,7 @@ comment "gstreamer 1.x needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS -config BR2_PACKAGE_GSTREAMER1 +menuconfig BR2_PACKAGE_GSTREAMER1 bool "gstreamer 1.x" depends on BR2_USE_WCHAR # glib2 depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
Signature · 1 line
1.9.1
RFC PATCH 36/84 docs/manual: slightly compactify a paragraph
In reply to Yann E. MORIN--- docs/manual/adding-packages-directory.txt | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
docs/manual/adding-packages-directory.txt +5 -6
@@ -39,12 +39,11 @@ itself should be indented with one tab and two spaces, lines should not be longer than 72 columns, and it must mention the upstream URL of the project. -You can add other sub-options into a +if -BR2_PACKAGE_LIBFOO...endif+ statement to configure particular things -in your software. You can look at examples in other packages. The -syntax of the +Config.in+ file is the same as the one for the kernel -Kconfig file. The documentation for this syntax is available at -http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] +You can add other sub-options into a +if BR2_PACKAGE_LIBFOO...endif+ +statement to configure particular things in your software. You can look at +examples in other packages. The syntax of the +Config.in+ file is the same +as the one for the kernel Kconfig file. The documentation for this syntax is +available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] Finally you have to add your new +libfoo/Config.in+ to +package/Config.in+ (or in a category subdirectory if you decided to
Signature · 1 line
1.9.1
RFC PATCH 37/84 docs/manual: add ordering of kconfig options' attributes
In reply to Yann E. MORINWe want to ensure all packages follow the same coding style, so we add a blurb about the order of kconfig options' attributes:
- first, the type and the prompt
- the default value if needed
- then dependencies of the 'depends on' category
- followed by dependencies of the 'select' form
- with eventually the help text
--- docs/manual/adding-packages-directory.txt | 9 +++++++++ 1 file changed, 9 insertions(+)
docs/manual/adding-packages-directory.txt +9 -0
@@ -39,6 +39,15 @@ itself should be indented with one tab and two spaces, lines should not be longer than 72 columns, and it must mention the upstream URL of the project. +As a convention specific to Buildroot, the ordering of the attributes +is as follows: + +1. The type of option: +bool+, +string+... with the prompt +2. If needed, the +default+ value +3. Any dependency of the +depends on+ form +4. Any depenency of the +select+ form +5. The help keyword and help text. + You can add other sub-options into a +if BR2_PACKAGE_LIBFOO...endif+ statement to configure particular things in your software. You can look at examples in other packages. The syntax of the +Config.in+ file is the same
Signature · 1 line
1.9.1
RFC PATCH 38/84 docs/manual: add example about sub-options
In reply to Yann E. MORIN--- docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)
docs/manual/adding-packages-directory.txt +25 -0
@@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same as the one for the kernel Kconfig file. The documentation for this syntax is available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] +For example: + +--------------------------- +config BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is. + + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOO + +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious. + +endif # BR2_PACKAGE_LIBFOO +--------------------------- + +The sub-options will be cleanly indented below the main symbol when it +is enabled, and will be properly hidden when the symbol is disabled. + + Finally you have to add your new +libfoo/Config.in+ to +package/Config.in+ (or in a category subdirectory if you decided to put your package in one of the existing categories). The files
Signature · 1 line
1.9.1
RFC PATCH 38/84 docs/manual: add example about sub-options
Quoted 20 lines · Yann E. MORIN
Signed-off-by "Yann E. MORIN" <[email protected]>--- docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)docs/manual/adding-packages-directory.txt +7
-0@@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same as the one for the kernel Kconfig file. The documentation for this syntax is available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] +For example: + +--------------------------- +config BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is.
docs/manual/adding-packages-directory.txt examples in other packages. The syntax of the +Config.in+ file is the same · line 73
Quoted 10 lines
docs/manual/adding-packages-directory.txt +10
-0+ + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOO + +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious.
This should be indented at 72 columns like we require in the real Config.in.
Regards,
Arnout
Quoted 12 lines
docs/manual/adding-packages-directory.txt +8
-0+ +endif # BR2_PACKAGE_LIBFOO +--------------------------- + +The sub-options will be cleanly indented below the main symbol when it +is enabled, and will be properly hidden when the symbol is disabled. + + Finally you have to add your new +libfoo/Config.in+ to +package/Config.in+ (or in a category subdirectory if you decided to put your package in one of the existing categories). The files
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 38/84 docs/manual: add example about sub-options
Arnout, All,
On 2015-12-31 01:17 +0100, Arnout Vandecappelle spake thusly:
Quoted 25 lines · Yann E. MORIN
Quoted 24 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)docs/manual/adding-packages-directory.txt +11
-0@@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same as the one for the kernel Kconfig file. The documentation for this syntax is available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] +For example: + +--------------------------- +config BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is. + + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOO
Quoted 8 lines
docs/manual/adding-packages-directory.txt examples in other packages. The syntax of the +Config.in+ file is the same · line 73
Quoted 6 lines
docs/manual/adding-packages-directory.txt +6
-0+ +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious.This should be indented at 72 columns like we require in the real Config.in.
Yes, but in this case, the second line is really short, and in that case I prefer (and usually tend to use) a shorter first line so the second line is more than one or two words, it looks easier to read to me...
But I don't feel strongly about it either. I'll fix.
Regards,
Yann E. MORIN.
Quoted 24 lines
Regards,
ArnoutQuoted 12 lines
docs/manual/adding-packages-directory.txt +8
-0+ +endif # BR2_PACKAGE_LIBFOO +--------------------------- + +The sub-options will be cleanly indented below the main symbol when it +is enabled, and will be properly hidden when the symbol is disabled. + + Finally you have to add your new +libfoo/Config.in+ to +package/Config.in+ (or in a category subdirectory if you decided to put your package in one of the existing categories). The filesSignature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 38/84 docs/manual: add example about sub-options
Quoted 37 lines · Yann E. MORIN
Arnout, All,
On 2015-12-31 01:17 +0100, Arnout Vandecappelle spake thusly:
Quoted 25 lines · Yann E. MORIN
Quoted 24 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)docs/manual/adding-packages-directory.txt +11
-0@@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same as the one for the kernel Kconfig file. The documentation for this syntax is available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] +For example: + +--------------------------- +config BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is. + + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOOQuoted 8 lines
docs/manual/adding-packages-directory.txt examples in other packages. The syntax of the +Config.in+ file is the same · line 73
Quoted 6 lines
docs/manual/adding-packages-directory.txt +6
-0+ +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious.This should be indented at 72 columns like we require in the real Config.in.
Quoted 3 lines
Yes, but in this case, the second line is really short, and in that case I prefer (and usually tend to use) a shorter first line so the second line is more than one or two words, it looks easier to read to me...
Well, this is the manual, we're setting the example here, so not sticking to
the rule would be confusing IMHO.
Regards,
Arnout
Quoted 8 lines
But I don't feel strongly about it either. I'll fix.
Regards,
Yann E. MORIN.Quoted 2 lines
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 38/84 docs/manual: add example about sub-options
Arnout, All,
On 2016-01-02 02:23 +0100, Arnout Vandecappelle spake thusly:
Quoted 36 lines · Yann E. MORIN
Quoted 35 lines
On 2015-12-31 01:17 +0100, Arnout Vandecappelle spake thusly:
Quoted 33 lines · Yann E. MORIN
Quoted 20 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)docs/manual/adding-packages-directory.txt +7
-0@@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same as the one for the kernel Kconfig file. The documentation for this syntax is available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[] +For example: + +--------------------------- +config BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is.docs/manual/adding-packages-directory.txt examples in other packages. The syntax of the +Config.in+ file is the same · line 73
Quoted 10 lines
docs/manual/adding-packages-directory.txt +10
-0+ + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOO + +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious.This should be indented at 72 columns like we require in the real Config.in.
Quoted 6 lines
Quoted 3 lines
Yes, but in this case, the second line is really short, and in that case I prefer (and usually tend to use) a shorter first line so the second line is more than one or two words, it looks easier to read to me...
Well, this is the manual, we're setting the example here, so not sticking to
the rule would be confusing IMHO.
Agreed. I'll fix.
Thanks!
Regards,
Yann E. MORIN.
Quoted 20 lines
Regards,
ArnoutQuoted 8 lines
But I don't feel strongly about it either. I'll fix.
Regards,
Yann E. MORIN.Quoted 2 lines
Regards,
Arnout[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 39/84 docs/manual: use 'menuconfig' when there are more than 5 sub-options
In reply to Yann E. MORINWhen a package has a lot of sub-options, the layout in menuconfig (the mconf UI) is quickly getting messy.
Using 'menuconfig' (the kconfig keyword) will automatically create a sub-menu, which provides a cleaner layout.
Document that, with 5 or more options, a 'menuconfig' should be used instead of a simple 'config'.
---
Note: 5 is arbitrary. We could tweak it to a bit more, but on small terminals (the smallest supported is 80x24), there are only 10 lines for the menu entries, so 5 looks like a good compromise. YMMV.
--- docs/manual/adding-packages-directory.txt | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
docs/manual/adding-packages-directory.txt +28 -0
@@ -79,6 +79,34 @@ The sub-options will be cleanly indented below the main symbol when it is enabled, and will be properly hidden when the symbol is disabled. +If your package has 5 or more options, then you should use +menuconfig+ +to define the main symbol; this will ensure that all the package's +sub-options are automaticaly classified in a sub-menu: + +--------------------------- +menuconfig BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is. + + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOO + +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious. + +endif # BR2_PACKAGE_LIBFOO +--------------------------- + +In any case, ensure that there is no +comment+ or other symbol in-between +the main symbol (be it +config+ or +menuconfig+) and the +if+ clause, +otherwise 'Kconfig' will not properly classify the sub-options. + + Finally you have to add your new +libfoo/Config.in+ to +package/Config.in+ (or in a category subdirectory if you decided to put your package in one of the existing categories). The files
Signature · 1 line
1.9.1
RFC PATCH 39/84 docs/manual: use 'menuconfig' when there are more than 5 sub-options
Quoted 36 lines · Yann E. MORIN
When a package has a lot of sub-options, the layout in menuconfig (the mconf UI) is quickly getting messy.
Using 'menuconfig' (the kconfig keyword) will automatically create a sub-menu, which provides a cleaner layout.
Document that, with 5 or more options, a 'menuconfig' should be used instead of a simple 'config'.
Signed-off-by "Yann E. MORIN" <[email protected]>---
Note: 5 is arbitrary. We could tweak it to a bit more, but on small terminals (the smallest supported is 80x24), there are only 10 lines for the menu entries, so 5 looks like a good compromise. YMMV.--- docs/manual/adding-packages-directory.txt | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)docs/manual/adding-packages-directory.txt +9
-0@@ -79,6 +79,34 @@ The sub-options will be cleanly indented below the main symbol when it is enabled, and will be properly hidden when the symbol is disabled. +If your package has 5 or more options, then you should use +menuconfig+ +to define the main symbol; this will ensure that all the package's +sub-options are automaticaly classified in a sub-menu: + +--------------------------- +menuconfig BR2_PACKAGE_LIBFOO + bool "libfoo" + help + This is a comment that explains what libfoo is.
docs/manual/adding-packages-directory.txt The sub-options will be cleanly indented below the main symbol when it · line 100
Quoted 10 lines
docs/manual/adding-packages-directory.txt +10
-0+ + http://foosoftware.org/libfoo/ + +if BR2_PACKAGE_LIBFOO + +config BR2_PACKAGE_LIBFOO_BAR + bool "bar support" + help + This is a comment that briefly explains what + bar support is, if it's not obvious.
Again the wrapping.
Regards,
Arnout
Quoted 13 lines
docs/manual/adding-packages-directory.txt +9
-0+ +endif # BR2_PACKAGE_LIBFOO +--------------------------- + +In any case, ensure that there is no +comment+ or other symbol in-between +the main symbol (be it +config+ or +menuconfig+) and the +if+ clause, +otherwise 'Kconfig' will not properly classify the sub-options. + + Finally you have to add your new +libfoo/Config.in+ to +package/Config.in+ (or in a category subdirectory if you decided to put your package in one of the existing categories). The files
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 40/84 package/valgrind: use 'menuconfig'
In reply to Yann E. MORINValgrind has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/valgrind/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/valgrind/Config.in +1 -1
@@ -1,7 +1,7 @@ comment "valgrind needs a toolchain w/ dynamic library" depends on BR2_STATIC_LIBS -config BR2_PACKAGE_VALGRIND +menuconfig BR2_PACKAGE_VALGRIND bool "valgrind" depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \ BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
Signature · 1 line
1.9.1
RFC PATCH 41/84 package/e2fsprogs: use 'menuconfig'
In reply to Yann E. MORINe2fsprogs has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/e2fsprogs/Config.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
package/e2fsprogs/Config.in +1 -2
@@ -1,5 +1,4 @@ - -config BR2_PACKAGE_E2FSPROGS +menuconfig BR2_PACKAGE_E2FSPROGS bool "e2fsprogs" depends on BR2_USE_WCHAR # util-linux depends on BR2_USE_MMU # util-linux/libblkid
Signature · 1 line
1.9.1
RFC PATCH 42/84 package/mtd: use 'menuconfig'
In reply to Yann E. MORINmtd has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/mtd/Config.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
package/mtd/Config.in +1 -2
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_MTD +menuconfig BR2_PACKAGE_MTD bool "mtd, jffs2 and ubi/ubifs tools" help Build mtd, jffs2 and ubi/ubifs tools
@@ -6,7 +6,6 @@ config BR2_PACKAGE_MTD http://www.linux-mtd.infradead.org/ if BR2_PACKAGE_MTD -comment "MTD tools selection" config BR2_PACKAGE_MTD_DOCFDISK bool "docfdisk"
Signature · 1 line
1.9.1
RFC PATCH 43/84 package/squashfs: use 'menuconfig'
In reply to Yann E. MORINsquashfs has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/squashfs/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/squashfs/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_SQUASHFS +menuconfig BR2_PACKAGE_SQUASHFS bool "squashfs" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork()
Signature · 1 line
1.9.1
RFC PATCH 44/84 package/dejavu: use 'menuconfig'
In reply to Yann E. MORINdejavu has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/dejavu/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/dejavu/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DEJAVU +menuconfig BR2_PACKAGE_DEJAVU bool "DejaVu fonts" help The DejaVu fonts are a font family based on the Vera Fonts.
Signature · 1 line
1.9.1
RFC PATCH 45/84 package/google-material-design-icons: use 'menuconfig'
In reply to Yann E. MORINgoogle-material-design-icons has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/google-material-design-icons/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/google-material-design-icons/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_GOOGLE_MATERIAL_DESIGN_ICONS +menuconfig BR2_PACKAGE_GOOGLE_MATERIAL_DESIGN_ICONS bool "google-material-design-icons" help Material design icons are the official icon set from Google that
Signature · 1 line
1.9.1
RFC PATCH 46/84 package/directfb: use 'menuconfig'
In reply to Yann E. MORINdirectfb has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/directfb/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/directfb/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DIRECTFB +menuconfig BR2_PACKAGE_DIRECTFB bool "directfb" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPP
Signature · 1 line
1.9.1
RFC PATCH 46/84 package/directfb: use 'menuconfig'
Quoted 14 lines · Yann E. MORIN
directfb has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/directfb/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/directfb/Config.in +0
-0
package/directfb/Config.in line 4
Quoted 5 lines
package/directfb/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DIRECTFB +menuconfig BR2_PACKAGE_DIRECTFB bool "directfb" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPP
Maybe directfb-examples should be moved into this menu as well?
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 46/84 package/directfb: use 'menuconfig'
Arnout, All,
On 2016-01-02 02:30 +0100, Arnout Vandecappelle spake thusly:
Quoted 9 lines · Yann E. MORIN
Quoted 8 lines
directfb has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/directfb/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
package/directfb/Config.in line 4
Quoted 10 lines
package/directfb/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DIRECTFB +menuconfig BR2_PACKAGE_DIRECTFB bool "directfb" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPPMaybe directfb-examples should be moved into this menu as well?
I was not sure about that one.
directfb-examples is a separate package that buids _on top_ of directfb; it does not provide additional features like addons or modules that can be 'dynamically loaded' at runtime (like gst plugins or php mdules or perl addons or...).
IMHO it's a bit like enlightenment and EFL: enlightenment is only one package that can _use_ EFL and does not enhance EFL.
But since they are example for DirectFB, it probably does not nmake sense to have it on the final target, and they would probably be used only during development, so could belong to the directfb sub-menu.
Anyway, I'll leave it out for now, we can move it later if people prefer.
Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
RFC PATCH 47/84 package/efl: use 'menuconfig'
In reply to Yann E. MORINEFL has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/efl/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/efl/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_EFL +menuconfig BR2_PACKAGE_EFL bool "efl" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_PACKAGE_HAS_UDEV # libudev
Signature · 1 line
1.9.1
RFC PATCH 48/84 package/sdl: use 'menuconfig'
In reply to Yann E. MORINSDL has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/sdl/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/sdl/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_SDL +menuconfig BR2_PACKAGE_SDL bool "SDL" help Simple DirectMedia Layer - SDL is a library that allows
Signature · 1 line
1.9.1
RFC PATCH 49/84 package/sdl: include SDL external libraries from sdl's Config.in
In reply to Yann E. MORIN--- package/Config.in | 6 ------ package/sdl/Config.in | 9 +++++++++ 2 files changed, 9 insertions(+), 6 deletions(-)
package/Config.in +0 -6
@@ -263,12 +263,6 @@ endif source "package/ocrad/Config.in" source "package/psplash/Config.in" source "package/sdl/Config.in" - source "package/sdl_gfx/Config.in" - source "package/sdl_image/Config.in" - source "package/sdl_mixer/Config.in" - source "package/sdl_net/Config.in" - source "package/sdl_sound/Config.in" - source "package/sdl_ttf/Config.in" source "package/sdl2/Config.in" comment "Other GUIs"
package/sdl/Config.in +9 -0
@@ -27,4 +27,13 @@ config BR2_PACKAGE_SDL_X11 select BR2_PACKAGE_XLIB_LIBX11 select BR2_PACKAGE_XLIB_LIBXEXT +comment "External libraries" + +source "package/sdl_gfx/Config.in" +source "package/sdl_image/Config.in" +source "package/sdl_mixer/Config.in" +source "package/sdl_net/Config.in" +source "package/sdl_sound/Config.in" +source "package/sdl_ttf/Config.in" + endif
Signature · 1 line
1.9.1
RFC PATCH 50/84 package/sdl_*: remove redundant dependency
In reply to Yann E. MORINNow that those packages are directly included in an if-SDL clause, there is no need to expressly depend on SDL.
--- package/sdl_gfx/Config.in | 1 - package/sdl_image/Config.in | 1 - package/sdl_mixer/Config.in | 1 - package/sdl_net/Config.in | 1 - package/sdl_sound/Config.in | 1 - package/sdl_ttf/Config.in | 1 - 6 files changed, 6 deletions(-)
package/sdl_gfx/Config.in +0 -1
@@ -1,6 +1,5 @@ config BR2_PACKAGE_SDL_GFX bool "SDL_gfx" - depends on BR2_PACKAGE_SDL help The SDL_gfx library is an extension to the SDL library which provides basic antialiased drawing routines such as lines,
package/sdl_image/Config.in +0 -1
@@ -1,6 +1,5 @@ menuconfig BR2_PACKAGE_SDL_IMAGE bool "SDL_image" - depends on BR2_PACKAGE_SDL help SDL_image is an image file loading library. It loads images as SDL surfaces, and supports the following formats:
package/sdl_mixer/Config.in +0 -1
@@ -1,6 +1,5 @@ config BR2_PACKAGE_SDL_MIXER bool "SDL_mixer" - depends on BR2_PACKAGE_SDL help SDL_mixer is a sample multi-channel audio mixer library. It supports any number of simultaneously playing channels of
package/sdl_net/Config.in +0 -1
@@ -1,6 +1,5 @@ config BR2_PACKAGE_SDL_NET bool "SDL_net" - depends on BR2_PACKAGE_SDL help SDL_net is a small, low-level, cross-platform network library, that can be used with the Simple DirectMedia Layer library (SDL).
package/sdl_sound/Config.in +0 -1
@@ -1,6 +1,5 @@ config BR2_PACKAGE_SDL_SOUND bool "SDL_sound" - depends on BR2_PACKAGE_SDL select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help SDL_sound is a library that handles the decoding of several
package/sdl_ttf/Config.in +0 -1
@@ -1,6 +1,5 @@ config BR2_PACKAGE_SDL_TTF bool "SDL_TTF" - depends on BR2_PACKAGE_SDL select BR2_PACKAGE_FREETYPE help SDL_ttf is a sample TrueType font library. It allows you to
Signature · 1 line
1.9.1
RFC PATCH 51/84 package/lm-sensors: use 'menuconfig'
In reply to Yann E. MORINlm-sensors has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/lm-sensors/Config.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
package/lm-sensors/Config.in +1 -2
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_LM_SENSORS +menuconfig BR2_PACKAGE_LM_SENSORS bool "lm-sensors" help Lm-sensors is a hardware health monitoring package for
@@ -9,7 +9,6 @@ config BR2_PACKAGE_LM_SENSORS http://www.lm-sensors.org/ if BR2_PACKAGE_LM_SENSORS -comment "lm-sensors tools" config BR2_PACKAGE_LM_SENSORS_SENSORS bool "sensors"
Signature · 1 line
1.9.1
RFC PATCH 52/84 package/openocd: use 'menuconfig'
In reply to Yann E. MORINopenocd has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/openocd/Config.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
package/openocd/Config.in +1 -3
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_OPENOCD +menuconfig BR2_PACKAGE_OPENOCD bool "openocd" help OpenOCD - Open On-Chip Debugger
@@ -7,8 +7,6 @@ config BR2_PACKAGE_OPENOCD if BR2_PACKAGE_OPENOCD -comment "Adapters" - config BR2_PACKAGE_OPENOCD_FTDI bool "MPSSE mode of FTDI based devices" select BR2_PACKAGE_LIBUSB
Signature · 1 line
1.9.1
RFC PATCH 53/84 package/erlang: include Erlang libraries from erlang's Config.in
In reply to Yann E. MORINerlang now has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/Config.in | 16 ---------------- package/erlang/Config.in | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 17 deletions(-)
package/Config.in +0 -16
@@ -458,22 +458,6 @@ endmenu menu "Interpreter languages and scripting" source "package/enscript/Config.in" source "package/erlang/Config.in" -if BR2_PACKAGE_ERLANG -menu "Erlang libraries/modules" - source "package/erlang-goldrush/Config.in" - source "package/erlang-lager/Config.in" - source "package/erlang-p1-cache-tab/Config.in" - source "package/erlang-p1-iconv/Config.in" - source "package/erlang-p1-sip/Config.in" - source "package/erlang-p1-stringprep/Config.in" - source "package/erlang-p1-stun/Config.in" - source "package/erlang-p1-tls/Config.in" - source "package/erlang-p1-utils/Config.in" - source "package/erlang-p1-xml/Config.in" - source "package/erlang-p1-yaml/Config.in" - source "package/erlang-p1-zlib/Config.in" -endmenu -endif source "package/gauche/Config.in" source "package/guile/Config.in" source "package/haserl/Config.in"
package/erlang/Config.in +16 -1
@@ -3,7 +3,7 @@ comment "erlang needs a toolchain w/ dynamic library" depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS depends on BR2_STATIC_LIBS -config BR2_PACKAGE_ERLANG +menuconfig BR2_PACKAGE_ERLANG bool "erlang" depends on BR2_USE_MMU # fork() depends on !BR2_STATIC_LIBS
@@ -37,4 +37,19 @@ config BR2_PACKAGE_ERLANG_MEGACO size so if you do not need it then it is recommended not to enable it. +comment "Erlang libraries/modules" + +source "package/erlang-goldrush/Config.in" +source "package/erlang-lager/Config.in" +source "package/erlang-p1-cache-tab/Config.in" +source "package/erlang-p1-iconv/Config.in" +source "package/erlang-p1-sip/Config.in" +source "package/erlang-p1-stringprep/Config.in" +source "package/erlang-p1-stun/Config.in" +source "package/erlang-p1-tls/Config.in" +source "package/erlang-p1-utils/Config.in" +source "package/erlang-p1-xml/Config.in" +source "package/erlang-p1-yaml/Config.in" +source "package/erlang-p1-zlib/Config.in" + endif # BR2_PACKAGE_ERLANG
Signature · 1 line
1.9.1
RFC PATCH 54/84 package/lua{, jit}: move inclusion of external libraries/modules
In reply to Yann E. MORINIntroduce a Config.ext for external Lua external libraries/modules, that both lua and luajit include from their respective sub-menus.
lua and luajit now have more than 5 options, so use a 'menuconfig' to group the options in sub-menus.
--- package/Config.in | 46 -------------------------------------------- package/lua/Config.ext | 49 +++++++++++++++++++++++++++++++++++++++++++++++ package/lua/Config.in | 4 +++- package/luajit/Config.ext | 1 + package/luajit/Config.in | 4 +++- 5 files changed, 56 insertions(+), 48 deletions(-) create mode 100644 package/lua/Config.ext create mode 120000 package/luajit/Config.ext
package/Config.in +0 -46
@@ -466,52 +466,6 @@ menu "Interpreter languages and scripting" source "package/lua/Config.in" source "package/luainterpreter/Config.in" source "package/luajit/Config.in" -if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS -# lua modules are dynamically loaded, so not available on static builds -menu "Lua libraries/modules" - source "package/cgilua/Config.in" - source "package/copas/Config.in" - source "package/cosmo/Config.in" - source "package/coxpcall/Config.in" - source "package/dado/Config.in" - source "package/lbase64/Config.in" - source "package/ljlinenoise/Config.in" - source "package/ljsyscall/Config.in" - source "package/lpeg/Config.in" - source "package/lpty/Config.in" - source "package/lrandom/Config.in" - source "package/lsqlite3/Config.in" - source "package/lua-cjson/Config.in" - source "package/lua-coat/Config.in" - source "package/lua-coatpersistent/Config.in" - source "package/lua-csnappy/Config.in" - source "package/lua-ev/Config.in" - source "package/lua-iconv/Config.in" - source "package/lua-messagepack/Config.in" - source "package/lua-msgpack-native/Config.in" - source "package/lua-periphery/Config.in" - source "package/lua-testmore/Config.in" - source "package/luabitop/Config.in" - source "package/luacrypto/Config.in" - source "package/luaexpat/Config.in" - source "package/luaexpatutils/Config.in" - source "package/luafilesystem/Config.in" - source "package/luajson/Config.in" - source "package/lualogging/Config.in" - source "package/luaposix/Config.in" - source "package/luasec/Config.in" - source "package/luasocket/Config.in" - source "package/luasql-sqlite3/Config.in" - source "package/lunit/Config.in" - source "package/luv/Config.in" - source "package/luvi/Config.in" - source "package/lzlib/Config.in" - source "package/orbit/Config.in" - source "package/rings/Config.in" - source "package/wsapi/Config.in" - source "package/xavante/Config.in" -endmenu -endif source "package/lutok/Config.in" source "package/micropython/Config.in" source "package/micropython-lib/Config.in"
package/lua/Config.ext new file +49 -0
49 lines not on this page · raw message
package/lua/Config.in +3 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_LUA +menuconfig BR2_PACKAGE_LUA bool "lua" select BR2_PACKAGE_HAS_LUAINTERPRETER help
@@ -68,4 +68,6 @@ config BR2_PACKAGE_LUA_LINENOISE endchoice +source "package/lua/Config.ext" + endif
package/luajit/Config.ext new file +1 -0
@@ -0,0 +1 @@ +../lua/Config.ext
package/luajit/Config.in +3 -1
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS BR2_powerpc || BR2_arm || BR2_armeb || \ ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) -config BR2_PACKAGE_LUAJIT +menuconfig BR2_PACKAGE_LUAJIT bool "luajit" select BR2_PACKAGE_HAS_LUAINTERPRETER depends on !BR2_STATIC_LIBS # dlopen
@@ -32,6 +32,8 @@ config BR2_PACKAGE_PROVIDES_LUAINTERPRETER config BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION default "5.1" +source "package/luajit/Config.ext" + endif comment "luajit needs a toolchain w/ dynamic library"
Signature · 1 line
1.9.1
RFC PATCH 55/84 package/sqlite: use 'menuconfig'
In reply to Yann E. MORINsqlite has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/sqlite/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/sqlite/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_SQLITE +menuconfig BR2_PACKAGE_SQLITE bool "sqlite" help SQLite is a small C library that implements a self-contained,
Signature · 1 line
1.9.1
RFC PATCH 56/84 package/cairo: use 'menuconfig'
In reply to Yann E. MORINcairo has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/cairo/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/cairo/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_CAIRO +menuconfig BR2_PACKAGE_CAIRO bool "cairo" depends on BR2_ARCH_HAS_ATOMICS select BR2_PACKAGE_PIXMAN
Signature · 1 line
1.9.1
RFC PATCH 57/84 package/imlib2: use 'menuconfig'
In reply to Yann E. MORINimlib2 has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/imlib2/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/imlib2/Config.in +2 -1
@@ -1,7 +1,7 @@ comment "imlib2 needs a toolchain w/ dynamic library" depends on BR2_STATIC_LIBS -config BR2_PACKAGE_IMLIB2 +menuconfig BR2_PACKAGE_IMLIB2 bool "imlib2" select BR2_PACKAGE_FREETYPE depends on !BR2_STATIC_LIBS # dlopen()
@@ -39,4 +39,5 @@ config BR2_PACKAGE_IMLIB2_X depends on BR2_PACKAGE_XORG7 select BR2_PACKAGE_XLIB_LIBXEXT select BR2_PACKAGE_XLIB_LIBX11 + endif
Signature · 1 line
1.9.1
RFC PATCH 58/84 package/libiio: use 'menuconfig'
In reply to Yann E. MORINlibiio has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/libiio/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/libiio/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_LIBIIO +menuconfig BR2_PACKAGE_LIBIIO bool "libiio" select BR2_PACKAGE_LIBIIO_LOCAL_BACKEND if !BR2_PACKAGE_LIBIIO_NETWORK_BACKEND help
Signature · 1 line
1.9.1
RFC PATCH 59/84 package/flot: use 'menuconfig'
In reply to Yann E. MORINflot has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/flot/Config.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
package/flot/Config.in +1 -3
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_FLOT +menuconfig BR2_PACKAGE_FLOT bool "flot" select BR2_PACKAGE_JQUERY help
@@ -18,8 +18,6 @@ config BR2_PACKAGE_FLOT if BR2_PACKAGE_FLOT -comment "flot plugins" - config BR2_PACKAGE_FLOT_CANVAS bool "canvas" help
Signature · 1 line
1.9.1
RFC PATCH 60/84 package/boost: use 'menuconfig'
In reply to Yann E. MORINboost has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/boost/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/boost/Config.in +1 -1
@@ -5,7 +5,7 @@ config BR2_PACKAGE_BOOST_ARCH_SUPPORTS bool default y if !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII -config BR2_PACKAGE_BOOST +menuconfig BR2_PACKAGE_BOOST bool "boost" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
Signature · 1 line
1.9.1
RFC PATCH 61/84 package/poco: use 'menuconfig'
In reply to Yann E. MORINpoco has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/poco/Config.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
package/poco/Config.in +1 -3
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_POCO +menuconfig BR2_PACKAGE_POCO bool "poco" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR
@@ -15,8 +15,6 @@ config BR2_PACKAGE_POCO if BR2_PACKAGE_POCO -comment "poco components" - config BR2_PACKAGE_POCO_XML bool "xml" select BR2_PACKAGE_EXPAT
Signature · 1 line
1.9.1
RFC PATCH 62/84 package/ncurses: use 'menuconfig'
In reply to Yann E. MORINncurses has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/ncurses/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/ncurses/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_NCURSES +menuconfig BR2_PACKAGE_NCURSES bool "ncurses" help The Ncurses (new curses) library is a free software emulation of
Signature · 1 line
1.9.1
RFC PATCH 63/84 package/dovecot: use 'menuconfig'
In reply to Yann E. MORINdovecot has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/dovecot/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/dovecot/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DOVECOT +menuconfig BR2_PACKAGE_DOVECOT bool "dovecot" depends on !BR2_STATIC_LIBS depends on BR2_USE_MMU # fork()
Signature · 1 line
1.9.1
RFC PATCH 64/84 package/gnuradio: use 'menuconfig'
In reply to Yann E. MORINgnuradio has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/gnuradio/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/gnuradio/Config.in +1 -1
@@ -4,7 +4,7 @@ comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic library" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS -config BR2_PACKAGE_GNURADIO +menuconfig BR2_PACKAGE_GNURADIO bool "gnuradio" depends on BR2_INSTALL_LIBSTDCPP depends on !BR2_STATIC_LIBS
Signature · 1 line
1.9.1
RFC PATCH 65/84 package/gnuradio: split long omment
In reply to Yann E. MORINIt does not fit even is a wider-than-normal terminal.
--- package/gnuradio/Config.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
package/gnuradio/Config.in +5 -2
@@ -58,8 +58,11 @@ config BR2_PACKAGE_GNURADIO_UTILS help Misc python utilities -comment "gr-fft, -filter, -analog, -channels, -digital, -trellis, -pager depends fftw's single precision" - depends on !BR2_PACKAGE_FFTW_PRECISION_SINGLE +if !BR2_PACKAGE_FFTW_PRECISION_SINGLE +comment "gr-fft, gr-filter, gr-analog, gr-channels," +comment "gr-digital, gr-trellis and gr-pager all" +comment "depend on fftw's single precision" +endif if BR2_PACKAGE_FFTW_PRECISION_SINGLE
Signature · 1 line
1.9.1
RFC PATCH 65/84 package/gnuradio: split long omment
Quoted 12 lines · Yann E. MORIN
It does not fit even is a wider-than-normal terminal.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gnuradio/Config.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)package/gnuradio/Config.in +0
-0
package/gnuradio/Config.in config BR2_PACKAGE_GNURADIO_UTILS · line 64
Quoted 9 lines
package/gnuradio/Config.in +4
-2@@ -58,8 +58,11 @@ config BR2_PACKAGE_GNURADIO_UTILS help Misc python utilities -comment "gr-fft, -filter, -analog, -channels, -digital, -trellis, -pager depends fftw's single precision" - depends on !BR2_PACKAGE_FFTW_PRECISION_SINGLE +if !BR2_PACKAGE_FFTW_PRECISION_SINGLE +comment "gr-fft, gr-filter, gr-analog, gr-channels," +comment "gr-digital, gr-trellis and gr-pager all" +comment "depend on fftw's single precision"
This would perhaps be a good occasion to also correct the sentence into
something like "single precision implementation".
Also, it would be prettier if the excess space were filled up with spaces so
the *** lines up, like we do in Config.in.legacy.
Regards,
Arnout
Quoted 5 lines
package/gnuradio/Config.in +1
-0+endif if BR2_PACKAGE_FFTW_PRECISION_SINGLE
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 65/84 package/gnuradio: split long omment
In reply to Yann E. MORINHello,
Any news?
Gwen
Quoted 33 lines · On Fri, 25 Dec 2015 22:25:34 +0100 "Yann E. MORIN" <[email protected]>…
It does not fit even is a wider-than-normal terminal.
Signed-off-by "Yann E. MORIN" <[email protected]>--- package/gnuradio/Config.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)package/gnuradio/Config.in +5
-3@@ -58,8 +58,11 @@ config BR2_PACKAGE_GNURADIO_UTILS help Misc python utilities -comment "gr-fft, -filter, -analog, -channels, -digital, -trellis, -pager depends fftw's single precision" - depends on !BR2_PACKAGE_FFTW_PRECISION_SINGLE +if !BR2_PACKAGE_FFTW_PRECISION_SINGLE +comment "gr-fft, gr-filter, gr-analog, gr-channels," +comment "gr-digital, gr-trellis and gr-pager all" +comment "depend on fftw's single precision" +endif if BR2_PACKAGE_FFTW_PRECISION_SINGLESignature · 7 lines
-- 1.9.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
RFC PATCH 66/84 package/connman: use 'menuconfig'
In reply to Yann E. MORINconnman has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/connman/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/connman/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_CONNMAN +menuconfig BR2_PACKAGE_CONNMAN bool "connman" select BR2_PACKAGE_DBUS select BR2_PACKAGE_LIBGLIB2
Signature · 1 line
1.9.1
RFC PATCH 67/84 package/dnsmasq: use 'menuconfig'
In reply to Yann E. MORINdnsmasq has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/dnsmasq/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/dnsmasq/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DNSMASQ +menuconfig BR2_PACKAGE_DNSMASQ bool "dnsmasq" help A lightweight DNS and DHCP server. It is intended to provide
Signature · 1 line
1.9.1
RFC PATCH 68/84 package/dropbear: use 'menuconfig'
In reply to Yann E. MORINdropbear has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/dropbear/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/dropbear/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_DROPBEAR +menuconfig BR2_PACKAGE_DROPBEAR bool "dropbear" select BR2_PACKAGE_ZLIB if !BR2_PACKAGE_DROPBEAR_SMALL help
Signature · 1 line
1.9.1
RFC PATCH 69/84 package/igh-ethercat: use 'menuconfig'
In reply to Yann E. MORINigh-ethercat has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/igh-ethercat/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/igh-ethercat/Config.in +1 -1
@@ -1,7 +1,7 @@ comment "igh-ethercat needs a Linux kernel to be built" depends on !BR2_LINUX_KERNEL -config BR2_PACKAGE_IGH_ETHERCAT +menuconfig BR2_PACKAGE_IGH_ETHERCAT bool "igh-ethercat" depends on BR2_LINUX_KERNEL help
Signature · 1 line
1.9.1
RFC PATCH 70/84 package/ipsec-tools: use 'menuconfig'
In reply to Yann E. MORINipsec-tools has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/ipsec-tools/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/ipsec-tools/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_IPSEC_TOOLS +menuconfig BR2_PACKAGE_IPSEC_TOOLS bool "ipsec-tools" select BR2_PACKAGE_OPENSSL select BR2_PACKAGE_FLEX
Signature · 1 line
1.9.1
RFC PATCH 71/84 package/lftp: use 'menuconfig'
In reply to Yann E. MORINlftp has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/lftp/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/lftp/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_LFTP +menuconfig BR2_PACKAGE_LFTP bool "lftp" depends on BR2_USE_WCHAR depends on BR2_INSTALL_LIBSTDCPP
Signature · 1 line
1.9.1
RFC PATCH 72/84 package/lighttpd: use 'menuconfig'
In reply to Yann E. MORINlighttpd has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/lighttpd/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/lighttpd/Config.in +1 -1
@@ -2,7 +2,7 @@ comment "lighttpd needs a toolchain w/ dynamic library" depends on BR2_USE_MMU depends on BR2_STATIC_LIBS -config BR2_PACKAGE_LIGHTTPD +menuconfig BR2_PACKAGE_LIGHTTPD bool "lighttpd" depends on BR2_USE_MMU # fork() depends on !BR2_STATIC_LIBS
Signature · 1 line
1.9.1
RFC PATCH 73/84 package/ndisc6: use 'menuconfig'
In reply to Yann E. MORINndisc6 has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/ndisc6/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/ndisc6/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_NDISC6 +menuconfig BR2_PACKAGE_NDISC6 bool "ndisc6 tools" depends on BR2_USE_MMU # fork() select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
Signature · 1 line
1.9.1
RFC PATCH 74/84 package/netsnmp: use 'menuconfig'
In reply to Yann E. MORINnetsnmp has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/netsnmp/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/netsnmp/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_NETSNMP +menuconfig BR2_PACKAGE_NETSNMP bool "netsnmp" depends on BR2_USE_MMU # fork() help
Signature · 1 line
1.9.1
RFC PATCH 75/84 package/ntp: use 'menuconfig'
In reply to Yann E. MORINntp has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/ntp/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/ntp/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_NTP +menuconfig BR2_PACKAGE_NTP bool "ntp" select BR2_PACKAGE_LIBEVENT help
Signature · 1 line
1.9.1
RFC PATCH 76/84 package/openobex: use 'menuconfig'
In reply to Yann E. MORINopenobex has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/openobex/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/openobex/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_OPENOBEX +menuconfig BR2_PACKAGE_OPENOBEX bool "openobex" help Free open source implementation of the Object Exchange (OBEX)
Signature · 1 line
1.9.1
RFC PATCH 77/84 package/quagga: use 'menuconfig'
In reply to Yann E. MORINquagga has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/quagga/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/quagga/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_QUAGGA +menuconfig BR2_PACKAGE_QUAGGA bool "quagga" depends on BR2_USE_MMU # fork() help
Signature · 1 line
1.9.1
RFC PATCH 78/84 package/transmission: use 'menuconfig'
In reply to Yann E. MORINtransmission has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/transmission/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/transmission/Config.in +2 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_TRANSMISSION +menuconfig BR2_PACKAGE_TRANSMISSION bool "transmission" depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork()
@@ -45,6 +45,7 @@ config BR2_PACKAGE_TRANSMISSION_GTK comment "transmission-gtk needs a toolchain w/ locale" depends on BR2_PACKAGE_LIBGTK2 && !BR2_ENABLE_LOCALE + endif comment "transmission needs a toolchain w/ threads"
Signature · 1 line
1.9.1
RFC PATCH 79/84 package/wpa-supplicant: use 'menuconfig'
In reply to Yann E. MORINwpa-supplicant has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- package/wpa_supplicant/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/wpa_supplicant/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_PACKAGE_WPA_SUPPLICANT +menuconfig BR2_PACKAGE_WPA_SUPPLICANT bool "wpa_supplicant" depends on BR2_USE_MMU # fork() help
Signature · 1 line
1.9.1
RFC PATCH 80/84 boot/at91bootstrap3: use 'menuconfig'
In reply to Yann E. MORINat91bootstrap3 has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- boot/at91bootstrap3/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
boot/at91bootstrap3/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_TARGET_AT91BOOTSTRAP3 +menuconfig BR2_TARGET_AT91BOOTSTRAP3 depends on BR2_arm926t || BR2_cortex_a5 bool "AT91 Bootstrap 3" help
Signature · 1 line
1.9.1
RFC PATCH 80/84 boot/at91bootstrap3: use 'menuconfig'
Quoted 2 lines · Yann E. MORIN
at91bootstrap3 has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
It's a bit weird that at91bootstrap3 has a menu and at91bootstrap doesn't, but OK.
Regards,
Arnout
Quoted 17 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- boot/at91bootstrap3/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)boot/at91bootstrap3/Config.in +1
-1@@ -1,4 +1,4 @@ -config BR2_TARGET_AT91BOOTSTRAP3 +menuconfig BR2_TARGET_AT91BOOTSTRAP3 depends on BR2_arm926t || BR2_cortex_a5 bool "AT91 Bootstrap 3" help
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 81/84 boot/barebox: use 'menuconfig'
In reply to Yann E. MORINbarebox has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- boot/barebox/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
boot/barebox/Config.in +2 -1
@@ -1,4 +1,4 @@ -config BR2_TARGET_BAREBOX +menuconfig BR2_TARGET_BAREBOX bool "Barebox" help The Barebox bootloader, formerly known as U-Boot v2.
@@ -6,6 +6,7 @@ config BR2_TARGET_BAREBOX http://www.barebox.org if BR2_TARGET_BAREBOX + choice prompt "version" help
Signature · 1 line
1.9.1
RFC PATCH 82/84 boot/grub: use 'menuconfig'
In reply to Yann E. MORINgrub has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- boot/grub/Config.in | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
boot/grub/Config.in +3 -7
@@ -1,4 +1,4 @@ -config BR2_TARGET_GRUB +menuconfig BR2_TARGET_GRUB bool "grub" depends on BR2_i386 || BR2_x86_64 select BR2_HOSTARCH_NEEDS_IA32_COMPILER
@@ -52,7 +52,7 @@ config BR2_TARGET_GRUB_DISKLESS help enable diskless support -menu "filesystem drivers" +comment "Filesystem drivers" config BR2_TARGET_GRUB_FS_EXT2 bool "ext2"
@@ -86,9 +86,7 @@ config BR2_TARGET_GRUB_FS_XFS help Enable support for the XFS filesystem in Grub. -endmenu - -menu "network drivers" +comment "Network drivers" config BR2_TARGET_GRUB_3c595 bool "3Com595 driver"
@@ -195,6 +193,4 @@ config BR2_TARGET_GRUB_w89c840 help enable Winbond W89c840 driver -endmenu - endif # BR2_TARGET_GRUB
Signature · 1 line
1.9.1
RFC PATCH 82/84 boot/grub: use 'menuconfig'
Quoted 2 lines · Yann E. MORIN
grub has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
Again, weird that grub has a menu and grub2 doesn't. Perhaps we should give
grub2 a menu as well.
Regards,
Arnout
Quoted 44 lines
Signed-off-by "Yann E. MORIN" <[email protected]>--- boot/grub/Config.in | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)boot/grub/Config.in +3
-7@@ -1,4 +1,4 @@ -config BR2_TARGET_GRUB +menuconfig BR2_TARGET_GRUB bool "grub" depends on BR2_i386 || BR2_x86_64 select BR2_HOSTARCH_NEEDS_IA32_COMPILER@@ -52,7 +52,7 @@ config BR2_TARGET_GRUB_DISKLESS help enable diskless support -menu "filesystem drivers" +comment "Filesystem drivers" config BR2_TARGET_GRUB_FS_EXT2 bool "ext2"@@ -86,9 +86,7 @@ config BR2_TARGET_GRUB_FS_XFS help Enable support for the XFS filesystem in Grub. -endmenu - -menu "network drivers" +comment "Network drivers" config BR2_TARGET_GRUB_3c595 bool "3Com595 driver"@@ -195,6 +193,4 @@ config BR2_TARGET_GRUB_w89c840 help enable Winbond W89c840 driver -endmenu - endif # BR2_TARGET_GRUB
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
RFC PATCH 83/84 boot/mxs-bootlets: use 'menuconfig'
In reply to Yann E. MORINmxs-bootlets has 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- boot/mxs-bootlets/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
boot/mxs-bootlets/Config.in +1 -1
@@ -1,4 +1,4 @@ -config BR2_TARGET_MXS_BOOTLETS +menuconfig BR2_TARGET_MXS_BOOTLETS bool "mxs-bootlets" depends on BR2_arm help
Signature · 1 line
1.9.1
RFC PATCH 84/84 boot/uboot: use 'menuconfig'
In reply to Yann E. MORINuboot has more than 5 options, so use a 'menuconfig' to group the options in an sub-menu.
--- boot/uboot/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
boot/uboot/Config.in +2 -1
@@ -1,9 +1,10 @@ -config BR2_TARGET_UBOOT +menuconfig BR2_TARGET_UBOOT bool "U-Boot" help Build "Das U-Boot" Boot Monitor if BR2_TARGET_UBOOT + choice prompt "Build system" default BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
Signature · 1 line
1.9.1
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
In reply to Yann E. MORINYann,
Quoted 3 lines · Yann E. MORIN
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
I've applied those 6 initial patches, after fixing some really minor typos in the commit log (mainly "lie" -> "like").
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
In reply to Yann E. MORINQuoted 10 lines · Yann E. MORIN
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
Quoted 8 lines
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the
Kconfigkeywords) to automatically arrange the sub-options into sub-menus;- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
I reviewed and tested patches 7-39, you can add my
to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Arnout, All,
On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
Quoted 15 lines · Yann E. MORIN
Quoted 14 lines
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the
Kconfigkeywords) to automatically arrange the sub-options into sub-menus;
Quoted 8 lines
Quoted 4 lines
- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
I reviewed and tested patches 7-39, you can add my
Thank you for the review. I know by experience that reviewing long series can be tedious, so: thanks!
Quoted 2 lines
to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.
Yep, I sent the series as an RFC, just to "feel the temperature of the water".
Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Quoted 23 lines · Yann E. MORIN
Arnout, All,
On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
Quoted 20 lines · Yann E. MORIN
Quoted 18 lines
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the
Kconfigkeywords) to automatically arrange the sub-options into sub-menus;- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
Quoted 6 lines
Quoted 3 lines
I reviewed and tested patches 7-39, you can add my
Thank you for the review. I know by experience that reviewing long series can be tedious, so: thanks!
You can now ack up to and including 58 (libiio).
Quoted 6 lines
Quoted 3 lines
to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.
Yep, I sent the series as an RFC, just to "feel the temperature of the water".
For actual submission, perhaps squash a little here and there. Although in fact
they're not really squashable, except perhaps 41-84 but that would be a pretty big patch.
Regards,
Arnout
Quoted 6 lines
Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Arnout, All,
On 2016-01-02 02:47 +0100, Arnout Vandecappelle spake thusly:
Quoted 22 lines · Yann E. MORIN
Quoted 21 lines
On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
Quoted 20 lines · Yann E. MORIN
Quoted 18 lines
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the
Kconfigkeywords) to automatically arrange the sub-options into sub-menus;- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
I reviewed and tested patches 7-39, you can add my
Thank you for the review. I know by experience that reviewing long series can be tedious, so: thanks!
You can now ack up to and including 58 (libiio).
Great! Thank you very much for having had another look! :-)
(I'll add your ACKs after fixing the little nits here and there you already commented on, like comments to drop...)
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.
Yep, I sent the series as an RFC, just to "feel the temperature of the water".
For actual submission, perhaps squash a little here and there. Although in fact
they're not really squashable, except perhaps 41-84 but that would be a pretty big patch.
Well, and what about my commit count? ;-]
But yeah, I don't think we could squash it, at least during the review. I think it is easier to review a lot of little patches rather than a bit one even if the changes are simple.
Thanks!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
cover all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Quoted 32 lines · Yann E. MORIN
Arnout, All,
On 2016-01-02 02:47 +0100, Arnout Vandecappelle spake thusly:
Quoted 29 lines · Yann E. MORIN
Quoted 27 lines
On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
Quoted 15 lines · Yann E. MORIN
Quoted 14 lines
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the
Kconfigkeywords) to automatically arrange the sub-options into sub-menus;Quoted 8 lines
Quoted 4 lines
- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
I reviewed and tested patches 7-39, you can add my
Thank you for the review. I know by experience that reviewing long series can be tedious, so: thanks!
Quoted 7 lines
Quoted 1 line
You can now ack up to and including 58 (libiio).
Great! Thank you very much for having had another look! :-)
(I'll add your ACKs after fixing the little nits here and there you already commented on, like comments to drop...)
And finally, for patches 59-84:
Thanks for this series, Yann!
Regards,
Arnout
Quoted 21 lines
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.
Yep, I sent the series as an RFC, just to "feel the temperature of the water".
For actual submission, perhaps squash a little here and there. Although in fact
they're not really squashable, except perhaps 41-84 but that would be a pretty big patch.Well, and what about my commit count? ;-]
But yeah, I don't think we could squash it, at least during the review. I think it is easier to review a lot of little patches rather than a bit one even if the changes are simple.
Thanks!
Regards,
Yann E. MORIN.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF