Skip to contentSkip to conversation

libdvbpsi: new package

PATCH Superseded Pieterjan Camerlynck 2 participants 6 messages Dec 30, 2015

lore
Share & tools
lore

Pieterjan Camerlynck

author
#0 lore raw

PATCH 1/1 libdvbpsi: new package

libdvbpsi is a library used by vlc for decoding MPEG TS

Signed-off-by Pieterjan Camerlynck <[email protected]>
---
 package/Config.in                |  1 +
 package/libdvbpsi/Config.in      |  8 ++++++++
 package/libdvbpsi/libdvbpsi.hash |  4 ++++
 package/libdvbpsi/libdvbpsi.mk   | 15 +++++++++++++++
 package/vlc/vlc.mk               |  7 +++++++
 5 files changed, 35 insertions(+)
 create mode 100644 package/libdvbpsi/Config.in
 create mode 100644 package/libdvbpsi/libdvbpsi.hash
 create mode 100644 package/libdvbpsi/libdvbpsi.mk
package/Config.in +1 -0
index bc6099d..5abd9d8 100644
@@ -1015,6 +1015,7 @@ menu "Multimedia"
 	source "package/libbluray/Config.in"
 	source "package/libdcadec/Config.in"
 	source "package/libdvbcsa/Config.in"
+	source "package/libdvbpsi/Config.in"
 	source "package/libdvbsi/Config.in"
 	source "package/libdvdnav/Config.in"
 	source "package/libdvdread/Config.in"
package/libdvbpsi/Config.in new file +8 -0
new file mode 100644
index 0000000..7323466
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBDVBPSI
+	bool "libdvbpsi"
+	help
+	  libdvbpsi is a simple library designed for decoding and
+	  generation of MPEG TS and DVB PSI tables according to standards
+	  ISO/IEC 13818 and ITU-T H.222.0.
+
+	  http://www.videolan.org/developers/libdvbpsi.html
package/libdvbpsi/libdvbpsi.hash new file +4 -0
new file mode 100644
index 0000000..cf76616
@@ -0,0 +1,4 @@
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.md5
+md5	2b217039a1299000c39423441f77e76a	libdvbpsi-1.3.0.tar.bz2
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.sha256
+sha256	a2fed1d11980662f919bbd1f29e2462719e0f6227e1a531310bd5a706db0a1fe	libdvbpsi-1.3.0.tar.bz2
package/libdvbpsi/libdvbpsi.mk new file +15 -0
new file mode 100644
index 0000000..c45ade0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libdvbpsi
+#
+################################################################################
+
+LIBDVBPSI_VERSION = 1.3.0
+LIBDVBPSI_SITE = http://download.videolan.org/pub/libdvbpsi/$(LIBDVBPSI_VERSION)
+LIBDVBPSI_SOURCE = libdvbpsi-$(LIBDVBPSI_VERSION).tar.bz2
+LIBDVBPSI_LICENSE = LGPLv2.1+
+LIBDVBPSI_LICENSE_FILES = COPYING
+LIBDVBPSI_AUTORECONF = YES
+LIBDVBPSI_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
package/vlc/vlc.mk +7 -0
index ca1f09c..ee21c16 100644
@@ -179,6 +179,13 @@ else
 VLC_CONF_OPTS += --disable-libass
 endif
 
+ifeq ($(BR2_PACKAGE_LIBDVBPSI),y)
+VLC_CONF_OPTS += --enable-dvbpsi
+VLC_DEPENDENCIES += libdvbpsi
+else
+VLC_CONF_OPTS += --disable-dvbpsi
+endif
+
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
 VLC_CONF_OPTS += --enable-libgcrypt
 VLC_DEPENDENCIES += libgcrypt
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 libdvbpsi: new package

Hello,

Thanks for this contribution! See some comments below.

Quoted 9 lines · Pieterjan Camerlynck

libdvbpsi is a library used by vlc for decoding MPEG TS

Signed-off-by Pieterjan Camerlynck <[email protected]>
---
 package/Config.in                |  1 +
 package/libdvbpsi/Config.in      |  8 ++++++++
 package/libdvbpsi/libdvbpsi.hash |  4 ++++
 package/libdvbpsi/libdvbpsi.mk   | 15 +++++++++++++++
 package/vlc/vlc.mk               |  7 +++++++

These should be two separate patches:

- One patch adding the libdvbspi package
- One patch adding its use to the vlc package

package/libdvbpsi/Config.in line 2

Quoted 8 lines
package/libdvbpsi/Config.in new file +2 -0
new file mode 100644
index 0000000..7323466
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBDVBPSI
+	bool "libdvbpsi"

No toolchain dependencies on threads, MMU or anything like that? It is possible indeed, but if you could verify building this library with the following toolchain configurations, it would be useful:

http://autobuild.buildroot.org/toolchains/configs/bfin-uclinux.config
http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config
http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config

Quoted 8 lines
package/libdvbpsi/libdvbpsi.mk new file +2 -0
new file mode 100644
index 0000000..c45ade0
@@ -0,0 +1,15 @@
+################################################################################
+#

package/libdvbpsi/libdvbpsi.mk line 12

Quoted 10 lines
package/libdvbpsi/libdvbpsi.mk new file +10 -0
+# libdvbpsi
+#
+################################################################################
+
+LIBDVBPSI_VERSION = 1.3.0
+LIBDVBPSI_SITE = http://download.videolan.org/pub/libdvbpsi/$(LIBDVBPSI_VERSION)
+LIBDVBPSI_SOURCE = libdvbpsi-$(LIBDVBPSI_VERSION).tar.bz2
+LIBDVBPSI_LICENSE = LGPLv2.1+
+LIBDVBPSI_LICENSE_FILES = COPYING
+LIBDVBPSI_AUTORECONF = YES

Why do you need the autoreconf ? There is a pre-generated configure script in the tarball, so it should be necessary. If it is necessary for some reason, could you add a comment above this line explaining why?

Other than that, looks good. Could you send an updated version that takes into account those comments ?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v2 1/2 libdvbpsi: new package

In reply to Pieterjan Camerlynck

libdvbpsi is a library used by vlc for decoding MPEG TS

Signed-off-by Pieterjan Camerlynck <[email protected]>

---
Changes v1->v2
- split adding and using libdvbpsi in two separate patches
- add missing dependency on threads
- remove autoreconf

---
 package/Config.in                |  1 +
 package/libdvbpsi/Config.in      |  9 +++++++++
 package/libdvbpsi/libdvbpsi.hash |  4 ++++
 package/libdvbpsi/libdvbpsi.mk   | 14 ++++++++++++++
 4 files changed, 28 insertions(+)
 create mode 100644 package/libdvbpsi/Config.in
 create mode 100644 package/libdvbpsi/libdvbpsi.hash
 create mode 100644 package/libdvbpsi/libdvbpsi.mk
package/Config.in +1 -0
index cf994b8..0d77292 100644
@@ -1015,6 +1015,7 @@ menu "Multimedia"
 	source "package/libbluray/Config.in"
 	source "package/libdcadec/Config.in"
 	source "package/libdvbcsa/Config.in"
+	source "package/libdvbpsi/Config.in"
 	source "package/libdvbsi/Config.in"
 	source "package/libdvdnav/Config.in"
 	source "package/libdvdread/Config.in"
package/libdvbpsi/Config.in new file +9 -0
new file mode 100644
index 0000000..2a27964
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBDVBPSI
+	bool "libdvbpsi"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  libdvbpsi is a simple library designed for decoding and
+	  generation of MPEG TS and DVB PSI tables according to standards
+	  ISO/IEC 13818 and ITU-T H.222.0.
+
+	  http://www.videolan.org/developers/libdvbpsi.html
package/libdvbpsi/libdvbpsi.hash new file +4 -0
new file mode 100644
index 0000000..cf76616
@@ -0,0 +1,4 @@
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.md5
+md5	2b217039a1299000c39423441f77e76a	libdvbpsi-1.3.0.tar.bz2
+# From http://download.videolan.org/pub/libdvbpsi/1.3.0/libdvbpsi-1.3.0.tar.bz2.sha256
+sha256	a2fed1d11980662f919bbd1f29e2462719e0f6227e1a531310bd5a706db0a1fe	libdvbpsi-1.3.0.tar.bz2
package/libdvbpsi/libdvbpsi.mk new file +14 -0
new file mode 100644
index 0000000..218c19e
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libdvbpsi
+#
+################################################################################
+
+LIBDVBPSI_VERSION = 1.3.0
+LIBDVBPSI_SITE = http://download.videolan.org/pub/libdvbpsi/$(LIBDVBPSI_VERSION)
+LIBDVBPSI_SOURCE = libdvbpsi-$(LIBDVBPSI_VERSION).tar.bz2
+LIBDVBPSI_LICENSE = LGPLv2.1+
+LIBDVBPSI_LICENSE_FILES = COPYING
+LIBDVBPSI_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH v2 2/2 vlc: add support for libdvbpsi

Signed-off-by Pieterjan Camerlynck <[email protected]>
---
 package/vlc/vlc.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/vlc/vlc.mk +7 -0
index ca1f09c..ee21c16 100644
@@ -179,6 +179,13 @@ else
 VLC_CONF_OPTS += --disable-libass
 endif
 
+ifeq ($(BR2_PACKAGE_LIBDVBPSI),y)
+VLC_CONF_OPTS += --enable-dvbpsi
+VLC_DEPENDENCIES += libdvbpsi
+else
+VLC_CONF_OPTS += --disable-dvbpsi
+endif
+
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
 VLC_CONF_OPTS += --enable-libgcrypt
 VLC_DEPENDENCIES += libgcrypt
Signature · 1 line
1.9.1
Applied
#4 lore raw

PATCH v2 2/2 vlc: add support for libdvbpsi

Dear Pieterjan Camerlynck,

Quoted 4 lines · Pieterjan Camerlynck
Signed-off-by Pieterjan Camerlynck <[email protected]>
---
 package/vlc/vlc.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH v2 1/2 libdvbpsi: new package

In reply to Pieterjan Camerlynck

Dear Pieterjan Camerlynck,

Quoted 6 lines · Pieterjan Camerlynck
package/libdvbpsi/Config.in new file +0 -0
new file mode 100644
index 0000000..2a27964

package/libdvbpsi/Config.in line 9

Quoted 9 lines
package/libdvbpsi/Config.in new file +9 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBDVBPSI
+	bool "libdvbpsi"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  libdvbpsi is a simple library designed for decoding and
+	  generation of MPEG TS and DVB PSI tables according to standards
+	  ISO/IEC 13818 and ITU-T H.222.0.
+
+	  http://www.videolan.org/developers/libdvbpsi.html

You forgot the Config.in comment here about the thread dependency.

I've added it and applied your patch. Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com