u-boot-usb/master

GIT PULL Marek Vasut 2 participants 6 messages Dec 31, 2015 – Jan 4, 2016

lore

Share & tools

lore

Marek Vasut

author

2015-12-31 09:30 UTC #0 lore raw

The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:

Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 09:15:57
-0500)

are available in the git repository at:

git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to f3643fe7d0dcd8a799fe8882db0903b3477e6338:

usb: musb: Fix hub port setting for SPLIT transactions (2015-12-31 10:05:32
+0100)

----------------------------------------------------------------
Stefan Br?ns (4):
usb: Alloc buffer for USB descriptor dynamically
usb: dwc2: avoid out of bounds access
usb: Move determination of TT hub address/port into separate function
usb: musb: Fix hub port setting for SPLIT transactions

 common/usb.c                      | 98 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------
 drivers/usb/host/dwc2.c           |  7 ++++---
 drivers/usb/host/ehci-hcd.c       | 50 
+++++---------------------------------------------
 drivers/usb/musb-new/musb_host.c  | 10 +++++++---
 drivers/usb/musb-new/usb-compat.h | 53 
-----------------------------------------------------
 include/usb.h                     | 17 +++++++++++++++--
 6 files changed, 115 insertions(+), 120 deletions(-)

Tom Rini

2015-12-31 13:41 UTC #1 lore raw

Quoted 14 lines · Marek Vasut

The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:
Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 09:15:57
-0500)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to f3643fe7d0dcd8a799fe8882db0903b3477e6338:
usb: musb: Fix hub port setting for SPLIT transactions (2015-12-31 10:05:32
+0100)

Quoted 6 lines

----------------------------------------------------------------
Stefan Br?ns (4):
usb: Alloc buffer for USB descriptor dynamically
usb: dwc2: avoid out of bounds access
usb: Move determination of TT hub address/port into separate function
usb: musb: Fix hub port setting for SPLIT transactions

It looks like nearly everything is failing with:
+(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c: In function 'ehci_update_endpt2_dev_n_port':
+(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c:290:2: error: expected ';' before 'qh'
+(T1024RDB_SPIFLASH) qh->qh_endpt2 |= cpu_to_hc32(QH_ENDPT2_PORTNUM(portnr) |
+(T1024RDB_SPIFLASH) ^
+(T1024RDB_SPIFLASH) make[2]: *** [drivers/usb/host/ehci-hcd.o] Error 1 +(T1024RDB_SPIFLASH) make[1]: *** [drivers/usb/host] Error 2
+(T1024RDB_SPIFLASH) make: *** [sub-make] Error 2

mx6dlarm2 is another one, if you don't have powerpc toolchain handy.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151231/fc99899e/attachment.sig>

Marek Vasut

author

2015-12-31 15:17 UTC #2 lore raw

Quoted 34 lines · Tom Rini

Quoted 15 lines · Marek Vasut
The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:
Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 09:15:57
-0500)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to f3643fe7d0dcd8a799fe8882db0903b3477e6338:
usb: musb: Fix hub port setting for SPLIT transactions (2015-12-31 10:05:32
+0100)
Quoted 7 lines
----------------------------------------------------------------
Stefan Br?ns (4):
usb: Alloc buffer for USB descriptor dynamically
usb: dwc2: avoid out of bounds access
usb: Move determination of TT hub address/port into separate function usb: musb: Fix hub port setting for SPLIT transactions
It looks like nearly everything is failing with:
+(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c: In function 'ehci_update_endpt2_dev_n_port': +(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c:290:2: error: expected ';' before 'qh'
+(T1024RDB_SPIFLASH) qh->qh_endpt2 |=
cpu_to_hc32(QH_ENDPT2_PORTNUM(portnr) | +(T1024RDB_SPIFLASH) ^
(quoted diff) +3 -0
+(T1024RDB_SPIFLASH) make[2]: *** [drivers/usb/host/ehci-hcd.o] Error 1
+(T1024RDB_SPIFLASH) make[1]: *** [drivers/usb/host] Error 2
+(T1024RDB_SPIFLASH) make: *** [sub-make] Error 2

Quoted 1 line

mx6dlarm2 is another one, if you don't have powerpc toolchain handy.

I should stop trusting people that they even compile-tested their patches :-( Well, please pull again, I fixed the patch and pushed again ...

Best regards,
Marek Vasut

Tom Rini

2016-01-02 17:06 UTC #3 lore raw

Quoted 35 lines · Marek Vasut

Quoted 34 lines · Tom Rini
Quoted 15 lines · Marek Vasut
The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:
Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 09:15:57
-0500)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to f3643fe7d0dcd8a799fe8882db0903b3477e6338:
usb: musb: Fix hub port setting for SPLIT transactions (2015-12-31 10:05:32
+0100)
Quoted 7 lines
----------------------------------------------------------------
Stefan Br?ns (4):
usb: Alloc buffer for USB descriptor dynamically
usb: dwc2: avoid out of bounds access
usb: Move determination of TT hub address/port into separate function usb: musb: Fix hub port setting for SPLIT transactions
It looks like nearly everything is failing with:
+(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c: In function 'ehci_update_endpt2_dev_n_port': +(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c:290:2: error: expected ';' before 'qh'
+(T1024RDB_SPIFLASH) qh->qh_endpt2 |=
cpu_to_hc32(QH_ENDPT2_PORTNUM(portnr) | +(T1024RDB_SPIFLASH) ^
(quoted diff) +3 -0
+(T1024RDB_SPIFLASH) make[2]: *** [drivers/usb/host/ehci-hcd.o] Error 1
+(T1024RDB_SPIFLASH) make[1]: *** [drivers/usb/host] Error 2
+(T1024RDB_SPIFLASH) make: *** [sub-make] Error 2

Quoted 4 lines

Quoted 1 line
mx6dlarm2 is another one, if you don't have powerpc toolchain handy.
I should stop trusting people that they even compile-tested their patches :-( Well, please pull again, I fixed the patch and pushed again ...

And this is really just bugfixes rather than new functionality that can wait? Thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160102/16f9f4a2/attachment.sig>

Marek Vasut

author

2016-01-02 17:14 UTC #4 lore raw

Quoted 4 lines · Tom Rini

Quoted 3 lines · Marek Vasut
Quoted 2 lines · Tom Rini
Quoted 1 line · Marek Vasut
The following changes since commit

78680314c53a95c0bb25e942662979843b60d7b9:

Quoted 32 lines

Quoted 32 lines
Quoted 32 lines
Quoted 14 lines
Merge branch 'master' of http://git.denx.de/u-boot-sunxi
(2015-12-27 09:15:57
-0500)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to f3643fe7d0dcd8a799fe8882db0903b3477e6338:
usb: musb: Fix hub port setting for SPLIT transactions (2015-12-31 10:05:32
+0100)
Quoted 7 lines
----------------------------------------------------------------
Stefan Br?ns (4):
usb: Alloc buffer for USB descriptor dynamically
usb: dwc2: avoid out of bounds access
usb: Move determination of TT hub address/port into separate function usb: musb: Fix hub port setting for SPLIT transactions
It looks like nearly everything is failing with:
+(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c: In function 'ehci_update_endpt2_dev_n_port': +(T1024RDB_SPIFLASH) ../drivers/usb/host/ehci-hcd.c:290:2: error: expected ';' before 'qh'
+(T1024RDB_SPIFLASH) qh->qh_endpt2 |=
cpu_to_hc32(QH_ENDPT2_PORTNUM(portnr) | +(T1024RDB_SPIFLASH) ^
(quoted diff) +3 -0
+(T1024RDB_SPIFLASH) make[2]: *** [drivers/usb/host/ehci-hcd.o] Error 1
+(T1024RDB_SPIFLASH) make[1]: *** [drivers/usb/host] Error 2
+(T1024RDB_SPIFLASH) make: *** [sub-make] Error 2

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
mx6dlarm2 is another one, if you don't have powerpc toolchain handy.
I should stop trusting people that they even compile-tested their patches :-( Well, please pull again, I fixed the patch and pushed again ...
And this is really just bugfixes rather than new functionality that can wait? Thanks!

Cleanup and bugfixes. There is no significant new functionality, so I think this is safe to apply.

Best regards,
Marek Vasut

Tom Rini

2016-01-04 15:50 UTC #5 lore raw

In reply to Marek Vasut

Quoted 5 lines · Marek Vasut

The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:
Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 09:15:57
-0500)

Quoted 9 lines

are available in the git repository at:
git://git.denx.de/u-boot-usb.git master
for you to fetch changes up to f3643fe7d0dcd8a799fe8882db0903b3477e6338:
usb: musb: Fix hub port setting for SPLIT transactions (2015-12-31 10:05:32
+0100)

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/b126cd0c/attachment.sig>