Skip to contentSkip to conversation

ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver

PATCH In review Pali Rohár 5 participants 10 messages Dec 25, 2015 – Jan 27, 2016 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver

Driver for omap3 with documentation is there since v4.4-rc1.

---
 arch/arm/boot/dts/omap34xx.dtsi |    5 +++++
 arch/arm/boot/dts/omap36xx.dtsi |    5 +++++
 2 files changed, 10 insertions(+)
arch/arm/boot/dts/omap34xx.dtsi +5 -0
index 4f6b2d5..c3f488f 100644
@@ -54,6 +54,11 @@
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap34xx-bandgap";
+		};
 	};
 };
 
arch/arm/boot/dts/omap36xx.dtsi +5 -0
index 86253de..00f98c1 100644
@@ -86,6 +86,11 @@
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap36xx-bandgap";
+		};
 	};
 };
 
Signature · 1 line
1.7.9.5
#2 lore raw
In reply to Pali Rohár

Hello,

Quoted 31 lines · Pali Roh?r

Driver for omap3 with documentation is there since v4.4-rc1.

---
 arch/arm/boot/dts/omap34xx.dtsi |    5 +++++
 arch/arm/boot/dts/omap36xx.dtsi |    5 +++++
 2 files changed, 10 insertions(+)
arch/arm/boot/dts/omap34xx.dtsi +5 -0
index 4f6b2d5..c3f488f 100644
@@ -54,6 +54,11 @@
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap34xx-bandgap";
+		};
 	};
 };
 
arch/arm/boot/dts/omap36xx.dtsi +0 -0
index 86253de..00f98c1 100644

arch/arm/boot/dts/omap36xx.dtsi line 92

Quoted 7 lines
arch/arm/boot/dts/omap36xx.dtsi +4 -0
@@ -86,6 +86,11 @@
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap36xx-bandgap";

Can you please already add on both cases

#thermal-sensor-cells = <0>;
?

This way we can already use them to define thermal zones. Of course, that alone won't add the thermal zones. A separated patch would be needed to add the thermal zone for OMAP3.

Quoted 7 lines
arch/arm/boot/dts/omap36xx.dtsi +1 -0
+		};
 	};
 };
 
Signature · 1 line
1.7.9.5
#3 lore raw
Quoted 7 lines · On Thursday 31 December 2015 09:38:45 Eduardo Valentin wrote:

arch/arm/boot/dts/omap36xx.dtsi line 92

Quoted 4 lines
arch/arm/boot/dts/omap36xx.dtsi +4 -0
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap36xx-bandgap";

Can you please already add on both cases

Quoted 6 lines

#thermal-sensor-cells = <0>;
?

This way we can already use them to define thermal zones. Of course, that alone won't add the thermal zones. A separated patch would be needed to add the thermal zone for OMAP3.

Are you going to add thermal zone defines? If yes, then it would make sense to add that #thermal line together with thermal zone defines...

Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
#4 lore raw
In reply to Pali Rohár
Quoted 30 lines · On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:

Driver for omap3 with documentation is there since v4.4-rc1.

---
 arch/arm/boot/dts/omap34xx.dtsi |    5 +++++
 arch/arm/boot/dts/omap36xx.dtsi |    5 +++++
 2 files changed, 10 insertions(+)
arch/arm/boot/dts/omap34xx.dtsi +5 -0
index 4f6b2d5..c3f488f 100644
@@ -54,6 +54,11 @@
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap34xx-bandgap";
+		};
 	};
 };
 
arch/arm/boot/dts/omap36xx.dtsi +0 -0
index 86253de..00f98c1 100644
@@ -86,6 +86,11 @@
 				#size-cells = <0>;

arch/arm/boot/dts/omap36xx.dtsi line 96

Quoted 10 lines
arch/arm/boot/dts/omap36xx.dtsi +5 -0
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap36xx-bandgap";
+		};
 	};
 };
 

PING! Who can take this patch?

Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
#5 lore raw
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:

Driver for omap3 with documentation is there since v4.4-rc1.

...

Quoted 1 line

PING! Who can take this patch?

Sounds like /me, but after -rc1 when any possible regressions are out of the way :)

Regards,

Tony

#6 lore raw
Quoted 9 lines · On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:

Driver for omap3 with documentation is there since v4.4-rc1.

...

Quoted 1 line

PING! Who can take this patch?

Sounds like /me, but after -rc1 when any possible regressions are out of the way :)

Great! Just to note that 4.5-rc1 is out.

I just do not want to see this patch lost...

Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
#7 lore raw
Quoted 6 lines · Pali Roh?r
Quoted 5 lines · On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:

Driver for omap3 with documentation is there since v4.4-rc1.

...

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

PING! Who can take this patch?

Sounds like /me, but after -rc1 when any possible regressions are out of the way :)

Great! Just to note that 4.5-rc1 is out.

I just do not want to see this patch lost...

So is this critical to have as a fix since it's thermal related?

Regards,

Tony

#8 lore raw

Hi,

Quoted 9 lines · Tony Lindgren
Quoted 8 lines · Pali Roh?r
Quoted 7 lines · On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:

Driver for omap3 with documentation is there since v4.4-rc1.

...

Quoted 1 line

PING! Who can take this patch?

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Sounds like /me, but after -rc1 when any possible regressions are out of the way :)

Great! Just to note that 4.5-rc1 is out.

I just do not want to see this patch lost...

So is this critical to have as a fix since it's thermal related?

According to somebody from TI, who previously took part in the patch discussion, the thermal sensors of omap3 are to imprecise to be used for thermal decisions. The driver "just" informs userspace about the temperatures.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/9920a723/attachment.sig>

#9 lore raw
Quoted 17 lines · Sebastian Reichel

Hi,

Quoted 14 lines · Tony Lindgren
Quoted 13 lines · Pali Roh?r
Quoted 9 lines · On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:

Driver for omap3 with documentation is there since v4.4-rc1.

...

Quoted 1 line

PING! Who can take this patch?

Sounds like /me, but after -rc1 when any possible regressions are out of the way :)

Great! Just to note that 4.5-rc1 is out.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

I just do not want to see this patch lost...

So is this critical to have as a fix since it's thermal related?

According to somebody from TI, who previously took part in the patch discussion, the thermal sensors of omap3 are to imprecise to be used for thermal decisions. The driver "just" informs userspace about the temperatures.

OK applying into omap-for-v4.6/dt then thanks.

Tony