MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
PATCH 1/1 MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
--- MAINTAINERS | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
MAINTAINERS +8 -2
@@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS M: Pali Rohár <[email protected]> S: Maintained F: include/linux/power/bq2415x_charger.h -F: include/linux/power/bq27xxx_battery.h F: include/linux/power/isp1704_charger.h F: drivers/power/bq2415x_charger.c -F: drivers/power/bq27xxx_battery.c F: drivers/power/isp1704_charger.c F: drivers/power/rx51_battery.c
@@ -10710,6 +10708,14 @@ L: [email protected] S: Maintained F: drivers/thermal/ti-soc-thermal/ +TI BQ27XXX POWER SUPPLY DRIVER +M: Pali Rohár <[email protected]> +R: Andrew F. Davis <[email protected]> +S: Maintained +F: include/linux/power/bq27xxx_battery.h +F: drivers/power/bq27xxx_battery.c +F: drivers/power/bq27xxx_battery_i2c.c + TI CDCE706 CLOCK DRIVER M: Max Filippov <[email protected]> S: Maintained
Signature · 1 line
2.6.4
Quoted 10 lines · On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
Signed-off-by Andrew F. Davis <[email protected]>--- MAINTAINERS | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)MAINTAINERS +0
-0
MAINTAINERS NOKIA N900 POWER SUPPLY DRIVERS · line 7612
Quoted 10 lines
MAINTAINERS +0
-2@@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS M: Pali Rohár <[email protected]> S: Maintained F: include/linux/power/bq2415x_charger.h -F: include/linux/power/bq27xxx_battery.h F: include/linux/power/isp1704_charger.h F: drivers/power/bq2415x_charger.c -F: drivers/power/bq27xxx_battery.c F: drivers/power/isp1704_charger.c F: drivers/power/rx51_battery.c
I think it is not needed to remove files from this section as here are all power supply files for Nokia N900.
Quoted 15 lines
MAINTAINERS +8
-0@@ -10710,6 +10708,14 @@ L: [email protected] S: Maintained F: drivers/thermal/ti-soc-thermal/ +TI BQ27XXX POWER SUPPLY DRIVER +M: Pali Rohár <[email protected]> +R: Andrew F. Davis <[email protected]> +S: Maintained +F: include/linux/power/bq27xxx_battery.h +F: drivers/power/bq27xxx_battery.c +F: drivers/power/bq27xxx_battery_i2c.c + TI CDCE706 CLOCK DRIVER M: Max Filippov <[email protected]> S: Maintained
Signature · 2 lines
Pali Rohár [email protected]
Hi,
Quoted 28 lines · Pali Rohár
Quoted 10 lines · On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
Signed-off-by Andrew F. Davis <[email protected]>--- MAINTAINERS | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)MAINTAINERS +0
-0MAINTAINERS NOKIA N900 POWER SUPPLY DRIVERS · line 7611
Quoted 9 lines
MAINTAINERS +0
-2@@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS M: Pali Rohár <[email protected]> S: Maintained F: include/linux/power/bq2415x_charger.h -F: include/linux/power/bq27xxx_battery.h F: include/linux/power/isp1704_charger.h F: drivers/power/bq2415x_charger.c -F: drivers/power/bq27xxx_battery.c F: drivers/power/isp1704_charger.c F: drivers/power/rx51_battery.cI think it is not needed to remove files from this section as here are all power supply files for Nokia N900.
Quoted 4 lines
MAINTAINERS +0
-0@@ -10710,6 +10708,14 @@ L: [email protected] S: Maintained F: drivers/thermal/ti-soc-thermal/
Quoted 7 lines
MAINTAINERS L: [email protected] · line 10717
Quoted 7 lines
MAINTAINERS +7
-0+TI BQ27XXX POWER SUPPLY DRIVER +M: Pali Rohár <[email protected]> +R: Andrew F. Davis <[email protected]> +S: Maintained +F: include/linux/power/bq27xxx_battery.h +F: drivers/power/bq27xxx_battery.c +F: drivers/power/bq27xxx_battery_i2c.c
I think it would make sense to have it like this:
NOKIA N900 POWER SUPPLY DRIVERS
+R: Pali Rohár <[email protected]>
-M: Pali Rohár <[email protected]>
-S: Maintained
F: include/linux/power/bq2415x_charger.h
F: include/linux/power/bq27xxx_battery.h
F: include/linux/power/isp1704_charger.h
F: drivers/power/bq2415x_charger.c
F: drivers/power/bq27xxx_battery.c
F: drivers/power/isp1704_charger.c
F: drivers/power/rx51_battery.c
+TI BQ27XXX POWER SUPPLY DRIVER
+R: Andrew F. Davis <[email protected]>
+F: include/linux/power/bq27xxx_battery.h
+F: drivers/power/bq27xxx_battery.c
+F: drivers/power/bq27xxx_battery_i2c.c
+
POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M: Sebastian Reichel <[email protected]>
M: Dmitry Eremin-Solenikov <[email protected]>
M: David Woodhouse <[email protected]>
L: [email protected]
T: git git://git.infradead.org/battery-2.6.git
S: Maintained
F: include/linux/power_supply.h
F: drivers/power/
X: drivers/power/avs/
This would result in the following get_maintainer.pl output for the bq27xxx driver.
sre@earth ~/src/linux [n950] % ./scripts/get_maintainer.pl -f drivers/power/bq27xxx_battery.c "Andrew F. Davis" <[email protected]> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER)
"Pali Rohár" <[email protected]> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS) Sebastian Reichel <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) David Woodhouse <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) [email protected] (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) [email protected] (open list)
Pali, what do you think about the reviewer/maintainer change? I think it makes it more clear, that the patches are queued in the battery tree. If you think its a downgrade I don't mind not changing it, though.
-- Sebastian
Quoted 92 lines · On Thursday 31 December 2015 22:06:38 Sebastian Reichel wrote:
Hi,
Quoted 35 lines · Pali Rohár
Quoted 15 lines · On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
Signed-off-by Andrew F. Davis <[email protected]>---
MAINTAINERS | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)MAINTAINERS +0
-0@@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS M: Pali Rohár <[email protected]> S: Maintained F: include/linux/power/bq2415x_charger.hMAINTAINERS NOKIA N900 POWER SUPPLY DRIVERS
Quoted 10 lines
MAINTAINERS +0
-2-F: include/linux/power/bq27xxx_battery.h F: include/linux/power/isp1704_charger.h F: drivers/power/bq2415x_charger.c -F: drivers/power/bq27xxx_battery.c F: drivers/power/isp1704_charger.c F: drivers/power/rx51_battery.cI think it is not needed to remove files from this section as here are all power supply files for Nokia N900.
Quoted 5 lines
MAINTAINERS +0
-0@@ -10710,6 +10708,14 @@ L: [email protected] S: Maintained F: drivers/thermal/ti-soc-thermal/Quoted 7 lines
MAINTAINERS L: [email protected] · line 10717
Quoted 7 lines
MAINTAINERS +7
-0+TI BQ27XXX POWER SUPPLY DRIVER +M: Pali Rohár <[email protected]> +R: Andrew F. Davis <[email protected]> +S: Maintained +F: include/linux/power/bq27xxx_battery.h +F: drivers/power/bq27xxx_battery.c +F: drivers/power/bq27xxx_battery_i2c.cI think it would make sense to have it like this:
NOKIA N900 POWER SUPPLY DRIVERS
(quoted diff) +1
-2+R: Pali Rohár <[email protected]> -M: Pali Rohár <[email protected]> -S: MaintainedF:
include/linux/power/bq2415x_charger.h
F:include/linux/power/bq27xxx_battery.h
F:include/linux/power/isp1704_charger.h
F:drivers/power/bq2415x_charger.c
F:drivers/power/bq27xxx_battery.c
F:drivers/power/isp1704_charger.c
F:drivers/power/rx51_battery.cMAINTAINERS +6
-0+TI BQ27XXX POWER SUPPLY DRIVER +R: Andrew F. Davis <[email protected]> +F: include/linux/power/bq27xxx_battery.h +F: drivers/power/bq27xxx_battery.c +F: drivers/power/bq27xxx_battery_i2c.c +POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M: Sebastian Reichel <[email protected]>
M: Dmitry Eremin-Solenikov <[email protected]>
M: David Woodhouse <[email protected]>
L: [email protected]
T: gitgit://git.infradead.org/battery-2.6.git
S: Maintained
F:include/linux/power_supply.h
F:drivers/power/
X:drivers/power/avs/This would result in the following get_maintainer.pl output for the bq27xxx driver.
sre@earth ~/src/linux [n950] %
./scripts/get_maintainer.pl-fdrivers/power/bq27xxx_battery.c"Andrew F. Davis" <[email protected]> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER) "Pali Rohár" <[email protected]> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS) Sebastian Reichel <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) David Woodhouse <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) [email protected] (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) [email protected] (open list)
Quoted 6 lines
Pali, what do you think about the reviewer/maintainer change? I think it makes it more clear, that the patches are queued in the battery tree. If you think its a downgrade I don't mind not changing it, though.
-- Sebastian
Change is OK for me.
Signature · 2 lines
Pali Rohár [email protected]
Quoted 49 lines · On Thursday 31 December 2015 22:11:32 Pali Rohár wrote:
Quoted 48 lines · On Thursday 31 December 2015 22:06:38 Sebastian Reichel wrote:
Hi,
I think it would make sense to have it like this:
NOKIA N900 POWER SUPPLY DRIVERS
(quoted diff) +1
-2+R: Pali Rohár <[email protected]> -M: Pali Rohár <[email protected]> -S: MaintainedF:
include/linux/power/bq2415x_charger.h
F:include/linux/power/bq27xxx_battery.h
F:include/linux/power/isp1704_charger.h
F:drivers/power/bq2415x_charger.c
F:drivers/power/bq27xxx_battery.c
F:drivers/power/isp1704_charger.c
F:drivers/power/rx51_battery.cMAINTAINERS +6
-0+TI BQ27XXX POWER SUPPLY DRIVER +R: Andrew F. Davis <[email protected]> +F: include/linux/power/bq27xxx_battery.h +F: drivers/power/bq27xxx_battery.c +F: drivers/power/bq27xxx_battery_i2c.c +POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M: Sebastian Reichel <[email protected]>
M: Dmitry Eremin-Solenikov <[email protected]>
M: David Woodhouse <[email protected]>
L: [email protected]
T: gitgit://git.infradead.org/battery-2.6.git
S: Maintained
F:include/linux/power_supply.h
F:drivers/power/
X:drivers/power/avs/This would result in the following get_maintainer.pl output for the bq27xxx driver.
sre@earth ~/src/linux [n950] %
./scripts/get_maintainer.pl-fdrivers/power/bq27xxx_battery.c"Andrew F. Davis" <[email protected]> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER) "Pali Rohár" <[email protected]> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS) Sebastian Reichel <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) David Woodhouse <[email protected]> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) [email protected] (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) [email protected] (open list)
Quoted 9 lines
Quoted 6 lines
Pali, what do you think about the reviewer/maintainer change? I think it makes it more clear, that the patches are queued in the battery tree. If you think its a downgrade I don't mind not changing it, though.
-- Sebastian
Change is OK for me.
Sebastian, one one minor change to your patch:
Add bq27xxx_battery_i2c.c file into NOKIA N900 POWER SUPPLY DRIVERS section as now bq27200 code is split into two files...
Signature · 2 lines
Pali Rohár [email protected]