Skip to contentSkip to conversation

openipmi: add OPENIPMI_VERSION_MAJOR variable

PATCH New Jerzy Grzegorek 4 participants 4 messages Dec 31, 2015 – Jan 1, 2016

lore
Share & tools
lore

Jerzy Grzegorek

author
#0 lore raw

PATCH 1/1 openipmi: add OPENIPMI_VERSION_MAJOR variable

Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/openipmi/openipmi.mk | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
package/openipmi/openipmi.mk +4 -3
index 85bd6b4..3b9c49f 100644
@@ -4,9 +4,10 @@
 #
 ################################################################################
 
-OPENIPMI_VERSION = 2.0.21
-OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%202.0%20Library
-OPENIPMI_SOURCE = OpenIPMI-2.0.21.tar.gz
+OPENIPMI_VERSION_MAJOR = 2.0
+OPENIPMI_VERSION = $(OPENIPMI_VERSION_MAJOR).21
+OPENIPMI_SOURCE = OpenIPMI-$(OPENIPMI_VERSION).tar.gz
+OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%20$(OPENIPMI_VERSION_MAJOR)%20Library
 OPENIPMI_LICENSE = LGPLv2+, GPLv2+, BSD-3c
 OPENIPMI_LICENSE_FILES = COPYING.LIB COPYING COPYING.BSD
 OPENIPMI_DEPENDENCIES = popt ncurses host-pkgconf
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 openipmi: add OPENIPMI_VERSION_MAJOR variable

Jerzy,

package/openipmi/openipmi.mk line 10

Quoted 7 lines · Jerzy Grzegorek
package/openipmi/openipmi.mk +4 -3
-OPENIPMI_VERSION = 2.0.21
-OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%202.0%20Library
-OPENIPMI_SOURCE = OpenIPMI-2.0.21.tar.gz
+OPENIPMI_VERSION_MAJOR = 2.0
+OPENIPMI_VERSION = $(OPENIPMI_VERSION_MAJOR).21
+OPENIPMI_SOURCE = OpenIPMI-$(OPENIPMI_VERSION).tar.gz
+OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%20$(OPENIPMI_VERSION_MAJOR)%20Library

I believe this is going a bit too far because what's encoded in the URL here is not really the "major version", but the name of the project, which is "OpenIPMI 2.0 Library".

So in this case, I don't think using the _VERSION_MAJOR thing is really appropriate.

Let's see what others think about it.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 openipmi: add OPENIPMI_VERSION_MAJOR variable

Quoted 16 lines · Thomas Petazzoni

Jerzy,

package/openipmi/openipmi.mk line 10

Quoted 7 lines · Jerzy Grzegorek
package/openipmi/openipmi.mk +4 -3
-OPENIPMI_VERSION = 2.0.21
-OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%202.0%20Library
-OPENIPMI_SOURCE = OpenIPMI-2.0.21.tar.gz
+OPENIPMI_VERSION_MAJOR = 2.0
+OPENIPMI_VERSION = $(OPENIPMI_VERSION_MAJOR).21
+OPENIPMI_SOURCE = OpenIPMI-$(OPENIPMI_VERSION).tar.gz
+OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%20$(OPENIPMI_VERSION_MAJOR)%20Library

I believe this is going a bit too far because what's encoded in the URL here is not really the "major version", but the name of the project, which is "OpenIPMI 2.0 Library".

Quoted 4 lines

So in this case, I don't think using the _VERSION_MAJOR thing is really appropriate.

Let's see what others think about it.

I don't care much either way. In general, I'm not too impressed with the
introduction of _VERSION_MAJOR variables, because IMHO it doesn't simplify things at all. The idea is that it would be easier to bump the version, but in all likelihood, when the major version changes, you have bigger problems to deal with than just having to change things in two places.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH 1/1 openipmi: add OPENIPMI_VERSION_MAJOR variable

Arnout, Thomas, Jerzy, All,

On 2015-12-31 11:13 +0100, Arnout Vandecappelle spake thusly:

Quoted 17 lines · Thomas Petazzoni
Quoted 16 lines · Jerzy Grzegorek

package/openipmi/openipmi.mk line 10

Quoted 7 lines
package/openipmi/openipmi.mk +4 -3
-OPENIPMI_VERSION = 2.0.21
-OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%202.0%20Library
-OPENIPMI_SOURCE = OpenIPMI-2.0.21.tar.gz
+OPENIPMI_VERSION_MAJOR = 2.0
+OPENIPMI_VERSION = $(OPENIPMI_VERSION_MAJOR).21
+OPENIPMI_SOURCE = OpenIPMI-$(OPENIPMI_VERSION).tar.gz
+OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%20$(OPENIPMI_VERSION_MAJOR)%20Library

I believe this is going a bit too far because what's encoded in the URL here is not really the "major version", but the name of the project, which is "OpenIPMI 2.0 Library".

So in this case, I don't think using the _VERSION_MAJOR thing is really appropriate.

Quoted 7 lines
Quoted 1 line

Let's see what others think about it.

I don't care much either way. In general, I'm not too impressed with the
introduction of _VERSION_MAJOR variables, because IMHO it doesn't simplify things at all. The idea is that it would be easier to bump the version, but in all likelihood, when the major version changes, you have bigger problems to deal with than just having to change things in two places.

I'm usually not against using _VERSION_MAJOR.

What however I find disturbing and to be unnecessary churn, is this systematic change to using it.

I would prefer that we only switch to using _VERSION_MAJOR when there is a reason to do so (e.g. shared amongst many variables, like version, URL, path URLs, etc...) while bumping a package or fixing it somehow, and that we do not do that change on its own.

However, the name of the project is not OpenIPMI 2.0 Library. It's just OpenIPMI. Upstream also has "OpenIPMI 1.3 Library" and "OpenIPMI 1.4 Library" download locations, each corresponding to the 'major version' of the library.

Still, I agree with Arnout, and I don't think we should do those changes just for the sake of adding _VERSION_MAJOR. It should provide an actual improvement (but I can see that URL encoding above is a bit confusing to read without the variable).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'