added option to enable or disable reboot on ctrl-alt-del
PATCH 1/1 added option to enable or disable reboot on ctrl-alt-del
From: felten <[email protected]>
--- package/skeleton/skeleton.mk | 12 ++++++++++++ system/Config.in | 10 ++++++++++ 2 files changed, 22 insertions(+)
package/skeleton/skeleton.mk +12 -0
@@ -230,6 +230,18 @@ define SKELETON_SYSTEM_REMOUNT_RW endef endif TARGET_FINALIZE_HOOKS += SKELETON_SYSTEM_REMOUNT_RW +ifeq ($(BR2_TARGET_GENERIC_ENABLE_CTRL_ALT_DEL),y) +# Find commented line, if any, and remove leading '#'s +define SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL + $(SED) '/^#.*ctrlaltdel.*$$/s~^#\+~~' $(TARGET_DIR)/etc/inittab +endef +else +# Find uncommented line, if any, and add a leading '#' +define SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL + $(SED) '/^[^#].*ctrlaltdel.*$$/s~^~#~' $(TARGET_DIR)/etc/inittab +endef +endif +TARGET_FINALIZE_HOOKS += SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL endif # BR2_INIT_BUSYBOX || BR2_INIT_SYSV endif # BR2_ROOTFS_SKELETON_DEFAULT
system/Config.in +10 -0
@@ -347,6 +347,16 @@ config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW read-only. If unsure, say Y. +config BR2_TARGET_GENERIC_ENABLE_CTRL_ALT_DEL + bool "enable system reboot on ctrl-alt-del" + default y + help + By default, pressing ctrl-alt-del will reboot the system by invoking + the reboot command. + Say no here if you would rather like your system to ignore the + ctrl-alt-del combination. + If unsure, say y. + endif # BR2_ROOTFS_SKELETON_DEFAULT
Signature · 1 line
1.9.1
PATCH 1/1 added option to enable or disable reboot on ctrl-alt-del
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"lothar" == lothar felten <[email protected]> writes:
From: felten <[email protected]>
Signed-off-by lothar felten <[email protected]>
I'm not sure this is something that needs to be tweaked often enough (E.G. most systems don't have a keyboard connected), so I'm not sure we want the clutter the system menu with the option.
Perhaps we should simply remove the ctrlaltdel handling of our inittabs, as most people probably don't want it - And then just let the (few?) people wanting it add it through an overlay / post-build script.
Comments anyony?
Quoted 56 lines
--- package/skeleton/skeleton.mk | 12 ++++++++++++ system/Config.in | 10 ++++++++++ 2 files changed, 22 insertions(+)package/skeleton/skeleton.mk +12
-0@@ -230,6 +230,18 @@ define SKELETON_SYSTEM_REMOUNT_RW endef endif TARGET_FINALIZE_HOOKS += SKELETON_SYSTEM_REMOUNT_RW +ifeq ($(BR2_TARGET_GENERIC_ENABLE_CTRL_ALT_DEL),y) +# Find commented line, if any, and remove leading '#'s +define SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL + $(SED) '/^#.*ctrlaltdel.*$$/s~^#\+~~' $(TARGET_DIR)/etc/inittab +endef +else +# Find uncommented line, if any, and add a leading '#' +define SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL + $(SED) '/^[^#].*ctrlaltdel.*$$/s~^~#~' $(TARGET_DIR)/etc/inittab +endef +endif +TARGET_FINALIZE_HOOKS += SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL endif # BR2_INIT_BUSYBOX || BR2_INIT_SYSV endif # BR2_ROOTFS_SKELETON_DEFAULTsystem/Config.in +10
-0@@ -347,6 +347,16 @@ config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW read-only. If unsure, say Y. +config BR2_TARGET_GENERIC_ENABLE_CTRL_ALT_DEL + bool "enable system reboot on ctrl-alt-del" + default y + help + By default, pressing ctrl-alt-del will reboot the system by invoking + the reboot command. + Say no here if you would rather like your system to ignore the + ctrl-alt-del combination. + If unsure, say y. + endif # BR2_ROOTFS_SKELETON_DEFAULTSignature · 6 lines
1.9.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 added option to enable or disable reboot on ctrl-alt-del
Lothar, Peter, All,
On 2016-01-03 21:56 +0100, Peter Korsgaard spake thusly:
Quoted 9 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"lothar" == lothar felten <[email protected]> writes:
From: felten <[email protected]>
Signed-off-by lothar felten <[email protected]>I'm not sure this is something that needs to be tweaked often enough (E.G. most systems don't have a keyboard connected), so I'm not sure we want the clutter the system menu with the option.
Quoted 5 lines
Perhaps we should simply remove the ctrlaltdel handling of our inittabs, as most people probably don't want it - And then just let the (few?) people wanting it add it through an overlay / post-build script.
Comments anyony?
FTR, here's a repeat from IRC:
I do agree with Peter. Just disabling the 3-finger salute is OK for me. As Lothar suggested, I don;t mind the line being kept as comments in the inittabs.
Lothar, I'll mark your patch as "Changes Requested" in our patchwork. Care to send an update, please?
Thanks!
Regards,
Yann E. MORIN.
Quoted 64 lines
Quoted 56 lines
--- package/skeleton/skeleton.mk | 12 ++++++++++++ system/Config.in | 10 ++++++++++ 2 files changed, 22 insertions(+)package/skeleton/skeleton.mk +12
-0@@ -230,6 +230,18 @@ define SKELETON_SYSTEM_REMOUNT_RW endef endif TARGET_FINALIZE_HOOKS += SKELETON_SYSTEM_REMOUNT_RW +ifeq ($(BR2_TARGET_GENERIC_ENABLE_CTRL_ALT_DEL),y) +# Find commented line, if any, and remove leading '#'s +define SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL + $(SED) '/^#.*ctrlaltdel.*$$/s~^#\+~~' $(TARGET_DIR)/etc/inittab +endef +else +# Find uncommented line, if any, and add a leading '#' +define SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL + $(SED) '/^[^#].*ctrlaltdel.*$$/s~^~#~' $(TARGET_DIR)/etc/inittab +endef +endif +TARGET_FINALIZE_HOOKS += SKELETON_SYSTEM_ENABLE_CTRL_ALT_DEL endif # BR2_INIT_BUSYBOX || BR2_INIT_SYSV endif # BR2_ROOTFS_SKELETON_DEFAULTsystem/Config.in +10
-0@@ -347,6 +347,16 @@ config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW read-only. If unsure, say Y. +config BR2_TARGET_GENERIC_ENABLE_CTRL_ALT_DEL + bool "enable system reboot on ctrl-alt-del" + default y + help + By default, pressing ctrl-alt-del will reboot the system by invoking + the reboot command. + Say no here if you would rather like your system to ignore the + ctrl-alt-del combination. + If unsure, say y. + endif # BR2_ROOTFS_SKELETON_DEFAULTSignature · 6 lines
1.9.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildrootSignature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'