Skip to contentSkip to conversation

ASoC: rt5645: Constify ACPI device ids

PATCH In review Mathias Krause 2 participants 5 messages Jan 2, 2016 – Jan 6, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt5645: Constify ACPI device ids

Constify the ACPI device ID array, no need to have it writable at runtime. Also drop the unused RT5645_INIT_REG_LEN define.

---
 sound/soc/codecs/rt5645.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/rt5645.c +1 -2
index ef76940f9dcb..38a0b60a7f6e 100644
@@ -64,7 +64,6 @@ static const struct reg_sequence init_list[] = {
 	{RT5645_PR_BASE + 0x21,	0x4040},
 	{RT5645_PR_BASE + 0x23,	0x0004},
 };
-#define RT5645_INIT_REG_LEN ARRAY_SIZE(init_list)
 
 static const struct reg_sequence rt5650_init_list[] = {
 	{0xf6,	0x0100},
@@ -3326,7 +3325,7 @@ static const struct i2c_device_id rt5645_i2c_id[] = {
 MODULE_DEVICE_TABLE(i2c, rt5645_i2c_id);
 
 #ifdef CONFIG_ACPI
-static struct acpi_device_id rt5645_acpi_match[] = {
+static const struct acpi_device_id rt5645_acpi_match[] = {
 	{ "10EC5645", 0 },
 	{ "10EC5650", 0 },
 	{},
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 2 lines · Mathias Krause

Constify the ACPI device ID array, no need to have it writable at runtime. Also drop the unused RT5645_INIT_REG_LEN define.

Please don't mix multiple unrelated changes in a single patch, especially when there's no content overlap at all :(

#2 lore raw
Quoted 6 lines · Mark Brown
Quoted 2 lines · Mathias Krause

Constify the ACPI device ID array, no need to have it writable at runtime. Also drop the unused RT5645_INIT_REG_LEN define.

Please don't mix multiple unrelated changes in a single patch, especially when there's no content overlap at all :(

I've seen you've applied the patch nonetheless. So I guess you don't want me to split the patch any more?

Regards,
Mathias

maintainer
#3 lore raw
Quoted 7 lines · Mathias Krause
Quoted 2 lines · Mark Brown

Please don't mix multiple unrelated changes in a single patch, especially when there's no content overlap at all :(

I've seen you've applied the patch nonetheless. So I guess you don't want me to split the patch any more?

No need to split this patch but in future don't do this.

maintainer
#4 lore raw

Applied "ASoC: rt5645: Constify ACPI device ids" to the asoc tree

In reply to Mathias Krause

The patch

ASoC: rt5645: Constify ACPI device ids

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From e2973769372a3de1c20249206db5ee93287a2230 Mon Sep 17 00:00:00 2001

From: Mathias Krause <[email protected]>
Date: Sat, 2 Jan 2016 23:23:56 +0100
Subject: [PATCH] ASoC: rt5645: Constify ACPI device ids

Constify the ACPI device ID array, no need to have it writable at runtime. Also drop the unused RT5645_INIT_REG_LEN define.

---
 sound/soc/codecs/rt5645.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/rt5645.c +1 -2
index 57c8d9ecfde1..bd23496a56ff 100644
@@ -64,7 +64,6 @@ static const struct reg_sequence init_list[] = {
 	{RT5645_PR_BASE + 0x21,	0x4040},
 	{RT5645_PR_BASE + 0x23,	0x0004},
 };
-#define RT5645_INIT_REG_LEN ARRAY_SIZE(init_list)
 
 static const struct reg_sequence rt5650_init_list[] = {
 	{0xf6,	0x0100},
@@ -3521,7 +3520,7 @@ static const struct i2c_device_id rt5645_i2c_id[] = {
 MODULE_DEVICE_TABLE(i2c, rt5645_i2c_id);
 
 #ifdef CONFIG_ACPI
-static struct acpi_device_id rt5645_acpi_match[] = {
+static const struct acpi_device_id rt5645_acpi_match[] = {
 	{ "10EC5645", 0 },
 	{ "10EC5650", 0 },
 	{},
Signature · 1 line
2.6.2