drm/amd/powerplay: precedence bug in init_non_clock_fields()

The cast to uint8_t happens before the right shift so this always sets .m3arb to zero. The cast is actually a no-op so we can remove it.

Fixes 3bace3591493 ('drm/amd/powerplay: add hardware manager sub-component')

Signed-off-by Dan Carpenter <[email protected]>

---
Static analysis stuff. Not tested.

drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c +2 -2

index 1d385f4..9031a44 100644
@@ -735,8 +735,8 @@ static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
 
        ps->memory.dllOff = (0 != tmp);
 
-       ps->memory.m3arb = (uint8_t)(le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
-                                               ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
+       ps->memory.m3arb = (le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
+                           ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
 
        ps->temperatures.min = PP_TEMPERATURE_UNITS_PER_CENTIGRADES *
                                     pnon_clock_info->ucMinTemperature;

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel