Skip to contentSkip to conversation

Nokia N900: u-SD card in v4.2+

DISCUSSION Pavel Machek 4 participants 7 messages Jan 6, 2016 – Jan 13, 2016

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected.

Does it work for you? Any patches?

(I do have hack in the dts to disable back cover detection...)

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

Hi,

Quoted 8 lines · Pavel Machek

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected.

Does it work for you? Any patches?

I don't have Nokia N900 to check this, but can you share your config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

Thanks
Kishon

Quoted 5 lines

(I do have hack in the dts to disable back cover detection...)

Pavel

author
#2 lore raw

Hi!

Quoted 5 lines · Pavel Machek
Quoted 4 lines

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

Quoted 8 lines
Quoted 4 lines

In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected.

Does it work for you? Any patches?

I don't have Nokia N900 to check this, but can you share your config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.

I wonder if we should add some selects, so that users updating from old kernels don't break their system?

Thanks,

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
Quoted 17 lines · On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:

Hi!

Quoted 8 lines · Pavel Machek
Quoted 7 lines

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected.

Quoted 6 lines
Quoted 1 line

Does it work for you? Any patches?

I don't have Nokia N900 to check this, but can you share your config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

Quoted 4 lines

I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.

I wonder if we should add some selects, so that users updating from old kernels don't break their system?

Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, because I just updated defconfig from older kernel version.

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160109/20371783/attachment-0001.sig>
#4 lore raw

Hi,

Quoted 18 lines · Pali Roh?r
Quoted 17 lines · On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:

Hi!

Quoted 14 lines · Pavel Machek
Quoted 8 lines

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected.

Does it work for you? Any patches?

I don't have Nokia N900 to check this, but can you share your config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

Quoted 7 lines
Quoted 4 lines

I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.

I wonder if we should add some selects, so that users updating from old kernels don't break their system?

Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, because I just updated defconfig from older kernel version.

'select' is generally not recommended since it selects a config without caring for the dependency. With adding 'depends on', MMC won't be enabled and will end up in the same problem.

Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS should be enabled for MMCs to work.
commit d8e1f5ed11a39a68da00f05000466c4f6db4456e

Author: Tony Lindgren <[email protected]>
Date:   Mon Oct 12 16:19:54 2015 -0700

Documentation: ARM: List new omap MMC requirements

Maybe we should also make the error message a little more verbose to tell the user that CONFIG_REGULATOR_PBIAS be selected?

Thanks
Kishon

author
#5 lore raw
Quoted 26 lines · Kishon Vijay Abraham I

Hi,

Quoted 23 lines · Pali Roh?r
Quoted 21 lines · On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:

Hi!

Quoted 8 lines · Pavel Machek
Quoted 7 lines

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected.

Quoted 6 lines
Quoted 1 line

Does it work for you? Any patches?

I don't have Nokia N900 to check this, but can you share your config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.

I wonder if we should add some selects, so that users updating from old kernels don't break their system?

Quoted 6 lines
Quoted 2 lines

Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, because I just updated defconfig from older kernel version.

'select' is generally not recommended since it selects a config without caring for the dependency. With adding 'depends on', MMC won't be enabled and will end up in the same problem.

Well... it really should "depend on". Not ideal, but you'll likely realize what went on.

Silently compiling known-bad kernel is ... well.. bad.

Quoted 10 lines

Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS should be enabled for MMCs to work.
commit d8e1f5ed11a39a68da00f05000466c4f6db4456e

Author: Tony Lindgren <[email protected]>
Date:   Mon Oct 12 16:19:54 2015 -0700

Documentation: ARM: List new omap MMC requirements

Maybe we should also make the error message a little more verbose to tell the user that CONFIG_REGULATOR_PBIAS be selected?

That would help.

As would #error if we recognize broken config.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#6 lore raw
Quoted 10 lines · Pavel Machek
Quoted 4 lines · Kishon Vijay Abraham I

'select' is generally not recommended since it selects a config without caring for the dependency. With adding 'depends on', MMC won't be enabled and will end up in the same problem.

Well... it really should "depend on". Not ideal, but you'll likely realize what went on.

Silently compiling known-bad kernel is ... well.. bad.

Force selects will lead into build errors sooner or later.

Quoted 6 lines
Quoted 6 lines

Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS should be enabled for MMCs to work.
commit d8e1f5ed11a39a68da00f05000466c4f6db4456e

Author: Tony Lindgren <[email protected]>
Date:   Mon Oct 12 16:19:54 2015 -0700
Quoted 8 lines
Quoted 4 lines

Documentation: ARM: List new omap MMC requirements

Maybe we should also make the error message a little more verbose to tell the user that CONFIG_REGULATOR_PBIAS be selected?

That would help.

As would #error if we recognize broken config.

Can't we just add a check to the omap_hsmmc.c? In cases where MMC1 has the PBIAS regulator configured but not available, print an error about missing CONFIG_REGULATOR_PBIAS error and return -EPROBE_DEFER?

Regards,

Tony