Skip to contentSkip to conversation

MAINTAINERS: fix MIC maintainers entry

PATCH In review Dan Carpenter 2 participants 3 messages Jan 7, 2016 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: fix MIC maintainers entry

There were some missing colons so we stop parsing the MIC maintainers entry early. It means that:

./scripts/get_maintainer.pl -f drivers/misc/mic/card/mic_virtio.c

doesn't work.

MAINTAINERS +2 -2
index 248828d..070346d 100644
@@ -5749,11 +5749,11 @@ F:	include/linux/mic_bus.h
 F:	include/linux/scif.h
 F:	include/uapi/linux/mic_common.h
 F: 	include/uapi/linux/mic_ioctl.h
-F	include/uapi/linux/scif_ioctl.h
+F:	include/uapi/linux/scif_ioctl.h
 F:	drivers/misc/mic/
 F:	drivers/dma/mic_x100_dma.c
 F:	drivers/dma/mic_x100_dma.h
-F	Documentation/mic/
+F:	Documentation/mic/
 
 INTEL PMC/P-Unit IPC DRIVER
 M:	Zha Qipeng<[email protected]>
#1 lore raw

I wrote some bash to find problems in MAINTAINERS. I'm not sure what to do with it.

# Grep for missing colons
for i in $(cut -b 1-2 MAINTAINERS | grep : | sort | uniq | cut -b 1) ; do

    egrep "^$i[ 	]" MAINTAINERS

done

# Grep for non-existing files
for i in $(grep ^F: MAINTAINERS | grep -v '\*' | cut -d : -f 2-) ; do
if ! test -e $i ; then
echo $i
fi
done

regards,
dan carpenter

#2 lore raw
Quoted 8 lines · Dan Carpenter

I wrote some bash to find problems in MAINTAINERS.  I'm not sure what to do with it.

# Grep for missing colons
for i in $(cut -b 1-2 MAINTAINERS | grep : | sort | uniq | cut -b 1) ; do
    egrep "^$i[  ]" MAINTAINERS
done

Quoted 6 lines

# Grep for non-existing files
for i in $(grep ^F: MAINTAINERS | grep -v '\*' | cut -d : -f 2-) ; do if ! test -e $i ; then
        echo $i
    fi
done

I run a similar script every once in awhile.

Here's my current list with -next:

$ verify_maintainer_patterns.pl
0	drivers/infiniband/hw/amso1100/
0	arch/arm/mach-pxa/include/mach/palmt5.h
0	arch/arm/mach-pxa/include/mach/palmte2.h
0	arch/arm/mach-pxa/include/mach/palmtreo.h
0	arch/arm/mach-pxa/include/mach/palmz72.h
0	arch/arm/plat-samsung/s5p-dev-mfc.c
0	include/media/atmel-isi.h
0	arch/mips/bcm3384/*
0	arch/mips/include/asm/mach-bcm3384/*
0	Documentation/cgroups/cpusets.txt
0	drivers/media/i2c/cs3308.h
0	include/media/cx2341x*
0	include/uapi/scsi/cxlflash_ioctls.h
0	Documentation/devicetree/bindings/drm/atmel/
0	Documentation/devicetree/bindings/display/panel/nec,nl4827hc19_05b.txt
0	include/drm/gma500*
0	drivers/infiniband/hw/ehca/
0	drivers/crypto/nx/nx_debugfs.h
0	Documentation/devicetree/bindings/i2c/ina209.txt
0	Documentation/s390/kvm.txt
0	drivers/scsi/mpt2sas/
0	drivers/hwmon/max20751.c
0	Documentation/devicetree/bindings/i2c/max6697.txt
0	include/media/saa7146*
0	drivers/staging/ft1000/
0	fs/hppfs/

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html