polarssl: remove now redundant 128-bit blowfish key override
PATCH 1/1 polarssl: remove now redundant 128-bit blowfish key override
As of 1.3.0, polarssl/mbedtls now by default uses a 128 bit key for the blowfish cipher (as opposed to the 32-bit (!) default they had previously). Since we require polar 1.3+, we no longer need this fixup code.
Signed-off-by Steffan Karger <[email protected]...>
--- src/openvpn/crypto_polarssl.c | 2 -- 1 file changed, 2 deletions(-)
src/openvpn/crypto_polarssl.c +0 -2
@@ -415,8 +415,6 @@ cipher_kt_key_size (const cipher_info_t *cipher_kt) {if (NULL == cipher_kt)return 0 ; -if (POLARSSL_CIPHER_ID_BLOWFISH == cipher_kt->base->cipher) -return 128 /8 ;/* Override PolarSSL 32 bit default key size with sane 128 bit default */ return cipher_kt->key_length/8 ; }
Signature · 1 line
2.5.0
ACK. Tested with "--show-ciphers" (and t_client suite)
Your patch has been applied to the master branch.
commit 52012d651624f870e9dd1587c5fbf324d392dcf8
Author: Steffan Karger Date: Thu Jan 7 21:24:33 2016 +0100
polarssl: remove now redundant 128-bit blowfish key override
Signed-off-by: Steffan Karger <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: http://article.gmane.org/gmane.network.openvpn.devel/10956
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering