Skip to contentSkip to conversation

PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express

PATCH In review Tim Sander 3 participants 6 messages Jan 4, 2016 – Jan 19, 2016 PCI

lore
Share & tools
lore

Tim Sander

author
#0 lore raw

PATCH 1/1 PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express

Hi

Please consider this patch for the next release. It won't recognize my Plextor M6e PCIE disk without it. Please cc as i am not on the list.

Signed-off-by Tim Sander <[email protected]>

PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)

---
 drivers/pci/quirks.c    | 4 ++++
 include/linux/pci_ids.h | 3 +++
 2 files changed, 7 insertions(+)
drivers/pci/quirks.c +4 -0
index 7e32730..93ec5a02 100644
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
                         PCI_DEVICE_ID_JMICRON_JMB388_ESD,
                         quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
+                        PCI_DEVICE_ID_PLEXTOR_M6E,
+                        quirk_dma_func1_alias);
 
 /*
  * Some devices DMA with the wrong devfn, not just the wrong function.
include/linux/pci_ids.h +3 -0
index d9ba49c..01d8041 100644
@@ -2501,6 +2501,9 @@
 
 #define PCI_VENDOR_ID_ASMEDIA          0x1b21
 
+#define PCI_VENDOR_ID_LITE_ON          0x1c28
+#define PCI_DEVICE_ID_PLEXTOR_M6E      0x0122
+
 #define PCI_VENDOR_ID_CIRCUITCO                0x1cc8
 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
Signature · 1 line
1.9.1
#1 lore raw

[+cc Alex]

Quoted 8 lines · Tim Sander

Hi

Please consider this patch for the next release. It won't recognize my Plextor M6e PCIE disk without it. Please cc as i am not on the list.

Signed-off-by Tim Sander <[email protected]>

PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)

Alex?

Please use a subject line that matches the other similar commits:

247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120 c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint RocketRaid 642L cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell devices

Quoted 10 lines
---
 drivers/pci/quirks.c    | 4 ++++
 include/linux/pci_ids.h | 3 +++
 2 files changed, 7 insertions(+)
drivers/pci/quirks.c +0 -0
index 7e32730..93ec5a02 100644

drivers/pci/quirks.c DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642, · line 3623

Quoted 4 lines
drivers/pci/quirks.c +1 -0
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
                         PCI_DEVICE_ID_JMICRON_JMB388_ESD,
                         quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */

Thanks for the link. There are 126 comments on that bugzilla so far, so it'd be nice to have a more specific pointer. I'm guessing 117 might be the relevant one, so:

https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117

Quoted 11 lines
drivers/pci/quirks.c +3 -0
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
+                        PCI_DEVICE_ID_PLEXTOR_M6E,
+                        quirk_dma_func1_alias);
 
 /*
  * Some devices DMA with the wrong devfn, not just the wrong function.
include/linux/pci_ids.h +0 -0
index d9ba49c..01d8041 100644

include/linux/pci_ids.h line 2505

Quoted 5 lines
include/linux/pci_ids.h +2 -0
@@ -2501,6 +2501,9 @@
 
 #define PCI_VENDOR_ID_ASMEDIA          0x1b21
 
+#define PCI_VENDOR_ID_LITE_ON          0x1c28
+#define PCI_DEVICE_ID_PLEXTOR_M6E      0x0122

Since these constants are only used in one place, don't add them to pci_ids.h (see comment at the top of this file). Just use the hex constants directly in the quirk and include the vendor/device names in the comment.

Quoted 11 lines
include/linux/pci_ids.h +0 -0
 #define PCI_VENDOR_ID_CIRCUITCO                0x1cc8
 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
Signature · 7 lines
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 9 lines · Bjorn Helgaas

[+cc Alex]

Quoted 6 lines · Tim Sander

Hi

Please consider this patch for the next release. It won't recognize my Plextor
M6e PCIE disk without it. Please cc as i am not on the list.

Quoted 6 lines
Quoted 4 lines
Signed-off-by Tim Sander <[email protected]>

PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)

Alex?

Aside from the style issues you've already commented on, I'll give a thumbs up to quirking this device.  Thanks,

Alex

Quoted 57 lines

Please use a subject line that matches the other similar commits:

  247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120 c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint RocketRaid 642L
  cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell devices

Quoted 10 lines

---
 drivers/pci/quirks.c    | 4 ++++
 include/linux/pci_ids.h | 3 +++

 2 files changed, 7 insertions(+)
drivers/pci/quirks.c +0 -0
index 7e32730..93ec5a02 100644

drivers/pci/quirks.c DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, · line 3624

Quoted 5 lines
drivers/pci/quirks.c +1 -0
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI,
 0x0642,
  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
                          PCI_DEVICE_ID_JMICRON_JMB388_ESD,
                          quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */

Thanks for the link.  There are 126 comments on that bugzilla so far, so it'd be nice to have a more specific pointer.  I'm guessing 117 might be the relevant one, so:

  https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117

Quoted 15 lines
drivers/pci/quirks.c +3 -0
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
+                        PCI_DEVICE_ID_PLEXTOR_M6E,
+                        quirk_dma_func1_alias);


 /*
  * Some devices DMA with the wrong devfn, not just the wrong function.

include/linux/pci_ids.h +0 -0
index d9ba49c..01d8041 100644
@@ -2501,6 +2501,9 @@


 #define PCI_VENDOR_ID_ASMEDIA          0x1b21

include/linux/pci_ids.h line 2505

Quoted 2 lines
include/linux/pci_ids.h +2 -0
+#define PCI_VENDOR_ID_LITE_ON          0x1c28
+#define PCI_DEVICE_ID_PLEXTOR_M6E      0x0122

Since these constants are only used in one place, don't add them to pci_ids.h (see comment at the top of this file).  Just use the hex constants directly in the quirk and include the vendor/device names in
the comment.

Quoted 3 lines

 #define PCI_VENDOR_ID_CIRCUITCO                0x1cc8 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001

author
#3 lore raw

PATCH 1/1 PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183

Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183

Signed-off-by Tim Sander <[email protected]>
---
 drivers/pci/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/pci/quirks.c +4 -0
index 7e32730..40b1dfe 100644
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
                         PCI_DEVICE_ID_JMICRON_JMB388_ESD,
                         quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 */
+DECLARE_PCI_FIXUP_HEADER(0x1c28, /* Lite-On */
+                        0x0122, /* Plextor M6E (Marvell 88SS9183)*/
+                        quirk_dma_func1_alias);
 
 /*
  * Some devices DMA with the wrong devfn, not just the wrong function.
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#4 lore raw

Re: [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183

Quoted 5 lines · Tim Sander

Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183

Signed-off-by Tim Sander <[email protected]>

---

Acked-by Alex Williamson <[email protected]>
Quoted 20 lines

 drivers/pci/quirks.c | 4 ++++

 1 file changed, 4 insertions(+)
drivers/pci/quirks.c +4 -0
index 7e32730..40b1dfe 100644
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI,
 0x0642,
  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
                          PCI_DEVICE_ID_JMICRON_JMB388_ESD,
                          quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 */
+DECLARE_PCI_FIXUP_HEADER(0x1c28, /* Lite-On */
+                        0x0122, /* Plextor M6E (Marvell 88SS9183)*/
+                        quirk_dma_func1_alias);


 /*
  * Some devices DMA with the wrong devfn, not just the wrong function.

#5 lore raw

Re: [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183

In reply to Tim Sander
Quoted 3 lines · Tim Sander

Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183

Signed-off-by Tim Sander <[email protected]>

Applied with Alex's ack to pci/iommu for v4.5, thanks!

Quoted 26 lines
---
 drivers/pci/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/pci/quirks.c +4 -0
index 7e32730..40b1dfe 100644
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
                         PCI_DEVICE_ID_JMICRON_JMB388_ESD,
                         quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 */
+DECLARE_PCI_FIXUP_HEADER(0x1c28, /* Lite-On */
+                        0x0122, /* Plextor M6E (Marvell 88SS9183)*/
+                        quirk_dma_func1_alias);
 
 /*
  * Some devices DMA with the wrong devfn, not just the wrong function.
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html