net: remove scary warning about EEPROM provided MAC address
PATCH 1/1 net: remove scary warning about EEPROM provided MAC address
In many parts of the computing world having a unique MAC address sitting in some on-NIC storage is considered the normal case. Remove the warning to not scare the user unnecessarily. This applies to Highbank/Midway and ARM's Juno, for instance. Besides that this fixes the formatting on Midway, for instance, which currently looks like:
...
Net: xgmac0
Warning: xgmac0 using MAC address from net device
, xgmac1
Warning: xgmac1 using MAC address from net device
...
--- net/eth.c | 2 -- 1 file changed, 2 deletions(-)
net/eth.c +0 -2
@@ -761,8 +761,6 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, }else if (is_valid_ethaddr (dev->enetaddr)) {eth_setenv_enetaddr_by_index (base_name, eth_number, dev->enetaddr); -printf ("\nWarning: %s using MAC address from net device\n" , - dev->name); }else if (is_zero_ethaddr (dev->enetaddr)) {#ifdef CONFIG_NET_RANDOM_ETHADDR net_random_ethaddr (dev->enetaddr);
Signature · 1 line
2.6.4
PATCH 1/1 net: remove scary warning about EEPROM provided MAC address
Quoted 13 lines · Andre Przywara
In many parts of the computing world having a unique MAC address sitting in some on-NIC storage is considered the normal case. Remove the warning to not scare the user unnecessarily. This applies to Highbank/Midway and ARM's Juno, for instance. Besides that this fixes the formatting on Midway, for instance, which currently looks like:
...
Net: xgmac0
Warning: xgmac0 using MAC address from net device
, xgmac1
Warning: xgmac1 using MAC address from net device
...
Quoted 1 line
Signed-off-by Andre Przywara <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/c78e1c52/attachment.sig>
Quoted 13 lines · Andre Przywara
In many parts of the computing world having a unique MAC address sitting in some on-NIC storage is considered the normal case. Remove the warning to not scare the user unnecessarily. This applies to Highbank/Midway and ARM's Juno, for instance. Besides that this fixes the formatting on Midway, for instance, which currently looks like:
...
Net: xgmac0
Warning: xgmac0 using MAC address from net device
, xgmac1
Warning: xgmac1 using MAC address from net device
...
Quoted 1 line
Signed-off-by Andre Przywara <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160108/2173ddae/attachment.sig>
PATCH 1/1 net: remove scary warning about EEPROM provided MAC address
In reply to Andre PrzywaraQuoted 23 lines · Andre Przywara
In many parts of the computing world having a unique MAC address sitting in some on-NIC storage is considered the normal case. Remove the warning to not scare the user unnecessarily. This applies to Highbank/Midway and ARM's Juno, for instance. Besides that this fixes the formatting on Midway, for instance, which currently looks like:
...
Net: xgmac0
Warning: xgmac0 using MAC address from net device
, xgmac1
Warning: xgmac1 using MAC address from net device
...Signed-off-by Andre Przywara <[email protected]>--- net/eth.c | 2 -- 1 file changed, 2 deletions(-)net/eth.c +0
-0
net/eth.c int eth_write_hwaddr(struct eth_device *dev, const char *base_name, · line 765
Quoted 5 lines
net/eth.c +0
-2@@ -761,8 +761,6 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, }else if (is_valid_ethaddr (dev->enetaddr)) {eth_setenv_enetaddr_by_index (base_name, eth_number, dev->enetaddr); -printf ("\nWarning: %s using MAC address from net device\n" , - dev->name);
Guess this only changes the legacy case. The DM case still warns.
-Joe
Quoted 10 lines
net/eth.c +0
-1}else if (is_zero_ethaddr (dev->enetaddr)) {#ifdef CONFIG_NET_RANDOM_ETHADDR net_random_ethaddr (dev->enetaddr); --2.6.4
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot