Skip to contentSkip to conversation

package/libgsm: new package

PATCH New Bernd Kuhls 2 participants 7 messages Apr 26, 2015 – Feb 21, 2016

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/libgsm: new package

---
v3: - fixed typo
v2: - added hash
- updated 0001-cross.patch to reflect libgsm version
- added license info (Thomas)
- optimized license infos (Thomas)

 package/Config.in               |    1 +
 package/libgsm/0001-cross.patch |  205 +++++++++++++++++++++++++++++++++++++++
 package/libgsm/Config.in        |    6 ++
 package/libgsm/libgsm.hash      |    2 +
 package/libgsm/libgsm.mk        |   41 ++++++++
 5 files changed, 255 insertions(+)
 create mode 100644 package/libgsm/0001-cross.patch
 create mode 100644 package/libgsm/Config.in
 create mode 100644 package/libgsm/libgsm.hash
 create mode 100644 package/libgsm/libgsm.mk
package/Config.in +1 -0
index da185be..744ebc6 100644
@@ -670,6 +670,7 @@ menu "Audio/Sound"
 	source "package/libcdio/Config.in"
 	source "package/libcue/Config.in"
 	source "package/libcuefile/Config.in"
+	source "package/libgsm/Config.in"
 	source "package/libid3tag/Config.in"
 	source "package/liblo/Config.in"
 	source "package/libmad/Config.in"
package/libgsm/0001-cross.patch new file +205 -0

205 lines not on this page · raw message

package/libgsm/Config.in new file +6 -0
new file mode 100644
index 0000000..da6e22f
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBGSM
+	bool "libgsm"
+	help
+	  Shared libraries for GSM 06.10 lossy speech compression.
+
+	  http://www.quut.com/gsm
package/libgsm/libgsm.hash new file +2 -0
new file mode 100644
index 0000000..c0c7d3b
@@ -0,0 +1,2 @@
+# Locally computed
+sha256	5814a16a30b3c026871b3739812dc4a2a84299331182c987da1c212c93e9352c	gsm-1.0.14.tar.gz
package/libgsm/libgsm.mk new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v3 1/1 package/libgsm: new package

Bernd, All,

On 2015-04-26 20:26 +0200, Bernd Kuhls spake thusly:

Quoted 8 lines

---
v3: - fixed typo
v2: - added hash
- updated 0001-cross.patch to reflect libgsm version
- added license info (Thomas)
- optimized license infos (Thomas)

Quoted 5 lines
 package/Config.in               |    1 +
 package/libgsm/0001-cross.patch |  205 +++++++++++++++++++++++++++++++++++++++
 package/libgsm/Config.in        |    6 ++
 package/libgsm/libgsm.hash      |    2 +
 package/libgsm/libgsm.mk        |   41 ++++++++

So I had a look at this, and I am a bit sceptical...

If the intent was to use libgsm with Asterisk, then I think there is a bit of a confusion in my head (and probably a lot of confusion in Asterisk) because:

- Asterisk comes with its own bundled version of libgsm

- I was not able to tel Asterisk to use the libgsm from the system (i.e. it insisted on either using the budled version, or completely failed to configure (or build?, I can't recall...))

So, I',m not sure what the intent for this package was, but if was only to be used by Asterisk, then it is not currently possible to do so...

If it was meant to provide libgsm globaly, wihtout just Asterisk in mind, then I'll do a proper review of it later.

Thanks! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v3 1/1 package/libgsm: new package

Hi Yann,

Am Sat, 09 Jan 2016 19:12:05 +0100 schrieb Yann E. MORIN:

Quoted 2 lines

So, I',m not sure what the intent for this package was, but if was only to be used by Asterisk, then it is not currently possible to do so...

tbh I do not remember why I thought this package is necessary. Since I never got Asterisk configured for a run-time usable setup and I lost interest in it after I found Freeswitch (along with Fusionpbx) easier to use, I do not care when you mark my patch as Rejected.

Regards, Bernd

#3 lore raw

PATCH v3 1/1 package/libgsm: new package

Bernd, All,

On 2016-01-09 20:45 +0100, Bernd Kuhls spake thusly:

Quoted 8 lines

Am Sat, 09 Jan 2016 19:12:05 +0100 schrieb Yann E. MORIN:

Quoted 2 lines

So, I',m not sure what the intent for this package was, but if was only to be used by Asterisk, then it is not currently possible to do so...

tbh I do not remember why I thought this package is necessary. Since I never got Asterisk configured for a run-time usable setup and I lost interest in it after I found Freeswitch (along with Fusionpbx) easier to use, I do not care when you mark my patch as Rejected.

OK, thanks for the feedback. :-)

Since you're no longer interested in this package, and that from my (arguably limited) experience with Asterisk, with which is was supposed to be used, this package is not required for Asterisk to at least build properly, I'll mark this as rejected in Pathwork.

Thanks! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH v3 1/1 package/libgsm: new package

Bernd, All,

On 2016-01-11 21:49 +0100, Yann E. MORIN spake thusly:

Quoted 10 lines

On 2016-01-09 20:45 +0100, Bernd Kuhls spake thusly:

Quoted 8 lines

Am Sat, 09 Jan 2016 19:12:05 +0100 schrieb Yann E. MORIN:

Quoted 2 lines

So, I',m not sure what the intent for this package was, but if was only to be used by Asterisk, then it is not currently possible to do so...

tbh I do not remember why I thought this package is necessary. Since I never got Asterisk configured for a run-time usable setup and I lost interest in it after I found Freeswitch (along with Fusionpbx) easier to use, I do not care when you mark my patch as Rejected.

Quoted 6 lines

OK, thanks for the feedback. :-)

Since you're no longer interested in this package, and that from my (arguably limited) experience with Asterisk, with which is was supposed to be used, this package is not required for Asterisk to at least build properly, I'll mark this as rejected in Pathwork.

Ah, but now that I'm looking at pjsip, it looks like pjsip does have a dependency on libgsm.

I'll revert the stratus of this patch, then.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH v3 1/1 package/libgsm: new package

In reply to Bernd Kuhls

Bernd, All,

On 2015-04-26 20:26 +0200, Bernd Kuhls spake thusly:

Quoted 8 lines

---
v3: - fixed typo
v2: - added hash
- updated 0001-cross.patch to reflect libgsm version
- added license info (Thomas)
- optimized license infos (Thomas)

Quoted 5 lines
 package/Config.in               |    1 +
 package/libgsm/0001-cross.patch |  205 +++++++++++++++++++++++++++++++++++++++
 package/libgsm/Config.in        |    6 ++
 package/libgsm/libgsm.hash      |    2 +
 package/libgsm/libgsm.mk        |   41 ++++++++

So I've added that patch to my series adding asterisk, and I've reworked it a bit.

Thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH v3 1/1 package/libgsm: new package

Am Mon, 11 Jan 2016 23:40:46 +0100 schrieb Yann E. MORIN:

Quoted 2 lines

So I've added that patch to my series adding asterisk, and I've reworked it a bit.

Hi Yann,

FYI, I just saw that mediastreamer has an optional dependency to libgsm, to control it mediastreamer's build system supports --enable-gsm/ --disable-gsm. If you enable gsm support you need to add --with-gsm=$(STAGING_DIR)/usr, otherwise mediastreamer will look in /usr.

Regards, Bernd