ARM: dts: n900: Include adp1653 device
PATCH 1/1 ARM: dts: n900: Include adp1653 device
This patch adds adp1653 device into n900 DT structure. DT support in adp1653 driver is there since v4.2-rc1 version.
--- arch/arm/boot/dts/omap3-n900.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
arch/arm/boot/dts/omap3-n900.dts +15 -0
@@ -522,6 +522,21 @@ amstaos,cover-comp-gain = <16>; }; + adp1653: led-controller at 30 { + compatible = "adi,adp1653"; + reg = <0x30>; + enable-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ + + flash { + flash-timeout-us = <500000>; + flash-max-microamp = <320000>; + led-max-microamp = <50000>; + }; + indicator { + led-max-microamp = <17500>; + }; + }; + lp5523: lp5523 at 32 { compatible = "national,lp5523"; reg = <0x32>;
Signature · 1 line
1.7.9.5
Quoted 4 lines · Pali Roh?r
This patch adds adp1653 device into n900 DT structure. DT support in adp1653 driver is there since v4.2-rc1 version.
Signed-off-by Pali Roh?r <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 24 lines · On Saturday 26 December 2015 00:40:12 Pali Roh?r wrote:
This patch adds adp1653 device into n900 DT structure. DT support in adp1653 driver is there since v4.2-rc1 version.
Signed-off-by Pali Roh?r <[email protected]>--- arch/arm/boot/dts/omap3-n900.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/omap3-n900.dtsindex 5f5e0f3..ba93642 100644arch/arm/boot/dts/omap3-n900.dts +8
-0@@ -522,6 +522,21 @@ amstaos,cover-comp-gain = <16>; }; + adp1653: led-controller at 30 { + compatible = "adi,adp1653"; + reg = <0x30>; + enable-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ + + flash { + flash-timeout-us = <500000>; + flash-max-microamp = <320000>;
arch/arm/boot/dts/omap3-n900.dts line 542
Quoted 10 lines
arch/arm/boot/dts/omap3-n900.dts +7
-0+ led-max-microamp = <50000>; + }; + indicator { + led-max-microamp = <17500>; + }; + }; + lp5523: lp5523 at 32 { compatible = "national,lp5523"; reg = <0x32>;
Tony, can you take this patch?
Signature · 9 lines
Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160109/03aadb55/attachment.sig>
Quoted 24 lines · On Saturday 26 December 2015 00:40:12 Pali Roh?r wrote:
This patch adds adp1653 device into n900 DT structure. DT support in adp1653 driver is there since v4.2-rc1 version.
Signed-off-by Pali Roh?r <[email protected]>--- arch/arm/boot/dts/omap3-n900.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)arch/arm/boot/dts/omap3-n900.dts +8
-0@@ -522,6 +522,21 @@ amstaos,cover-comp-gain = <16>; }; + adp1653: led-controller at 30 { + compatible = "adi,adp1653"; + reg = <0x30>; + enable-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ + + flash { + flash-timeout-us = <500000>; + flash-max-microamp = <320000>;
arch/arm/boot/dts/omap3-n900.dts line 542
Quoted 10 lines
arch/arm/boot/dts/omap3-n900.dts +7
-0+ led-max-microamp = <50000>; + }; + indicator { + led-max-microamp = <17500>; + }; + }; + lp5523: lp5523 at 32 { compatible = "national,lp5523"; reg = <0x32>;
PING, who can take this patch?
I still do not see it in linus tree nor in others like arm-soc...
Signature · 2 lines
Pali Roh?r pali.rohar at gmail.com
The merge window is open, which is when development code that was merged in good time prior to the merge window is sent upstream to Linus. Linux maintainers may choose not to merge new code into their tree to avoid disrupting the utility of linux-next until the merge window has closed.
linux-next is an integration tree to help find merge conflicts, it exists to assist with the merge windows, not as a general test ground. Thus, linux-next must only contain code for either the current open merge window, or if the merge window is closed, the next merge window.
Quoted 43 lines · Pali Roh?r
Quoted 24 lines · On Saturday 26 December 2015 00:40:12 Pali Roh?r wrote:
This patch adds adp1653 device into n900 DT structure. DT support in adp1653 driver is there since v4.2-rc1 version.
Signed-off-by Pali Roh?r <[email protected]>--- arch/arm/boot/dts/omap3-n900.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)arch/arm/boot/dts/omap3-n900.dts +8
-0@@ -522,6 +522,21 @@ amstaos,cover-comp-gain = <16>; }; + adp1653: led-controller at 30 { + compatible = "adi,adp1653"; + reg = <0x30>; + enable-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ + + flash { + flash-timeout-us = <500000>; + flash-max-microamp = <320000>;arch/arm/boot/dts/omap3-n900.dts line 542
Quoted 10 lines
arch/arm/boot/dts/omap3-n900.dts +7
-0+ led-max-microamp = <50000>; + }; + indicator { + led-max-microamp = <17500>; + }; + }; + lp5523: lp5523 at 32 { compatible = "national,lp5523"; reg = <0x32>;PING, who can take this patch?
I still do not see it in linus tree nor in others like arm-soc...
Signature · 2 lines
Pali Roh?r pali.rohar at gmail.com
Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Ok, but for whole month I do not see any response that somebody take this patch into some queue or tree. Which could means that patch was either ignored or is living somewhere and could be lost.
Quoted 55 lines · On Thursday 21 January 2016 09:29:10 Russell King - ARM Linux wrote:
The merge window is open, which is when development code that was merged in good time prior to the merge window is sent upstream to Linus. Linux maintainers may choose not to merge new code into their tree to avoid disrupting the utility of linux-next until the merge window has closed.
linux-next is an integration tree to help find merge conflicts, it exists to assist with the merge windows, not as a general test ground. Thus, linux-next must only contain code for either the current open merge window, or if the merge window is closed, the next merge window.
Quoted 43 lines · Pali Roh?r
Quoted 24 lines · On Saturday 26 December 2015 00:40:12 Pali Roh?r wrote:
This patch adds adp1653 device into n900 DT structure. DT support in adp1653 driver is there since v4.2-rc1 version.
Signed-off-by Pali Roh?r <[email protected]>--- arch/arm/boot/dts/omap3-n900.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)arch/arm/boot/dts/omap3-n900.dts +8
-0@@ -522,6 +522,21 @@ amstaos,cover-comp-gain = <16>; }; + adp1653: led-controller at 30 { + compatible = "adi,adp1653"; + reg = <0x30>; + enable-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ + + flash { + flash-timeout-us = <500000>; + flash-max-microamp = <320000>;arch/arm/boot/dts/omap3-n900.dts line 542
Quoted 10 lines
arch/arm/boot/dts/omap3-n900.dts +7
-0+ led-max-microamp = <50000>; + }; + indicator { + led-max-microamp = <17500>; + }; + }; + lp5523: lp5523 at 32 { compatible = "national,lp5523"; reg = <0x32>;PING, who can take this patch?
I still do not see it in linus tree nor in others like arm-soc...
Signature · 2 lines
Pali Roh?r pali.rohar at gmail.com
Signature · 2 lines
Pali Roh?r pali.rohar at gmail.com
Quoted 3 lines · Pali Roh?r
Ok, but for whole month I do not see any response that somebody take this patch into some queue or tree. Which could means that patch was either ignored or is living somewhere and could be lost.
You sent it the day after Christmas day, when people were most likely on their Christmas break doing family stuff, and there was only one week after the traditional Christmas/New year break before the merge window opened.
So, discounting Christmas and the merge window, your patch has only been around for one week - a week where maintainers would have been stabilising their tree(s) in preparation for the merge window opening.
Please be patient; the merge window closes this Sunday, and I suspect "normal service" will be resumed shortly thereafter.
Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Quoted 5 lines · Russell King - ARM Linux
The merge window is open, which is when development code that was merged in good time prior to the merge window is sent upstream to Linus. Linux maintainers may choose not to merge new code into their tree to avoid disrupting the utility of linux-next until the merge window has closed.
Support for new hardware is normally allowed after -rc1.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 8 lines · Pavel Machek
Quoted 5 lines · Russell King - ARM Linux
The merge window is open, which is when development code that was merged in good time prior to the merge window is sent upstream to Linus. Linux maintainers may choose not to merge new code into their tree to avoid disrupting the utility of linux-next until the merge window has closed.
Support for new hardware is normally allowed after -rc1.
Yeah most maintainers avoid looking at new code until -rc1. Or until regresssions are out of the way. So patience please. Fixes are welcome any time though.
Regards,
Tony
Quoted 8 lines · Tony Lindgren
Quoted 7 lines · Pavel Machek
Quoted 5 lines · Russell King - ARM Linux
The merge window is open, which is when development code that was merged in good time prior to the merge window is sent upstream to Linus. Linux maintainers may choose not to merge new code into their tree to avoid disrupting the utility of linux-next until the merge window has closed.
Quoted 5 lines
Quoted 1 line
Support for new hardware is normally allowed after -rc1.
Yeah most maintainers avoid looking at new code until -rc1. Or until regresssions are out of the way. So patience please. Fixes are welcome any time though.
Indeed. However, unlike Pavel's comment, many maintainers choose not to merge code for new hardware until the merge window - it's very rare that support for new hardware is merged during the -rc phase.
If it were otherwise, I would've been able to get the Hummingboard 2 DTS patches in, or the etnaviv team would've been able to get the Etnaviv GPU DRM driver in during the 4.4-rc cycle, or the Dove PMU driver, or... etc.
Practically, new code waits for merge windows, because no one wants to de-stabilise the progression of the -rc series with new code, and Linus wants to see -rc merges fairly quiet and be mostly bug fixes so he can feel good about a final release around -rc6 to -rc7 time.
Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Quoted 24 lines · On Thursday 21 January 2016 16:54:08 Russell King - ARM Linux wrote:
Quoted 8 lines · Tony Lindgren
Quoted 7 lines · Pavel Machek
Quoted 5 lines · Russell King - ARM Linux
The merge window is open, which is when development code that was merged in good time prior to the merge window is sent upstream to Linus. Linux maintainers may choose not to merge new code into their tree to avoid disrupting the utility of linux-next until the merge window has closed.
Quoted 5 lines
Quoted 1 line
Support for new hardware is normally allowed after -rc1.
Yeah most maintainers avoid looking at new code until -rc1. Or until regresssions are out of the way. So patience please. Fixes are welcome any time though.
Indeed. However, unlike Pavel's comment, many maintainers choose not to merge code for new hardware until the merge window - it's very rare that support for new hardware is merged during the -rc phase.
If it were otherwise, I would've been able to get the Hummingboard 2 DTS patches in, or the etnaviv team would've been able to get the Etnaviv GPU DRM driver in during the 4.4-rc cycle, or the Dove PMU driver, or... etc.
Quoted 5 lines
Practically, new code waits for merge windows, because no one wants to de-stabilise the progression of the -rc series with new code, and Linus wants to see -rc merges fairly quiet and be mostly bug fixes so he can feel good about a final release around -rc6 to -rc7 time.
In my opinion this patch is not support for new hardware. It just add missing DT definition for one specific board for HW which was added to linux kernel in v4.2-rc1 version. For me it looks like that needed DT definition was forgotten...
Signature · 2 lines
Pali Roh?r pali.rohar at gmail.com
Quoted 4 lines · Pali Roh?r
In my opinion this patch is not support for new hardware. It just add missing DT definition for one specific board for HW which was added to linux kernel in v4.2-rc1 version. For me it looks like that needed DT definition was forgotten...
Opinions differ, but ultimately it's up to whoever is responsible for accepting the patch, and in the case of ARM SoC based patches, the arm-soc maintainers.
The arm-soc maintainers close their trees for development changes a few weeks before hand (a patch of mine which was acked etc by 7th December never made the 4.5 merge window either, and the alleged reason I've been told is because arm-soc was already closed by then).
Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Quoted 9 lines · Russell King - ARM Linux
Quoted 4 lines · Pali Roh?r
In my opinion this patch is not support for new hardware. It just add missing DT definition for one specific board for HW which was added to linux kernel in v4.2-rc1 version. For me it looks like that needed DT definition was forgotten...
Opinions differ, but ultimately it's up to whoever is responsible for accepting the patch, and in the case of ARM SoC based patches, the arm-soc maintainers.
Yeah. Sorry for long delay as discussed. I'm applying the $subject patch finally into omap-for-v4.6/dt today.
We still have at least two fixes left to go that both affect also n900. But at least I can now sanely test adding new stuff with a WIP fix for the PM runtime regression.
Quoted 4 lines
The arm-soc maintainers close their trees for development changes a few weeks before hand (a patch of mine which was acked etc by 7th December never made the 4.5 merge window either, and the alleged reason I've been told is because arm-soc was already closed by then).
Heh I too have some pending clock framework patches from December that I did not repost yet as the maintainers notified that they rather not take new stuff any longer for v4.5 before the holidays.
Regards,
Tony