Skip to contentSkip to conversation

staging: iio: cdc: Prefer using the BIT macro

PATCH In review Bhaktipriya Shridhar 2 participants 2 messages Jan 10, 2016

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Bhaktipriya Shridhar

author
#0 lore raw

PATCH 1/1 staging: iio: cdc: Prefer using the BIT macro

Replace all occurences of (1<<x) by BIT(x) in the file ad7150.c to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro"

Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/staging/iio/cdc/ad7150.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/iio/cdc/ad7150.c +3 -3
index e8d0ff2..0b934f7 100644
@@ -21,8 +21,8 @@
  */
 
 #define AD7150_STATUS              0
-#define AD7150_STATUS_OUT1         (1 << 3)
-#define AD7150_STATUS_OUT2         (1 << 5)
+#define AD7150_STATUS_OUT1         BIT(3)
+#define AD7150_STATUS_OUT2         BIT(5)
 #define AD7150_CH1_DATA_HIGH       1
 #define AD7150_CH2_DATA_HIGH       3
 #define AD7150_CH1_AVG_HIGH        5

@@ -36,7 +36,7 @@
 #define AD7150_CH2_TIMEOUT         13
 #define AD7150_CH2_SETUP           14
 #define AD7150_CFG                 15
-#define AD7150_CFG_FIX             (1 << 7)
+#define AD7150_CFG_FIX             BIT(7)
 #define AD7150_PD_TIMER            16
 #define AD7150_CH1_CAPDAC          17
 #define AD7150_CH2_CAPDAC          18

--
2.1.4

maintainer
#1 lore raw
Quoted 4 lines · Bhaktipriya Shridhar

Replace all occurences of (1<<x) by BIT(x) in the file ad7150.c to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro"

Signed-off-by Bhaktipriya Shridhar <[email protected]>

Hi,

I'm afraid that a similar patch was sent by Shraddha Barke back at the end of December. It just missed the last merge window so can currently only be found in the testing branch of iio.git.

Thanks anyway. It is always amazing how long code can sit in a given state before several patches turn up for it in a couple of weeks!

Jonathan

Quoted 36 lines
---
 drivers/staging/iio/cdc/ad7150.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/iio/cdc/ad7150.c +3 -4
index e8d0ff2..0b934f7 100644
@@ -21,8 +21,8 @@
  */
 
 #define AD7150_STATUS              0
-#define AD7150_STATUS_OUT1         (1 << 3)
-#define AD7150_STATUS_OUT2         (1 << 5)
+#define AD7150_STATUS_OUT1         BIT(3)
+#define AD7150_STATUS_OUT2         BIT(5)
 #define AD7150_CH1_DATA_HIGH       1
 #define AD7150_CH2_DATA_HIGH       3
 #define AD7150_CH1_AVG_HIGH        5

@@ -36,7 +36,7 @@
 #define AD7150_CH2_TIMEOUT         13
 #define AD7150_CH2_SETUP           14
 #define AD7150_CFG                 15
-#define AD7150_CFG_FIX             (1 << 7)
+#define AD7150_CFG_FIX             BIT(7)
 #define AD7150_PD_TIMER            16
 #define AD7150_CH1_CAPDAC          17
 #define AD7150_CH2_CAPDAC          18
--

2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html