lxc needs gzip scripts for lxc-checkconfig runtime

PATCH New Jonathan Ben-Avraham 3 participants 7 messages Sep 20, 2015 – Jan 11, 2016

lore

Share & tools

lore

Jonathan Ben-Avraham

author

2015-09-20 15:02 UTC #0 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

From: Jonathan Ben Avraham <[email protected]>

lxc executables such as lxc-checkconfig require scripts provided by gzip such as zgrep.

Signed-off-by Jonathan Ben Avraham <[email protected]>

---
 package/lxc/Config.in |    1 +
 1 file changed, 1 insertion(+)

package/lxc/Config.in +1 -0

index ffd9b4a..5377977 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LXC
 	bool "lxc"
 	select BR2_PACKAGE_LIBCAP
+	select BR2_PACKAGE_GZIP # runtime, for lxc-checkconfig
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
 	# build system forcefully builds a shared library

Signature · 1 line

1.7.9.5

Thomas Petazzoni

2015-09-20 17:06 UTC #1 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

Dear Jonathan Ben-Avraham,

Quoted 15 lines · Jonathan Ben-Avraham

From: Jonathan Ben Avraham <[email protected]>
lxc executables such as lxc-checkconfig require scripts provided by gzip such as zgrep.
Signed-off-by Jonathan Ben Avraham <[email protected]>
---
 package/lxc/Config.in |    1 +
 1 file changed, 1 insertion(+)
package/lxc/Config.in +0 -0
index ffd9b4a..5377977 100644

package/lxc/Config.in line 4

Quoted 4 lines

package/lxc/Config.in +1 -0

@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LXC
 	bool "lxc"
 	select BR2_PACKAGE_LIBCAP
+	select BR2_PACKAGE_GZIP # runtime, for lxc-checkconfig

BR2_PACKAGE_GZIP depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, so you should select it as well.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Jonathan Ben Avraham

author

2015-09-20 17:15 UTC #2 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

Hi Thomas,

Quoted 33 lines · Thomas Petazzoni

Date: Sun, 20 Sep 2015 19:06:22 +0200
From: Thomas Petazzoni <[email protected]>
To: Jonathan Ben-Avraham <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] lxc needs gzip scripts for
lxc-checkconfig runtime
Dear Jonathan Ben-Avraham,
Quoted 15 lines · Jonathan Ben-Avraham
From: Jonathan Ben Avraham <[email protected]>
lxc executables such as lxc-checkconfig require scripts provided by gzip such as zgrep.
Signed-off-by Jonathan Ben Avraham <[email protected]>
---
 package/lxc/Config.in |    1 +
 1 file changed, 1 insertion(+)
package/lxc/Config.in +0 -0
index ffd9b4a..5377977 100644
package/lxc/Config.in line 4
Quoted 4 lines
package/lxc/Config.in +1 -0
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LXC
 	bool "lxc"
 	select BR2_PACKAGE_LIBCAP
+	select BR2_PACKAGE_GZIP # runtime, for lxc-checkconfig
BR2_PACKAGE_GZIP depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, so you should select it as well.

Quoted 3 lines

Thanks!
Thomas

I wondered whether to send a patch for each 'select' individually or to wait until I complete my testing and submit a single patch with all of the lxc selects. What do you prefer?

- yba

Signature · 3 lines

  9590 8E58 D30D 1660 C349  673D B205 4FC4 B8F5 B7F9  ~. .~  Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhm

Thomas Petazzoni

2015-09-20 21:01 UTC #3 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

Jonathan,

Quoted 3 lines · Jonathan Ben Avraham

I wondered whether to send a patch for each 'select' individually or to wait until I complete my testing and submit a single patch with all of the lxc selects. What do you prefer?

Both solutions are fine with me. You can send patches as you progressively discover the issues, or send a single patch fixing all problems at once.

I'm just wondering if we want to make all these dependencies actually mandatory or not. It seems some of these dependencies are only used for one specific tool in LXC. If the tool is not crucial in LXC usage, maybe we should make it optional via a sub-option? I'm not sure here, just thinking out loud.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yann E. MORIN

2016-01-10 17:09 UTC #4 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

Thomas, Jonathan, All,

On 2015-09-20 23:01 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines · Jonathan Ben Avraham

Quoted 4 lines
I wondered whether to send a patch for each 'select' individually or to wait until I complete my testing and submit a single patch with all of the lxc selects. What do you prefer?
Both solutions are fine with me. You can send patches as you progressively discover the issues, or send a single patch fixing all problems at once.

Quoted 5 lines

I'm just wondering if we want to make all these dependencies actually mandatory or not. It seems some of these dependencies are only used for one specific tool in LXC. If the tool is not crucial in LXC usage, maybe we should make it optional via a sub-option? I'm not sure here, just thinking out loud.

Well, lxc is already in the 'server-class' software, probably to run a bunch of containers, themselves in the 'bloatware-class'.

So, the overhead of having gzip is probably insignifiant in the face of the size of the rest of the system.

So, I'm OK with selecting gzip unconditionally.

However, I would not want to force-select BB_SHOW_OTHERS, even though we already do it in three locations. Well, damn be it, just select both.

Jonathan, care to fix and respin, please?

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Jonathan Ben Avraham

author

2016-01-11 06:32 UTC #5 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

Hi Yann,
My current use case for lxc in Buildroot is for mobile SoC's such as the Qualcomm Snapdragon 805 and 810 that have IP blocks such as DSP's, VPU's and GPU's for which Qualcomm only releases Android drivers and libraries. In order to use these IP blocks, I run Android in an lxc and pass CNN kernels from Linux to adsprpcd running in Android that passes the CNN kernels through the Linux kernel to the Hexagon DSP. Admittedly this adds new meaning to the term "Convoluted Neural Networks" but it provides an interim solution to the application developers until we can reverse engineer Qualcomm's FastRPC interface.

I will re-spin the patch but before that I have yp-tools, ypbind-mt, sphinxbase and pocketsphinx to finish.
Thanks,

- yba

Quoted 43 lines · Yann E. MORIN

Date: Sun, 10 Jan 2016 18:09:23 +0100
From: Yann E. MORIN <[email protected]>
To: Thomas Petazzoni <[email protected]>
Cc: Jonathan Ben Avraham <[email protected]>, buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] lxc needs gzip scripts for
lxc-checkconfig runtime
Thomas, Jonathan, All,
On 2015-09-20 23:01 +0200, Thomas Petazzoni spake thusly:
Quoted 10 lines · Jonathan Ben Avraham
Quoted 4 lines
I wondered whether to send a patch for each 'select' individually or to wait until I complete my testing and submit a single patch with all of the lxc selects. What do you prefer?
Both solutions are fine with me. You can send patches as you progressively discover the issues, or send a single patch fixing all problems at once.
Quoted 5 lines
I'm just wondering if we want to make all these dependencies actually mandatory or not. It seems some of these dependencies are only used for one specific tool in LXC. If the tool is not crucial in LXC usage, maybe we should make it optional via a sub-option? I'm not sure here, just thinking out loud.
Well, lxc is already in the 'server-class' software, probably to run a bunch of containers, themselves in the 'bloatware-class'.
So, the overhead of having gzip is probably insignifiant in the face of the size of the rest of the system.
So, I'm OK with selecting gzip unconditionally.
However, I would not want to force-select BB_SHOW_OTHERS, even though we already do it in three locations. Well, damn be it, just select both.
Jonathan, care to fix and respin, please?
Regards,
Yann E. MORIN.

Signature · 3 lines

  9590 8E58 D30D 1660 C349  673D B205 4FC4 B8F5 B7F9  ~. .~  Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhm

Yann E. MORIN

2016-01-11 18:13 UTC #6 lore raw

PATCH 1/1 lxc needs gzip scripts for lxc-checkconfig runtime

Jonathan, All,

On 2016-01-11 08:32 +0200, Jonathan Ben Avraham spake thusly:

Quoted 7 lines

My current use case for lxc in Buildroot is for mobile SoC's such as the Qualcomm Snapdragon 805 and 810 that have IP blocks such as DSP's, VPU's and GPU's for which Qualcomm only releases Android drivers and libraries. In order to use these IP blocks, I run Android in an lxc and pass CNN kernels from Linux to adsprpcd running in Android that passes the CNN kernels through the Linux kernel to the Hexagon DSP. Admittedly this adds new meaning to the term "Convoluted Neural Networks"

Aha! :-)

Quoted 3 lines

but it provides an interim
solution to the application developers until we can reverse engineer Qualcomm's FastRPC interface.

Yeah, I can see how containers can come handy in this situation (not unlike somethig I've had too, btw).

Quoted 2 lines

I will re-spin the patch but before that I have yp-tools, ypbind-mt, sphinxbase and pocketsphinx to finish.

Great, thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'