drm/panel: simple: Add support for Sharp LQ101K1LY04
Subsystems (3)
PATCH 1/1 drm/panel: simple: Add support for Sharp LQ101K1LY04
Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
--- drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +26 -0
@@ -708,6 +708,29 @@ static const struct panel_desc giantplus_gpg482739qs5 = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, }; +static const struct display_timing sharp_lq101k1ly04_timing = { + .pixelclock = {60000000 ,65000000 ,80000000 }, + .hactive = {1280 ,1280 ,1280 }, + .hfront_porch = {20 ,20 ,20 }, + .hback_porch = {20 ,20 ,20 }, + .hsync_len = {10 ,10 ,10 }, + .vactive = {800 ,800 ,800 }, + .vfront_porch = {4 ,4 ,4 }, + .vback_porch = {4 ,4 ,4 }, + .vsync_len = {4 ,4 ,4 }, + .flags =DISPLAY_FLAGS_PIXDATA_POSEDGE , +}; +static const struct panel_desc sharp_lq101k1ly04 = { + .timings = &sharp_lq101k1ly04_timing, + .num_timings =1 , + .bpc =8 , + .size = { + .width =217 , + .height =136 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA , +}; +static const struct display_timing hannstar_hsd070pww1_timing = { .pixelclock = {64300000 ,71100000 ,82000000 }, .hactive = {1280 ,1280 ,1280 },
@@ -1146,6 +1169,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "hannstar,hsd070pww1", .data = &hannstar_hsd070pww1, }, { + .compatible = "sharp,lq101k1ly04", + .data = &sharp_lq101k1ly04, + }, { .compatible = "hannstar,hsd100pxn1", .data = &hannstar_hsd100pxn1, }, {
Signature · 1 line
2.5.0
On Tue, 12 Jan 2016 08:05:46 -0800
Joshua Clayton <[email protected]> wrote:
Bah. I mistakenly thought that send-email would add my SoB if I passed "-s" to git-send-email.
Quoted 2 lines
Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
Please add:
Quoted 48 lines
--- drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/panel/panel-simple.cindex f97b73e..9207b5d 100644drivers/gpu/drm/panel/panel-simple.c +26
-0@@ -708,6 +708,29 @@ static const struct panel_desc giantplus_gpg482739qs5 = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, }; +static const struct display_timing sharp_lq101k1ly04_timing = { + .pixelclock = {60000000 ,65000000 ,80000000 }, + .hactive = {1280 ,1280 ,1280 }, + .hfront_porch = {20 ,20 ,20 }, + .hback_porch = {20 ,20 ,20 }, + .hsync_len = {10 ,10 ,10 }, + .vactive = {800 ,800 ,800 }, + .vfront_porch = {4 ,4 ,4 }, + .vback_porch = {4 ,4 ,4 }, + .vsync_len = {4 ,4 ,4 }, + .flags =DISPLAY_FLAGS_PIXDATA_POSEDGE , +}; +static const struct panel_desc sharp_lq101k1ly04 = { + .timings = &sharp_lq101k1ly04_timing, + .num_timings =1 , + .bpc =8 , + .size = { + .width =217 , + .height =136 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA , +}; +static const struct display_timing hannstar_hsd070pww1_timing = { .pixelclock = {64300000 ,71100000 ,82000000 }, .hactive = {1280 ,1280 ,1280 },@@ -1146,6 +1169,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "hannstar,hsd070pww1", .data = &hannstar_hsd070pww1, }, { + .compatible = "sharp,lq101k1ly04", + .data = &sharp_lq101k1ly04, + }, { .compatible = "hannstar,hsd100pxn1", .data = &hannstar_hsd100pxn1, }, {
Hi Joshua,
Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton:
Quoted 5 lines
Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
---
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
Missing documentation for the DT binding.
Quoted 25 lines
1 file changed, 26 insertions(+)drivers/gpu/drm/panel/panel-simple.c +0
-0@@ -708,6 +708,29 @@ static const struct panel_desc giantplus_gpg482739qs5 = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, };drivers/gpu/drm/panel/panel-simple.c +13
-0+static const struct display_timing sharp_lq101k1ly04_timing = { + .pixelclock = {60000000 ,65000000 ,80000000 }, + .hactive = {1280 ,1280 ,1280 }, + .hfront_porch = {20 ,20 ,20 }, + .hback_porch = {20 ,20 ,20 }, + .hsync_len = {10 ,10 ,10 }, + .vactive = {800 ,800 ,800 }, + .vfront_porch = {4 ,4 ,4 }, + .vback_porch = {4 ,4 ,4 }, + .vsync_len = {4 ,4 ,4 }, + .flags =DISPLAY_FLAGS_PIXDATA_POSEDGE , +}; +static const struct panel_desc sharp_lq101k1ly04 = {
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc giantplus_gpg482739qs5 = { · line 733
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+ .timings = &sharp_lq101k1ly04_timing, + .num_timings = 1, + .bpc = 8, + .size = { + .width = 217, + .height = 136, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, +}; +
This hunk isn't added at the correct place. Please keep the alphabetical sorting.
drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 1175
Quoted 11 lines
static const struct
display_timinghannstar_hsd070pww1_timing= { .pixelclock = { 64300000, 71100000, 82000000 }, .hactive = { 1280, 1280, 1280 },drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -1146,6 +1169,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "hannstar,hsd070pww1", .data = &hannstar_hsd070pww1, }, { + .compatible = "sharp,lq101k1ly04", + .data = &sharp_lq101k1ly04, + }, {
Wrong insertion place again.
Quoted 3 lines
drivers/gpu/drm/panel/panel-simple.c +0
-0.compatible = "hannstar,hsd100pxn1", .data = &hannstar_hsd100pxn1,}, {
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Lucas,
Thanks for the review.
Quoted 5 lines · On Tue, 12 Jan 2016 19:45:30 +0100 Lucas Stach <[email protected]> wrote:
Quoted 2 lines
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++++++++++++++Missing documentation for the DT binding.
Thanks, will add.
...
Quoted 5 lines
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc giantplus_gpg482739qs5 = { · line 733
Quoted 3 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, +}; +This hunk isn't added at the correct place. Please keep the alphabetical sorting.
OK. Makes sense. I'll reorder these.
Quoted 14 lines
drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 1175
Quoted 12 lines
static const struct
display_timinghannstar_hsd070pww1_timing= { .pixelclock = { 64300000, 71100000, 82000000 }, .hactive = { 1280, 1280, 1280 },drivers/gpu/drm/panel/panel-simple.c +3
-0@@ -1146,6 +1169,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "hannstar,hsd070pww1", .data = &hannstar_hsd070pww1, }, { + .compatible = "sharp,lq101k1ly04", + .data = &sharp_lq101k1ly04, + }, {Wrong insertion place again.
OK. Will reorder alphabetically also.
Joshua