Skip to contentSkip to conversation

Staging: unisys: fix potential format string leak

PATCH RESEND New Kees Cook 1 participant 1 message Jan 12, 2016 Staging

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH RESEND 1/1 Staging: unisys: fix potential format string leak

Since "name" is always used directly, force "%s" for the kthread format string to avoid any potential format string leaks.

Signed-off-by Kees Cook <[email protected]>
---
 drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/unisys/visorhba/visorhba_main.c +1 -1
index c119f20dfd44..89712144f804 100644
@@ -167,7 +167,7 @@ static int visor_thread_start(struct visor_thread_info *thrinfo,
 {
 	/* used to stop the thread */
 	init_completion(&thrinfo->has_stopped);
-	thrinfo->task = kthread_run(threadfn, thrcontext, name);
+	thrinfo->task = kthread_run(threadfn, thrcontext, "%s", name);
 	if (IS_ERR(thrinfo->task)) {
 		thrinfo->id = 0;
 		return PTR_ERR(thrinfo->task);
Signature · 6 lines
2.6.3


-- 
Kees Cook
Chrome OS & Brillo Security