Skip to contentSkip to conversation

ASoC: AMD: free memory on error

PATCH In review Dan Carpenter 2 participants 2 messages Jan 13, 2016 – Jan 15, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: AMD: free memory on error

Static checkers complain if we don't free "adata" before returning.

Fixes 7c31335a03b6 ('ASoC: AMD: add AMD ASoC ACP 2.x DMA driver')
sound/soc/amd/acp-pcm-dma.c +1 -0
index 3191e0a..d1fb035 100644
@@ -635,6 +635,7 @@ static int acp_dma_open(struct snd_pcm_substream *substream)
 					    SNDRV_PCM_HW_PARAM_PERIODS);
 	if (ret < 0) {
 		dev_err(prtd->platform->dev, "set integer constraint failed\n");
+		kfree(adata);
 		return ret;
 	}
 
maintainer
#1 lore raw

Applied "ASoC: AMD: free memory on error" to the asoc tree

The patch

ASoC: AMD: free memory on error

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From cde6bcd584b1b910d6ee8d6eb968ea5d20815444 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Wed, 13 Jan 2016 15:20:02 +0300
Subject: [PATCH] ASoC: AMD: free memory on error

Static checkers complain if we don't free "adata" before returning.

Fixes 7c31335a03b6 ('ASoC: AMD: add AMD ASoC ACP 2.x DMA driver')
---
 sound/soc/amd/acp-pcm-dma.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/amd/acp-pcm-dma.c +1 -0
index 3191e0a7d273..d1fb035f44db 100644
@@ -635,6 +635,7 @@ static int acp_dma_open(struct snd_pcm_substream *substream)
 					    SNDRV_PCM_HW_PARAM_PERIODS);
 	if (ret < 0) {
 		dev_err(prtd->platform->dev, "set integer constraint failed\n");
+		kfree(adata);
 		return ret;
 	}
 
Signature · 1 line
2.7.0.rc3