mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

PATCH Applied Dan Carpenter 4 participants 4 messages Jan 13, 2016

Subsystems (4)

Networking Network drivers Kernel janitors Mellanox Ethernet switch drivers

lore

Share & tools

lore

Dan Carpenter

author

2016-01-13 12:28 UTC #0 lore raw

PATCH 1/1 mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

There is a missing break statement so we always return -EOPNOTSUPP.

Fixes 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +1 -0

index ffe894e..45479ef 100644
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
 	case SWITCHDEV_OBJ_ID_PORT_MDB:
 		err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
 					    SWITCHDEV_OBJ_PORT_MDB(obj));
+		break;
 	default:
 		err = -EOPNOTSUPP;
 		break;

Elad Raz

Acked-by on v1 1/1

2016-01-13 12:33 UTC #1 lore raw

Quoted 7 lines · Dan Carpenter

There is a missing break statement so we always return -EOPNOTSUPP.
Fixes 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Elad Raz <[email protected]>

Quoted 13 lines

drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +1 -0

index ffe894e..45479ef 100644
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
 	case SWITCHDEV_OBJ_ID_PORT_MDB:
 		err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
 					    SWITCHDEV_OBJ_PORT_MDB(obj));
+		break;
 	default:
 		err = -EOPNOTSUPP;
 		break;

Jiri Pirko

Acked-by on v1 1/1

2016-01-13 13:38 UTC #2 lore raw

In reply to Dan Carpenter

Quoted 4 lines · Wed, Jan 13, 2016 at 01:28:23PM CET, [email protected] wrote:

There is a missing break statement so we always return -EOPNOTSUPP.
Fixes 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Jiri Pirko <[email protected]>

David Miller

maintainer Applied

2016-01-13 15:35 UTC #3 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 13 Jan 2016 15:28:23 +0300

Quoted 4 lines

There is a missing break statement so we always return -EOPNOTSUPP.
Fixes 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by Dan Carpenter <[email protected]>

Applied.