Skip to contentSkip to conversation

Documentation: Explain pci=conf1,conf2 more verbosely

PATCH In review Borislav Petkov 2 participants 3 messages Jan 13, 2016 – Jan 14, 2016 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: Explain pci=conf1,conf2 more verbosely

From: Borislav Petkov <[email protected]>

People complained that setting the PCI config space access mechanism through "pci=conf1" or "pci=conf2" on the command line is not really documented. Yeah, can you blame them? Look at what we have now.

So try to improve the situation a bit by explaining what those "conf1" and "conf2" things actually mean.

See http://wiki.osdev.org/PCI for more info.

---
 Documentation/kernel-parameters.txt | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Documentation/kernel-parameters.txt +8 -4
index 742f69d18fc8..d1f5e057f3f3 100644
@@ -2733,10 +2733,14 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
 				hardware access methods are allowed. Use this
 				if you experience crashes upon bootup and you
 				suspect they are caused by the BIOS.
-		conf1		[X86] Force use of PCI Configuration
-				Mechanism 1.
-		conf2		[X86] Force use of PCI Configuration
-				Mechanism 2.
+		conf1		[X86] Force use of PCI Configuration Access
+				Mechanism 1 (config address in IO port 0xCF8,
+				data in IO port 0xCFC, both 32-bit).
+		conf2		[X86] Force use of PCI Configuration Access
+				Mechanism 2 (IO port 0xCF8 is an 8-bit port for
+				the function, IO port 0xCFA, also 8-bit, sets
+				bus number. The config space is then accessed
+				through ports 0xC000-0xCFFF).
 		noaer		[PCIE] If the PCIEAER kernel config parameter is
 				enabled, this kernel boot option can be used to
 				disable the use of PCIE advanced error reporting.
Signature · 1 line
2.3.5
maintainer
#1 lore raw
Quoted 6 lines · On Wed, 13 Jan 2016 16:48:51 +0100 Borislav Petkov <[email protected]> wrote:

People complained that setting the PCI config space access mechanism through "pci=conf1" or "pci=conf2" on the command line is not really documented. Yeah, can you blame them? Look at what we have now.

So try to improve the situation a bit by explaining what those "conf1" and "conf2" things actually mean.

Seems good, applied to the docs tree...

Quoted 1 line

See http://wiki.osdev.org/PCI for more info.

...but I took the liberty of adding this URL too; people reading the document are unlikely to check the commit log in case there's a useful pointer waiting there for them :)

Thanks,

jon

#2 lore raw
Quoted 5 lines · Jonathan Corbet
Quoted 1 line

See http://wiki.osdev.org/PCI for more info.

...but I took the liberty of adding this URL too; people reading the document are unlikely to check the commit log in case there's a useful pointer waiting there for them :)

Fair enough.

We did have a little discussion about adding some URL which might disappear in the future, to our docs. If it does, I guess we can then fall back to the internet archive...

Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.