Skip to contentSkip to conversation

package/uboot-tools: bump to version 2016.01

PATCH New Jörg Krause 4 participants 5 messages Jan 16, 2016 – Jan 17, 2016

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 package/uboot-tools: bump to version 2016.01

Signed-off-by J?rg Krause <[email protected]>
---
 package/uboot-tools/uboot-tools.hash | 2 +-
 package/uboot-tools/uboot-tools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/uboot-tools/uboot-tools.hash +1 -1
index 65a5261..31b0db9 100644
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
+sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2
package/uboot-tools/uboot-tools.mk +1 -1
index 6e4d0ed..3150279 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-UBOOT_TOOLS_VERSION = 2015.10
+UBOOT_TOOLS_VERSION = 2016.01
 UBOOT_TOOLS_SOURCE = u-boot-$(UBOOT_TOOLS_VERSION).tar.bz2
 UBOOT_TOOLS_SITE = ftp://ftp.denx.de/pub/u-boot
 UBOOT_TOOLS_LICENSE = GPLv2+
Signature · 1 line
2.6.4
#1 lore raw

PATCH 1/1 package/uboot-tools: bump to version 2016.01

Quoted 1 line · J?rg Krause
Signed-off-by J?rg Krause <[email protected]>

Maybe add

Fixes
http://autobuild.buildroot.net/results/9ebc5e3a6f1dd3ceb90d6786a1c5455c965f819e

package/uboot-tools/uboot-tools.hash line 2

Quoted 13 lines
---
 package/uboot-tools/uboot-tools.hash | 2 +-
 package/uboot-tools/uboot-tools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/uboot-tools/uboot-tools.hash +1 -1
index 65a5261..31b0db9 100644
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
+sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2

Don't we normally separate with tabs?

Regards,
Arnout

Quoted 14 lines
package/uboot-tools/uboot-tools.mk +1 -1
index 6e4d0ed..3150279 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-UBOOT_TOOLS_VERSION = 2015.10
+UBOOT_TOOLS_VERSION = 2016.01
 UBOOT_TOOLS_SOURCE = u-boot-$(UBOOT_TOOLS_VERSION).tar.bz2
 UBOOT_TOOLS_SITE = ftp://ftp.denx.de/pub/u-boot
 UBOOT_TOOLS_LICENSE = GPLv2+
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 package/uboot-tools: bump to version 2016.01

Arnout, All,

On 2016-01-16 22:51 +0100, Arnout Vandecappelle spake thusly:

Quoted 14 lines · J?rg Krause
Quoted 1 line
Signed-off-by J?rg Krause <[email protected]>

Maybe add

Fixes
http://autobuild.buildroot.net/results/9ebc5e3a6f1dd3ceb90d6786a1c5455c965f819e

Quoted 5 lines
---
 package/uboot-tools/uboot-tools.hash | 2 +-
 package/uboot-tools/uboot-tools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Quoted 10 lines

package/uboot-tools/uboot-tools.hash line 2

Quoted 8 lines
package/uboot-tools/uboot-tools.hash +1 -1
index 65a5261..31b0db9 100644
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
+sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2

Don't we normally separate with tabs?

Well, when I added support for hashes, I intended it to be used with spaces, a bit like the output of the corresponding *sum utilities, so that it could be esaily copy-pasted to create a .hash file.

Also, the manual states:

The format of this file is one line for each file for which to check the hash, each line being space-separated, with these three fields:
[...]
The number of spaces does not matter, so one can use spaces (or tabs) to properly align the different fields.

So, to me, TABs are accepted, but spaces should be the norm.

At least, I despise TABs... ;-] They are whatever the user wants them to be, and thus break any alignment that was done by the author of the code. I believe TABs should be proscribed everywhere it's possible (Makefiles being the outstanding offenders^Wexception...).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/uboot-tools: bump to version 2016.01

Quoted 34 lines · Yann E. MORIN

Arnout, All,

On 2016-01-16 22:51 +0100, Arnout Vandecappelle spake thusly:

Quoted 14 lines · J?rg Krause
Quoted 1 line
Signed-off-by J?rg Krause <[email protected]>

Maybe add

Fixes
http://autobuild.buildroot.net/results/9ebc5e3a6f1dd3ceb90d6786a1c5455c965f819e

Quoted 5 lines
---
 package/uboot-tools/uboot-tools.hash | 2 +-
 package/uboot-tools/uboot-tools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Quoted 10 lines

package/uboot-tools/uboot-tools.hash line 2

Quoted 8 lines
package/uboot-tools/uboot-tools.hash +1 -1
index 65a5261..31b0db9 100644
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
+sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2

Don't we normally separate with tabs?

Well, when I added support for hashes, I intended it to be used with spaces, a bit like the output of the corresponding *sum utilities, so that it could be esaily copy-pasted to create a .hash file.

Also, the manual states:

Quoted 7 lines

The format of this file is one line for each file for which to check the hash, each line being space-separated, with these three fields:
[...]
The number of spaces does not matter, so one can use spaces (or tabs) to properly align the different fields.

So, to me, TABs are accepted, but spaces should be the norm.

Sounds like a plan to me. But then perhaps we should document that, because
right now we have 1051 lines in hash files with tabs, and only 895 with spaces (and 1815 total so we also have a lot with mixed spaces-tabs...)

To be compatible with sha256 output, I propose we should prescribe 2 spaces.

Quoted 4 lines

At least, I despise TABs... ;-] They are whatever the user wants them to be, and thus break any alignment that was done by the author of the code. I believe TABs should be proscribed everywhere it's possible

                                 ^^^^^^^^^^

It rarely happens that I still learn a new English word... Funny that proscribe
and prescribe are almost opposites.

Regards,
Arnout

Quoted 5 lines

(Makefiles being the outstanding offenders^Wexception...).

Regards,
Yann E. MORIN.

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF