Skip to contentSkip to conversation

moarvm: disable for sparc64

PATCH Superseded Waldemar Brodkorb 2 participants 2 messages Jan 17, 2016

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 moarvm: disable for sparc64

Missing implementation of AO_fetch_compare_and_swap in libatomic_ops library for sparcv9.

---
v1 -> v2:
* added comment dependency suggested by Baruch Siach it was not possible to use a new dependency line.

---
 package/moarvm/Config.in |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/moarvm/Config.in +4 -2
index 95f3752..038fe6b 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_MOARVM
 	depends on !BR2_STATIC_LIBS # libuv
 	depends on BR2_USE_MMU # libuv
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # libatomic_ops
+	# needs AO_fetch_compare_and_swap, not implemented for sparcv9
+	depends on !BR2_sparc64
 	select BR2_PACKAGE_LIBUV
 	select BR2_PACKAGE_LIBATOMIC_OPS
 	help
@@ -12,8 +14,8 @@ config BR2_PACKAGE_MOARVM
 
 	  http://moarvm.com
 
-comment "moarvm needs a toolchain w/ threads, dynamic library"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+comment "moarvm needs a toolchain w/ threads, dynamic library and complete atomic ops"
+	depends on BR2_sparc64 || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS
 
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v2 1/1 moarvm: disable for sparc64

Hi Waldemar,

Quoted 27 lines · Waldemar Brodkorb

Missing implementation of AO_fetch_compare_and_swap in libatomic_ops library for sparcv9.

---
v1 -> v2:
* added comment dependency suggested by Baruch Siach it was not possible to use a new dependency line.

---
 package/moarvm/Config.in |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/moarvm/Config.in +2 -0
index 95f3752..038fe6b 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_MOARVM
 	depends on !BR2_STATIC_LIBS # libuv
 	depends on BR2_USE_MMU # libuv
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # libatomic_ops
+	# needs AO_fetch_compare_and_swap, not implemented for sparcv9
+	depends on !BR2_sparc64
 	select BR2_PACKAGE_LIBUV
 	select BR2_PACKAGE_LIBATOMIC_OPS
 	help

package/moarvm/Config.in config BR2_PACKAGE_MOARVM · line 18

Quoted 7 lines
package/moarvm/Config.in +2 -2
@@ -12,8 +14,8 @@ config BR2_PACKAGE_MOARVM
 
 	  http://moarvm.com
 
-comment "moarvm needs a toolchain w/ threads, dynamic library"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+comment "moarvm needs a toolchain w/ threads, dynamic library and complete atomic ops"
+	depends on BR2_sparc64 || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

Should be 'depends on !BR2_sparc64' in a separate line. That is, hide the comment for sparc64. This is the rule for platform dependencies because the user can't just choose a different platform in most cases. For the same reason the comment text should not change.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -