include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list

Moin Johannes,

you're the last touching net/ipv4/tcp_memcontrol.c, so here you go :-P

In file included from net/ipv4/tcp_ipv4.c:76:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list

 int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
                                                      ^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/tcp_ipv6.c:64:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
 int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
                                                      ^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/sysctl_net_ipv4.c:27:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
 int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
                                                      ^

include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want

Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Guten Nachmittag Boris,

thanks for the report. All this code (tcp_memcontrol.*) is already deleted in -mm, so the issue should be fixed once Andrew sends the next batch for this merge window linuswards.

I see David applied this:

https://lkml.kernel.org/r/[email protected]

I guess it is moot now.

Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.