Skip to contentSkip to conversation

device-drivers/uaccess: use linux/uaccess.h

PATCH New Stanislav Kholmanskikh 2 participants 3 messages Jan 19, 2016 – Jan 20, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 device-drivers/uaccess: use linux/uaccess.h

The current code fails to build on sparc64.

It turns out that <linux/uaccess.h> is a better candidate than <asm-generic/uaccess.h>, since the former takes into account possible architecture-specific changes.

---
 .../kernel/device-drivers/uaccess/ltp_uaccess.c    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
testcases/kernel/device-drivers/uaccess/ltp_uaccess.c +1 -1
index e628ba9..a9a06e9 100644
@@ -21,7 +21,7 @@
 
 #include <linux/module.h>
 #include <linux/device.h>
-#include <asm-generic/uaccess.h>
+#include <linux/uaccess.h>
 #include "ltp_uaccess.h"
 
 MODULE_AUTHOR("Alexey Kodanev <[email protected]>");
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 device-drivers/uaccess: use linux/uaccess.h

Hi!

testcases/kernel/device-drivers/uaccess/ltp_uaccess.c line 24

Quoted 4 lines

#include <linux/module.h>
#include <linux/device.h>

testcases/kernel/device-drivers/uaccess/ltp_uaccess.c +1 -1
-#include <asm-generic/uaccess.h>
+#include <linux/uaccess.h>

Looks good, acked.

Btw, grepping "uaccess.h" in linux/drivers/ shows either linux/uaccess.h or asm/uaccess.h but no asm-generic/uaccess.h.

Signature · 2 lines
Cyril Hrubis
[email protected]
#2 lore raw

PATCH 1/1 device-drivers/uaccess: use linux/uaccess.h

Quoted 7 lines · Cyril Hrubis

Hi!

testcases/kernel/device-drivers/uaccess/ltp_uaccess.c line 24

Quoted 4 lines
  #include <linux/module.h>
  #include <linux/device.h>
testcases/kernel/device-drivers/uaccess/ltp_uaccess.c +1 -1
-#include <asm-generic/uaccess.h>
+#include <linux/uaccess.h>

Looks good, acked.

Thank you. Committed.

Quoted 4 lines

Btw, grepping "uaccess.h" in linux/drivers/ shows either linux/uaccess.h or asm/uaccess.h but no asm-generic/uaccess.h.