Skip to contentSkip to conversation

mpd: disable for sparcv8

PATCH New Waldemar Brodkorb 2 participants 5 messages Jan 19, 2016 – Feb 7, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpd: disable for sparcv8

Even the main source code in mpd requires some missing atomic ops. So only disable some failing plugins, does not solve the following autobuild error:
http://autobuild.buildroot.net/results/e2207280f3a177e12dba502b1c01f5aeb431d04c/

Leon3 works fine.

---
 package/mpd/Config.in |    2 ++
 1 file changed, 2 insertions(+)
package/mpd/Config.in +2 -0
index be0843f..b88c0ca 100644
@@ -6,6 +6,7 @@ menuconfig BR2_PACKAGE_MPD
 	depends on BR2_USE_MMU # libglib2
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
 	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+	depends on !BR2_sparc_v8 # feature need atomic ops
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
@@ -303,6 +304,7 @@ config BR2_PACKAGE_MPD_UPNP
 endif
 
 comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6"
+	depends on !BR2_sparc_v8 # feature need atomic ops
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 mpd: disable for sparcv8

Dear Waldemar Brodkorb,

Quoted 17 lines · Waldemar Brodkorb

Even the main source code in mpd requires some missing atomic ops. So only disable some failing plugins, does not solve the following autobuild error:
http://autobuild.buildroot.net/results/e2207280f3a177e12dba502b1c01f5aeb431d04c/

Leon3 works fine.

---
 package/mpd/Config.in |    2 ++
 1 file changed, 2 insertions(+)
package/mpd/Config.in +0 -0
index be0843f..b88c0ca 100644

package/mpd/Config.in menuconfig BR2_PACKAGE_MPD · line 9

Quoted 4 lines
package/mpd/Config.in +1 -0
@@ -6,6 +6,7 @@ menuconfig BR2_PACKAGE_MPD
 	depends on BR2_USE_MMU # libglib2
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
 	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+	depends on !BR2_sparc_v8 # feature need atomic ops

To be honest, I don't really like this solution. I know it is the easiest quick fix, but it's not the long-term proper solution.

Instead, I've started looking at all architectures, to see which of the __sync_*() and __atomic_*() builtins are supported, when -latomic is needed or not needed, etc. Once we have this picture, we can then design how such dependencies should be expressed rather than adding more and more architecture exclusions.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 mpd: disable for sparcv8

Hi Thomas,
Thomas Petazzoni wrote,

Quoted 28 lines

Dear Waldemar Brodkorb,

Quoted 17 lines · Waldemar Brodkorb

Even the main source code in mpd requires some missing atomic ops. So only disable some failing plugins, does not solve the following autobuild error:
http://autobuild.buildroot.net/results/e2207280f3a177e12dba502b1c01f5aeb431d04c/

Leon3 works fine.

---
 package/mpd/Config.in |    2 ++
 1 file changed, 2 insertions(+)
package/mpd/Config.in +0 -0
index be0843f..b88c0ca 100644

package/mpd/Config.in menuconfig BR2_PACKAGE_MPD · line 9

Quoted 4 lines
package/mpd/Config.in +1 -0
@@ -6,6 +6,7 @@ menuconfig BR2_PACKAGE_MPD
 	depends on BR2_USE_MMU # libglib2
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
 	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+	depends on !BR2_sparc_v8 # feature need atomic ops

To be honest, I don't really like this solution. I know it is the easiest quick fix, but it's not the long-term proper solution.

Quoted 5 lines

Instead, I've started looking at all architectures, to see which of the __sync_*() and __atomic_*() builtins are supported, when -latomic is needed or not needed, etc. Once we have this picture, we can then design how such dependencies should be expressed rather than adding more and more architecture exclusions.

May be we can add this patch now and when you figured everything out to do a clean solution, you just use grep to find the problematic packages disabled for sparc/sparc64.

Therefore we have some fewer autobuild failures meanwhile. Other atomic related patches got applied, so we should do this until your refactoring.

best regards
Waldemar

#3 lore raw

PATCH 1/1 mpd: disable for sparcv8

Hello,

Quoted 7 lines · Waldemar Brodkorb

May be we can add this patch now and when you figured everything out to do a clean solution, you just use grep to find the problematic packages disabled for sparc/sparc64.

Therefore we have some fewer autobuild failures meanwhile. Other atomic related patches got applied, so we should do this until your refactoring.

Agreed. Then it would be good to make sure to annotate such dependencies in a systematic way, so that we can easily grep for them in the future.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 mpd: disable for sparcv8

In reply to Waldemar Brodkorb

Dear Waldemar Brodkorb,

Quoted 8 lines · Waldemar Brodkorb

Even the main source code in mpd requires some missing atomic ops. So only disable some failing plugins, does not solve the following autobuild error:
http://autobuild.buildroot.net/results/e2207280f3a177e12dba502b1c01f5aeb431d04c/

Leon3 works fine.

I've applied what I believe is a better solution:

https://git.busybox.net/buildroot/commit/?id=84533029c70a4dffb2cd2e4f05e3903fd1b8fcd9

(it allows to build mpd on SPARCv8)

So I've marked your patch as rejected.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com