Skip to contentSkip to conversation

ext4: trim unused params from convert_initialized_extent()

PATCH Applied Eric Whitney 2 participants 2 messages Jan 20, 2016 – Feb 23, 2016 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: trim unused params from convert_initialized_extent()

The flags and newblock parameters are unused.

---
 fs/ext4/extents.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/ext4/extents.c +3 -3
index b52fea3..0288b47 100644
@@ -3927,8 +3927,8 @@ get_reserved_cluster_alloc(struct inode *inode, ext4_lblk_t lblk_start,
 static int
 convert_initialized_extent(handle_t *handle, struct inode *inode,
 			   struct ext4_map_blocks *map,
-			   struct ext4_ext_path **ppath, int flags,
-			   unsigned int allocated, ext4_fsblk_t newblock)
+			   struct ext4_ext_path **ppath,
+			   unsigned int allocated)
 {
 	struct ext4_ext_path *path = *ppath;
 	struct ext4_extent *ex;
@@ -4347,7 +4347,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
 			    (flags & EXT4_GET_BLOCKS_CONVERT_UNWRITTEN)) {
 				allocated = convert_initialized_extent(
 						handle, inode, map, &path,
-						flags, allocated, newblock);
+						allocated);
 				goto out2;
 			} else if (!ext4_ext_is_unwritten(ex))
 				goto out;
Signature · 1 line
2.1.4
maintainer Applied
#1 lore raw
Quoted 3 lines · Eric Whitney

The flags and newblock parameters are unused.

Thanks, applied.

I've adjusted this patch to just remove the flags parameters (since the newblock paramter was removed in another patch).

- Ted