Skip to contentSkip to conversation

igep00x0: enable CONFIG_CMD_SETEXPR

PATCH New Ladislav Michl 2 participants 4 messages Jan 21, 2016

lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH 1/1 igep00x0: enable CONFIG_CMD_SETEXPR

Enable CONFIG_CMD_SETEXPR, useful when passing initramfs end address:

$ fatload mmc 0:1 $rdaddr root.cpio.gz
$ setexpr rdendaddr $rdaddr + $filesize
$ fdt chosen $rdaddr $rdendaddr
$ bootz $loadaddr - $fdtaddr
Signed-off-by Ladislav Michl <[email protected]>
---
 configs/igep0020_defconfig      | 2 +-
 configs/igep0020_nand_defconfig | 2 +-
 configs/igep0030_defconfig      | 2 +-
 configs/igep0030_nand_defconfig | 2 +-
 configs/igep0032_defconfig      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
configs/igep0020_defconfig +1 -1
index a96c130..d4b5746 100644
@@ -6,6 +6,6 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_ONENAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
 CONFIG_NET_RANDOM_ETHADDR=y
configs/igep0020_nand_defconfig +1 -1
index cf3ee79..57a3e78 100644
@@ -6,6 +6,6 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
 CONFIG_NET_RANDOM_ETHADDR=y
configs/igep0030_defconfig +1 -1
index 63ce633..1a1f548 100644
@@ -6,5 +6,5 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
configs/igep0030_nand_defconfig +1 -1
index dce7e06..c59b988 100644
@@ -6,5 +6,5 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
configs/igep0032_defconfig +1 -1
index b7f1d61..27a763f 100644
@@ -6,6 +6,6 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
 CONFIG_NET_RANDOM_ETHADDR=y
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 igep00x0: enable CONFIG_CMD_SETEXPR

Quoted 5 lines · Ladislav Michl

Enable CONFIG_CMD_SETEXPR, useful when passing initramfs end address:

$ fatload mmc 0:1 $rdaddr root.cpio.gz
$ setexpr rdendaddr $rdaddr + $filesize
$ fdt chosen $rdaddr $rdendaddr
$ bootz $loadaddr - $fdtaddr

OK, but why do that instead of 'bootz $loadaddr $rdaddr $fdtaddr' ?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160121/acfd2170/attachment.sig>
author
#2 lore raw

PATCH 1/1 igep00x0: enable CONFIG_CMD_SETEXPR

Quoted 9 lines · Tom Rini
Quoted 5 lines · Ladislav Michl

Enable CONFIG_CMD_SETEXPR, useful when passing initramfs end address:

$ fatload mmc 0:1 $rdaddr root.cpio.gz
$ setexpr rdendaddr $rdaddr + $filesize
$ fdt chosen $rdaddr $rdendaddr
$ bootz $loadaddr - $fdtaddr

OK, but why do that instead of 'bootz $loadaddr $rdaddr $fdtaddr' ?

=> bootz $loadaddr $rdaddr $fdtaddr
Wrong Ramdisk Image Format
Ramdisk image is corrupt or invalid

Well, perhaps that could be done with CONFIG_SUPPORT_RAW_INITRD, which expects size of initrd, not an end address. I'll give it a try and possibly enable that instead.

ladis

author
#3 lore raw

PATCH 1/1 igep00x0: enable CONFIG_CMD_SETEXPR

Quoted 1 line · Ladislav Michl

On Thu, Jan 21, 2016 at 02:11:13PM -0500, Tom Rini wrote:

[...]

Quoted 9 lines
Quoted 1 line

OK, but why do that instead of 'bootz $loadaddr $rdaddr $fdtaddr' ?

=> bootz $loadaddr $rdaddr $fdtaddr
Wrong Ramdisk Image Format
Ramdisk image is corrupt or invalid

Well, perhaps that could be done with CONFIG_SUPPORT_RAW_INITRD, which expects size of initrd, not an end address. I'll give it a try and possibly enable that instead.

Ok, works and is even already defined in ti_armv7_common.h and 'bootz $loadaddr $rdaddr:$filesize $fdtaddr' is even simpler. Thank you :)

ladis