Skip to contentSkip to conversation

4.5-rc0: n900 battery charging reverts to 100mA, indicator turns back on

DISCUSSION Pavel Machek 3 participants 6 messages Jan 21, 2016 – Jan 23, 2016

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

In 4.4, n900 battery charging works. If indicator is turned off, it stays off, and if I select 1.8A charge, it sticks. (There may be problems after system suspend and resume. But normal operation seems to be pretty reliable).

In 4.5-rc0 (7fdec82af6a9e190e53d07a1463d2a9ac49a8750) battery charging works for few hours. But then indicator (yellow light on 3color LED) turns back on, and if I ask for 1.8A charge, it goes back to .1A, discharging battery.

Any ideas?

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

Hi,

Quoted 11 lines · Pavel Machek

In 4.4, n900 battery charging works. If indicator is turned off, it stays off, and if I select 1.8A charge, it sticks. (There may be problems after system suspend and resume. But normal operation seems to be pretty reliable).

In 4.5-rc0 (7fdec82af6a9e190e53d07a1463d2a9ac49a8750) battery charging works for few hours. But then indicator (yellow light on 3color LED) turns back on, and if I ask for 1.8A charge, it goes back to .1A, discharging battery.

Any ideas?

Maybe a side-effect of isp1704 driver actually doing what was intended, which is is 88025632515a ("power: isp1704_charger: Fix isp1704_write()").

P.S.: No need to Cc me two times and when you update your script/contacts, please use sre at kernel.org :)

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160121/d0e0b6d7/attachment-0001.sig>

author
#2 lore raw
Quoted 13 lines · Sebastian Reichel

Hi,

Quoted 10 lines · Pavel Machek

In 4.4, n900 battery charging works. If indicator is turned off, it stays off, and if I select 1.8A charge, it sticks. (There may be problems after system suspend and resume. But normal operation seems to be pretty reliable).

In 4.5-rc0 (7fdec82af6a9e190e53d07a1463d2a9ac49a8750) battery charging works for few hours. But then indicator (yellow light on 3color LED) turns back on, and if I ask for 1.8A charge, it goes back to .1A, discharging battery.

Quoted 5 lines
Quoted 1 line

Any ideas?

Maybe a side-effect of isp1704 driver actually doing what was intended, which is is 88025632515a ("power: isp1704_charger: Fix isp1704_write()").

Hmm. It looks like 7fdec82af6a does not yet contain 88025632515a. Let me try to add that fix, instead...

Quoted 2 lines

P.S.: No need to Cc me two times and when you update your script/contacts, please use sre at kernel.org :)

Address book updated :-).
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw

Hi,

Quoted 2 lines · Pavel Machek

Hmm. It looks like 7fdec82af6a does not yet contain 88025632515a. Let me try to add that fix, instead...

Right, your checkout does not contain the power supply pull request. I think it's unlikely, that the patch will fix your issue.

Since there are no other power supply changes between 4.4 and your checkout, the next most likely candidate is the usb tree (which has been merged before the commit you mentioned).

Quoted 4 lines
Quoted 2 lines

P.S.: No need to Cc me two times and when you update your script/contacts, please use sre at kernel.org :)

Address book updated :-)

Thanks.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160121/52841701/attachment.sig>

#4 lore raw
In reply to Pavel Machek
Quoted 6 lines · On Thursday 21 January 2016 19:42:34 Pavel Machek wrote:

Hi!

In 4.4, n900 battery charging works. If indicator is turned off, it stays off, and if I select 1.8A charge, it sticks. (There may be problems after system suspend and resume. But normal operation seems to be pretty reliable).

Hm... right, bq2415x driver does not have support for suspend/resume. Before suspend registers should be stored and after resume restored, plus check charger auto detection.

Quoted 6 lines

In 4.5-rc0 (7fdec82af6a9e190e53d07a1463d2a9ac49a8750) battery charging works for few hours. But then indicator (yellow light on 3color LED) turns back on, and if I ask for 1.8A charge, it goes back to .1A, discharging battery.

Any ideas?

Look into bq24150a sysfs node what changes. Also if there is something in dmesg.

Quoted 2 lines

Best regards,
Pavel

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160121/a69c7324/attachment.sig>
author
#5 lore raw
Quoted 17 lines · Pali Roh?r
Quoted 6 lines · On Thursday 21 January 2016 19:42:34 Pavel Machek wrote:

Hi!

In 4.4, n900 battery charging works. If indicator is turned off, it stays off, and if I select 1.8A charge, it sticks. (There may be problems after system suspend and resume. But normal operation seems to be pretty reliable).

Hm... right, bq2415x driver does not have support for suspend/resume. Before suspend registers should be stored and after resume restored, plus check charger auto detection.

Quoted 5 lines

In 4.5-rc0 (7fdec82af6a9e190e53d07a1463d2a9ac49a8750) battery charging works for few hours. But then indicator (yellow light on 3color LED) turns back on, and if I ask for 1.8A charge, it goes back to .1A, discharging battery.

Quoted 4 lines
Quoted 1 line

Any ideas?

Look into bq24150a sysfs node what changes. Also if there is something in dmesg.

Hmm, seems like I can't reproduce that any more. I now noticed that if I suspend machine it auto-resumes quickly, so maybe suspend was responsbile. I'll try running 4.5-rc0 for a while...

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html