Missing OMAP PM layer

DISCUSSION Pali Rohár 3 participants 4 messages Jan 24, 2016 – Jan 25, 2016

Share & tools

Pali Rohár

author

2016-01-24 20:23 UTC #0 lore raw

Hello,

make menuconfig allows me to choose "OMAP PM layer selection" and the only one option is CONFIG_OMAP_PM_NOOP "No-op/debug PM layer".

What does it mean? Power manager is noop?

I see that it has only two corresponding files in mainline kernel:
arch/arm/mach-omap2/omap-pm.h arch/arm/mach-omap2/omap-pm-noop.c

Nokia's kernels (for N900 and N950) had also:
arch/arm/mach-omap2/omap-pm-srf.c

Can somebody explain it what happened with omap power management?

Looks like that omap-pm.h provides some API, but the only implementation is noop which do nothing.

Signature · 2 lines

Pali Rohár
[email protected]

Tony Lindgren

2016-01-25 16:34 UTC #1 lore raw

Quoted 11 lines · Pali Rohár

Hello,
make menuconfig allows me to choose "OMAP PM layer selection" and the only one option is CONFIG_OMAP_PM_NOOP "No-op/debug PM layer".
What does it mean? Power manager is noop?
I see that it has only two corresponding files in mainline kernel:
arch/arm/mach-omap2/omap-pm.h arch/arm/mach-omap2/omap-pm-noop.c

Quoted 7 lines

Nokia's kernels (for N900 and N950) had also:
arch/arm/mach-omap2/omap-pm-srf.c
Can somebody explain it what happened with omap power management?
Looks like that omap-pm.h provides some API, but the only implementation is noop which do nothing.

I believe none of that is needed any longer in mainline.

Kevin, care to descrbibe what should be done here?

Regards,

Tony

Pali Rohár

author

2016-01-25 17:24 UTC #2 lore raw

Quoted 15 lines · On Monday 25 January 2016 17:34:42 Tony Lindgren wrote:

Quoted 14 lines · Pali Rohár
Hello,
make menuconfig allows me to choose "OMAP PM layer selection" and the only one option is CONFIG_OMAP_PM_NOOP "No-op/debug PM layer".
What does it mean? Power manager is noop?
I see that it has only two corresponding files in mainline kernel:
arch/arm/mach-omap2/omap-pm.h arch/arm/mach-omap2/omap-pm-noop.c
Nokia's kernels (for N900 and N950) had also:
arch/arm/mach-omap2/omap-pm-srf.c

Quoted 6 lines

Quoted 4 lines
Can somebody explain it what happened with omap power management?
Looks like that omap-pm.h provides some API, but the only implementation is noop which do nothing.
I believe none of that is needed any longer in mainline.

Ok, and what was that omap-pm? Do you know what Nokia omap-pm-srf.c do?

Signature · 2 lines

Pali Rohár
[email protected]

Kevin Hilman

2016-01-25 18:16 UTC #3 lore raw

In reply to Tony Lindgren

Quoted 15 lines · Tony Lindgren

Quoted 14 lines · Pali Rohár
Hello,
make menuconfig allows me to choose "OMAP PM layer selection" and the only one option is CONFIG_OMAP_PM_NOOP "No-op/debug PM layer".
What does it mean? Power manager is noop?
I see that it has only two corresponding files in mainline kernel:
arch/arm/mach-omap2/omap-pm.h arch/arm/mach-omap2/omap-pm-noop.c
Nokia's kernels (for N900 and N950) had also:
arch/arm/mach-omap2/omap-pm-srf.c

Quoted 8 lines

Quoted 4 lines
Can somebody explain it what happened with omap power management?
Looks like that omap-pm.h provides some API, but the only implementation is noop which do nothing.
I believe none of that is needed any longer in mainline.
Kevin, care to descrbibe what should be done here?

We had created the OMAP PM layer as a pluggable layer where we could experiment with different approaches for adding constratints, etc. I can't remember anymore what all was in there, but we gutted most of it after switching to runtime PM.

The SRF was a "shared resource framework" that came out of a TI kernel that was never accepted upstream either, but was one of the implementation of the OMAP PM layer.

Kevin