Skip to contentSkip to conversation

checkpatch: ignore request to use ether_addr_copy()

PATCH New Stephen Warren 2 participants 4 messages Jan 25, 2016

lore
Share & tools
lore

Stephen Warren

author
#0 lore raw

PATCH 1/1 checkpatch: ignore request to use ether_addr_copy()

From: Stephen Warren <[email protected]>

The Linux kernel, from which checkpatch originates, contains function ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns that it should be used in preference to memcpy() where appropriate. U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue this warning.

Signed-off-by Stephen Warren <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Acked-by Joe Hershberger <[email protected]>
---
 .checkpatch.conf | 4 ++++
 1 file changed, 4 insertions(+)
.checkpatch.conf +4 -0
index 35167e12015b..d1d32fac9db5 100644
@@ -21,3 +21,7 @@
 
 # Ignore networking block comment style
 --ignore NETWORKING_BLOCK_COMMENT_STYLE
+
+# Ignore "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
+# addresses are __aligned(2)".
+--ignore PREFER_ETHER_ADDR_COPY
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 checkpatch: ignore request to use ether_addr_copy()

Quoted 11 lines · Stephen Warren

From: Stephen Warren <[email protected]>

The Linux kernel, from which checkpatch originates, contains function ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns that it should be used in preference to memcpy() where appropriate. U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue this warning.

Signed-off-by Stephen Warren <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Acked-by Joe Hershberger <[email protected]>

+CC Tom, Simon

Quoted 9 lines
---
 .checkpatch.conf | 4 ++++
 1 file changed, 4 insertions(+)
.checkpatch.conf +0 -0
index 35167e12015b..d1d32fac9db5 100644

.checkpatch.conf line 27

Quoted 7 lines
.checkpatch.conf +4 -0
@@ -21,3 +21,7 @@
 
 # Ignore networking block comment style
 --ignore NETWORKING_BLOCK_COMMENT_STYLE
+
+# Ignore "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
+# addresses are __aligned(2)".
+--ignore PREFER_ETHER_ADDR_COPY

Best regards,
Marek Vasut

author
#2 lore raw

PATCH 1/1 checkpatch: ignore request to use ether_addr_copy()

Quoted 9 lines · Marek Vasut
Quoted 8 lines · Stephen Warren

From: Stephen Warren <[email protected]>

The Linux kernel, from which checkpatch originates, contains function ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns that it should be used in preference to memcpy() where appropriate. U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue this warning.

Quoted 5 lines
Quoted 3 lines
Signed-off-by Stephen Warren <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Acked-by Joe Hershberger <[email protected]>

+CC Tom, Simon

I believe Tom just applied the original posting of this:

http://lists.denx.de/pipermail/u-boot/2016-January/243151.html
checkpatch: ignore request to use ether_addr_copy()

#3 lore raw

PATCH 1/1 checkpatch: ignore request to use ether_addr_copy()

Quoted 14 lines · Stephen Warren
Quoted 13 lines · Marek Vasut
Quoted 11 lines · Stephen Warren

From: Stephen Warren <[email protected]>

The Linux kernel, from which checkpatch originates, contains function ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns that it should be used in preference to memcpy() where appropriate. U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue this warning.

Signed-off-by Stephen Warren <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Acked-by Joe Hershberger <[email protected]>
Quoted 6 lines
Quoted 1 line

+CC Tom, Simon

I believe Tom just applied the original posting of this:

http://lists.denx.de/pipermail/u-boot/2016-January/243151.html
checkpatch: ignore request to use ether_addr_copy()

Well then, that's fine. Thanks!

Best regards,
Marek Vasut