Skip to contentSkip to conversation

watchdog: Add watchdog timer support for the WinSystems EBC-C384

PATCH William Breathitt Gray 2 participants 2 messages Jan 26, 2016 Watchdog device drivers

lore
Share & tools
lore

William Breathitt Gray

author
#0 lore raw
Quoted 4 lines · Guenter Roeck

Review

Quoted 2 lines
(quoted diff) +2 -0
+		dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
+			timeout, WATCHDOG_TIMEOUT);

Multi-line alignment is off by one character.

I used tabs to align the lines to 8-character boundaries. Should I add an additional space to align the "timeout" argument with the "dev" argument?

William Breathitt Gray

maintainer
#1 lore raw
Quoted 10 lines · William Breathitt Gray
Quoted 4 lines · Guenter Roeck

Review

Quoted 2 lines
(quoted diff) +2 -0
+		dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
+			timeout, WATCHDOG_TIMEOUT);

Multi-line alignment is off by one character.

I used tabs to align the lines to 8-character boundaries. Should I add an additional space to align the "timeout" argument with the "dev" argument?

Continuation line alignment should be with "(", so, yes, on the same column as "dev".

Thanks,
Guenter