Skip to contentSkip to conversation

ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore

PATCH New Mark Brown 3 participants 3 messages Jan 21, 2016 – Jan 26, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore

The Cragganmore machine driver provides platform data for the generic GPIO platform driver which uses structures only defined if the driver is enabled. Since there is little reason to use the platform without the GPIOs add a select to avoid build failures.

Signed-off-by Mark Brown <[email protected]>
---
 arch/arm/mach-s3c64xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-s3c64xx/Kconfig +1 -0
index 7c0c420c3016..98d2aa9393f1 100644
@@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
 	depends on I2C=y
 	select CPU_S3C6410
 	select LEDS_GPIO_REGISTER
+	select GPIO_GENERIC_PLATFORM
 	select S3C64XX_DEV_SPI0
 	select S3C64XX_SETUP_FB_24BPP
 	select S3C64XX_SETUP_I2C1
Signature · 1 line
2.7.0.rc3
#1 lore raw

PATCH 1/1 ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore

Quoted 16 lines · Mark Brown

The Cragganmore machine driver provides platform data for the generic GPIO platform driver which uses structures only defined if the driver is enabled. Since there is little reason to use the platform without the GPIOs add a select to avoid build failures.

Signed-off-by Mark Brown <[email protected]>
---
 arch/arm/mach-s3c64xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-s3c64xx/Kconfig +0 -0
index 7c0c420c3016..98d2aa9393f1 100644

arch/arm/mach-s3c64xx/Kconfig config MACH_WLF_CRAGG_6410 · line 316

Quoted 7 lines
arch/arm/mach-s3c64xx/Kconfig +1 -0
@@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
 	depends on I2C=y
 	select CPU_S3C6410
 	select LEDS_GPIO_REGISTER
+	select GPIO_GENERIC_PLATFORM
 	select S3C64XX_DEV_SPI0
 	select S3C64XX_SETUP_FB_24BPP
 	select S3C64XX_SETUP_I2C1

Thanks for the patch!
This was already fixed by Arnd:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2

Best regards,
Krzysztof

#2 lore raw

PATCH 1/1 ARM: s3c64xx: Select GPIO_GENERIC_PLATFORM for Cragganmore

In reply to Mark Brown
Quoted 7 lines · Mark Brown

The Cragganmore machine driver provides platform data for the generic GPIO platform driver which uses structures only defined if the driver is enabled. Since there is little reason to use the platform without the GPIOs add a select to avoid build failures.

Signed-off-by Mark Brown <[email protected]>

---

All looks good to me and doesn't cause any issues on my Speyside.

Tested-by Charles Keepax <[email protected]>

Thanks,
Charles