Skip to contentSkip to conversation

Polish translation update + localization remark for xfsprogs 4.3.0

PATCH In review Jakub Bogusz 3 participants 4 messages Jan 24, 2016 – Jan 26, 2016

lore
Share & tools
lore
#0 lore raw

Hello,

I've just updated Polish translation for xfsprogs 4.3.0, it's available at:
http://qboosh.pl/pl.po/xfsprogs-4.3.0.pl.po

I have noticed untranslatable message part in repair/versions.c:228:

_("WARNING: you have a V1 inode filesystem. It %s be converted to a\n"
"\tversion 2 inode filesystem. If you do not want this, run an older\n" "\tversion of xfs_repair.\n"), no_modify ? "would" : "will");

There are untranslatable "would"/"will" strings.
This code could look for example like this:

_("WARNING: you have a V1 inode filesystem. %s to a\n"
"\tversion 2 inode filesystem. If you do not want this, run an older\n" "\tversion of xfs_repair.\n"),
no_modify ? _("It would be converted") : _("It will be converted"));

(note: using _("would") : _("will") is not enough - these words are untranslatable to many languages without wider context)

Signature · 6 lines
Jakub Bogusz    http://qboosh.pl/

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#1 lore raw

PATCH 1/1 xfs_repair: Fix untranslatable strings

Don't substitute in "would" or "will" for %s here, it makes it untranslatable. Just spell it out twice like every other message in the function.

---

repair/versions.c +10 -3
index 1585385..978f48b 100644
@@ -224,10 +224,17 @@ _("WARNING:  you have disallowed attr2 attributes but this filesystem\n"
 	}
 
 	if (!(sb->sb_versionnum & XFS_SB_VERSION_NLINKBIT)) {
-		do_warn(
-_("WARNING: you have a V1 inode filesystem. It %s be converted to a\n"
+		if (!no_modify) {
+			do_warn(
+_("WARNING: you have a V1 inode filesystem. It will be converted to a\n"
   "\tversion 2 inode filesystem. If you do not want this, run an older\n"
-  "\tversion of xfs_repair.\n"), no_modify ? "would" : "will");
+  "\tversion of xfs_repair.\n"));
+		} else  {
+			do_warn(
+_("WARNING: you have a V1 inode filesystem. It would be converted to a\n"
+  "\tversion 2 inode filesystem. If you do not want this, run an older\n"
+  "\tversion of xfs_repair.\n"));
+		}
 	}
 
 	if (xfs_sb_version_hasquota(sb))  {

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] xfs_repair: Fix untranslatable strings

Quoted 6 lines · Eric Sandeen

Don't substitute in "would" or "will" for %s here, it makes it untranslatable. Just spell it out twice like every other message in the function.

Looks good,

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs