Skip to contentSkip to conversation

drm/i915: Capture revision id in error state

PATCH In review Arun Siluvery 5 participants 11 messages Jan 26, 2016 – Feb 10, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Capture revision id in error state

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state.

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_gpu_error.c +1 -0
index 7eeb244..f3ddc3b 100644
@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);
 	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
 	if (HAS_CSR(dev)) {
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 13 lines · Arun Siluvery

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state.

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_gpu_error.c +0 -0
index 7eeb244..f3ddc3b 100644

drivers/gpu/drm/i915/i915_gpu_error.c int i915_error_state_to_str(struct drm_i915_error_state_buf *m, · line 368

Quoted 4 lines
drivers/gpu/drm/i915/i915_gpu_error.c +1 -0
@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);

"PCI revision" maybe?

Quoted 10 lines
drivers/gpu/drm/i915/i915_gpu_error.c +0 -0
 	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
 	if (HAS_CSR(dev)) {
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 9 lines · Ville Syrjälä
Quoted 8 lines · Arun Siluvery

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state.

---
  drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 11 lines

drivers/gpu/drm/i915/i915_gpu_error.c int i915_error_state_to_str(struct drm_i915_error_state_buf *m, · line 368

Quoted 9 lines
drivers/gpu/drm/i915/i915_gpu_error.c +1 -0
index 7eeb244..f3ddc3b 100644
@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
  	err_printf(m, "Reset count: %u\n", error->reset_count);
  	err_printf(m, "Suspend count: %u\n", error->suspend_count);
  	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);

"PCI revision" maybe?

sure, makes it more clear.

regards
Arun

Quoted 12 lines
Quoted 11 lines
drivers/gpu/drm/i915/i915_gpu_error.c +0 -1
  	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
  	if (HAS_CSR(dev)) {
--

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 21 lines · Arun Siluvery
Quoted 9 lines · Ville Syrjälä
Quoted 8 lines · Arun Siluvery

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state.

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

drivers/gpu/drm/i915/i915_gpu_error.c int i915_error_state_to_str(struct drm_i915_error_state_buf *m, · line 368

Quoted 9 lines
drivers/gpu/drm/i915/i915_gpu_error.c +1 -0
index 7eeb244..f3ddc3b 100644
@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);

"PCI revision" maybe?

Quoted 1 line

sure, makes it more clear.

We also use the subvendor ids, so if we might as well dump the full PCI ID whilst we are making an adjustment here.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Capture revision id in error state

In reply to Arun Siluvery
== Summary ==

== Summary ==

Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly: 2016y-01m-27d-16h-33m-06s UTC integration manifest

Test kms_pipe_crc_basic:

        Subgroup read-crc-pipe-b:
                dmesg-warn -> PASS       (ilk-hp8440p)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> FAIL       (byt-nuc)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> FAIL       (byt-nuc)
        Subgroup suspend-read-crc-pipe-c:
                skip       -> FAIL       (byt-nuc)
bdw-nuci7        total:141  pass:132  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:144  pass:138  dwarn:0   dfail:0   fail:0   skip:6  
bsw-nuc-2        total:144  pass:120  dwarn:0   dfail:0   fail:0   skip:24 
byt-nuc          total:144  pass:127  dwarn:0   dfail:0   fail:3   skip:14 
hsw-brixbox      total:144  pass:137  dwarn:0   dfail:0   fail:0   skip:7  
hsw-gt2          total:144  pass:140  dwarn:0   dfail:0   fail:0   skip:4  
ilk-hp8440p      total:144  pass:105  dwarn:0   dfail:0   fail:1   skip:38 
ivb-t430s        total:144  pass:138  dwarn:0   dfail:0   fail:0   skip:6  
skl-i5k-2        total:144  pass:135  dwarn:1   dfail:0   fail:0   skip:8  
snb-dellxps      total:144  pass:130  dwarn:0   dfail:0   fail:0   skip:14 
snb-x220t        total:144  pass:130  dwarn:0   dfail:0   fail:1   skip:13 

Results at /archive/results/CI_IGT_test/Patchwork_1268/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Capture revision id in error state

In reply to Arun Siluvery
== Summary ==

== Summary ==

Series 2850v1 drm/i915: Capture revision id in error state
http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/1/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-modeset:
                pass       -> DMESG-WARN (bsw-nuc-2)
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:159  pass:153  dwarn:0   dfail:0   fail:0   skip:6  
bsw-nuc-2        total:159  pass:134  dwarn:1   dfail:0   fail:0   skip:24 
byt-nuc          total:159  pass:142  dwarn:0   dfail:0   fail:0   skip:17 
hsw-brixbox      total:159  pass:152  dwarn:0   dfail:0   fail:0   skip:7  
hsw-gt2          total:159  pass:155  dwarn:0   dfail:0   fail:0   skip:4  
ilk-hp8440p      total:159  pass:113  dwarn:1   dfail:0   fail:1   skip:44 
ivb-t430s        total:159  pass:151  dwarn:0   dfail:0   fail:0   skip:8  
snb-dellxps      total:159  pass:141  dwarn:0   dfail:0   fail:0   skip:18 
snb-x220t        total:159  pass:141  dwarn:0   dfail:0   fail:1   skip:17 

HANGED skl-i5k-2 in igt@gem_sync@basic-blt

Results at /archive/results/CI_IGT_test/Patchwork_1297/

b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest 0c76833e1e379768b1151bdc7f04340695174d44 drm/i915: Capture revision id in error state

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

PATCH 1/1 drm/i915: Capture PCI revision and subsytem details in error state

In reply to Arun Siluvery

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state.

v2: make it clear that it is PCI revision and We might as well dump PCI subsystem details while we update this (Ville, Chris).

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/i915_gpu_error.c +4 -0
index 7eeb244..978c026 100644
@@ -365,6 +365,10 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "PCI Revision: 0x%02x\n", dev->pdev->revision);
+	err_printf(m, "PCI Subsystem: %04x:%04x\n",
+		   dev->pdev->subsystem_vendor,
+		   dev->pdev->subsystem_device);
 	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
 	if (HAS_CSR(dev)) {
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

Re: [PATCH] drm/i915: Capture PCI revision and subsytem details in error state

Quoted 8 lines · Arun Siluvery

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state.

v2: make it clear that it is PCI revision and We might as well dump PCI subsystem details while we update this (Ville, Chris).

Queued for -next, thanks for the patch.
-Daniel

Quoted 26 lines
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/i915_gpu_error.c +4 -0
index 7eeb244..978c026 100644
@@ -365,6 +365,10 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "Reset count: %u\n", error->reset_count);
 	err_printf(m, "Suspend count: %u\n", error->suspend_count);
 	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
+	err_printf(m, "PCI Revision: 0x%02x\n", dev->pdev->revision);
+	err_printf(m, "PCI Subsystem: %04x:%04x\n",
+		   dev->pdev->subsystem_vendor,
+		   dev->pdev->subsystem_device);
 	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
 
 	if (HAS_CSR(dev)) {
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)

In reply to Arun Siluvery
== Summary ==

== Summary ==

Series 2850v2 drm/i915: Capture revision id in error state
http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (ilk-hp8440p)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-1:
                pass       -> DMESG-WARN (hsw-gt2)
        Subgroup nonblocking-crc-pipe-a:
                skip       -> PASS       (byt-nuc)
        Subgroup nonblocking-crc-pipe-b:
                pass       -> DMESG-WARN (ilk-hp8440p)
bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12 
bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30 
byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23 
hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13 
hsw-gt2          total:159  pass:148  dwarn:1   dfail:0   fail:0   skip:10 
ilk-hp8440p      total:159  pass:108  dwarn:2   dfail:0   fail:0   skip:49 
ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14 
skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14 
snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22 
snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1313/

5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest 76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)

Quoted 8 lines · Patchwork

== Summary ==

Series 2850v2 drm/i915: Capture revision id in error state
http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/

Test kms_flip:

         Subgroup basic-flip-vs-dpms:
                 pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE

[BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on ilk-hp8440p known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787

Quoted 3 lines

Test kms_force_connector_basic:

         Subgroup prune-stale-modes:
                 pass       -> SKIP       (ilk-hp8440p)

It is not showing up in patchwork results page.

Quoted 3 lines

Test kms_pipe_crc_basic:

         Subgroup bad-nb-words-1:
                 pass       -> DMESG-WARN (hsw-gt2)

known issue, it is not on P1 list though,
https://bugs.freedesktop.org/show_bug.cgi?id=93226

Quoted 2 lines
         Subgroup nonblocking-crc-pipe-a:
                 skip       -> PASS       (byt-nuc)

It is not showing up in patchwork results page, checked detailed results page and it was skipped once before.

Quoted 2 lines
         Subgroup nonblocking-crc-pipe-b:
                 pass       -> DMESG-WARN (ilk-hp8440p)

[BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on ilk-hp8440p known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787

regards
Arun

Quoted 13 lines
bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9
bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12
bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30
byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23
hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13
hsw-gt2          total:159  pass:148  dwarn:1   dfail:0   fail:0   skip:10
ilk-hp8440p      total:159  pass:108  dwarn:2   dfail:0   fail:0   skip:49
ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14
skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14
snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22
snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1313/

5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest 76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Re: ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2)

Quoted 21 lines · Arun Siluvery
Quoted 8 lines · Patchwork

== Summary ==

Series 2850v2 drm/i915: Capture revision id in error state
http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE

[BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on ilk-hp8440p
known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787

Quoted 3 lines

Test kms_force_connector_basic:

        Subgroup prune-stale-modes:
                pass       -> SKIP       (ilk-hp8440p)

It is not showing up in patchwork results page.

Quoted 3 lines

Test kms_pipe_crc_basic:

        Subgroup bad-nb-words-1:
                pass       -> DMESG-WARN (hsw-gt2)
Quoted 8 lines

known issue, it is not on P1 list though,
https://bugs.freedesktop.org/show_bug.cgi?id=93226

Quoted 2 lines
        Subgroup nonblocking-crc-pipe-a:
                skip       -> PASS       (byt-nuc)

It is not showing up in patchwork results page, checked detailed results page and it was skipped once before.

Yeah, something is broken with the edid injection and seems racy, resulting in corruption and who knows what else. Not sure what's going on, but the overall issue is tracked as P1 in

https://bugs.freedesktop.org/show_bug.cgi?id=93769

Quoted 34 lines
Quoted 3 lines
        Subgroup nonblocking-crc-pipe-b:
                pass       -> DMESG-WARN (ilk-hp8440p)

[BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on ilk-hp8440p
known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787

regards
Arun

Quoted 13 lines
bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9
bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12
bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30
byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23
hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13
hsw-gt2          total:159  pass:148  dwarn:1   dfail:0   fail:0   skip:10
ilk-hp8440p      total:159  pass:108  dwarn:2   dfail:0   fail:0   skip:49
ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14
skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14
snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22
snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1313/

5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest 76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx