ARM: dts: am4372: fix irq type for arm twd and global timer

PATCH New Grygorii Strashko 2 participants 2 messages Dec 28, 2015 – Jan 27, 2016 Device tree bindings

Share & tools

Grygorii Strashko

author

2015-12-28 13:52 UTC #0 lore raw

PATCH 1/1 ARM: dts: am4372: fix irq type for arm twd and global timer

As per ARM documentation
PPI(0) ID27 - global timer interrupt is rising-edge sensitive. PPI(2) ID29 - twd interrupt is rising-edge sensitive.

and the same is proved by GIC distributor register value GIC_DIST_CONFIG(0xC04) = 0x7DC00000.

Hence, set IRQ triggering type to IRQ_TYPE_EDGE_RISING for ARM TWD and Global timers.

Signed-off-by Grygorii Strashko <[email protected]>

---
 arch/arm/boot/dts/am4372.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/am4372.dtsi +2 -2

index de8791a..dfa1a29 100644
@@ -72,7 +72,7 @@
 	global_timer: timer at 48240200 {
 		compatible = "arm,cortex-a9-global-timer";
 		reg = <0x48240200 0x100>;
-		interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>;
 		interrupt-parent = <&gic>;
 		clocks = <&mpu_periphclk>;
 	};

@@ -80,7 +80,7 @@
 	local_timer: timer at 48240600 {
 		compatible = "arm,cortex-a9-twd-timer";
 		reg = <0x48240600 0x100>;
-		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <GIC_PPI 13 IRQ_TYPE_EDGE_RISING>;
 		interrupt-parent = <&gic>;
 		clocks = <&mpu_periphclk>;
 	};

Signature · 1 line

2.6.4

Tony Lindgren

2016-01-27 16:47 UTC #1 lore raw

PATCH 1/1 ARM: dts: am4372: fix irq type for arm twd and global timer

Quoted 9 lines · Grygorii Strashko

As per ARM documentation
PPI(0) ID27 - global timer interrupt is rising-edge sensitive. PPI(2) ID29 - twd interrupt is rising-edge sensitive.
and the same is proved by GIC distributor register value GIC_DIST_CONFIG(0xC04) = 0x7DC00000.
Hence, set IRQ triggering type to IRQ_TYPE_EDGE_RISING for ARM TWD and Global timers.

Applying into omap-for-v4.5/fixes thanks.

Tony