Skip to contentSkip to conversation

ARM: dts: am437x: pixcir_tangoc: use correct flags for irq types

PATCH New Grygorii Strashko 2 participants 2 messages Dec 28, 2015 – Jan 27, 2016 Device tree bindings

lore
Share & tools
lore

Grygorii Strashko

author
#0 lore raw

PATCH 1/1 ARM: dts: am437x: pixcir_tangoc: use correct flags for irq types

Now IRQs for Pixcir Tangoc touchscreen are defined using IRQ_TYPE_NONE in am437x-gp-evm.dts and am43x-epos-evm.dts wich do not correspond HW.

Hence, update am437x-gp-evm.dts and am43x-epos-evm.dts files and use correct flag IRQ_TYPE_EDGE_FALLING for irq types.

While here, remove duplicated irq declaration for pixcir_ts at 5c node in am437x-gp-evm.dts.

Signed-off-by Grygorii Strashko <[email protected]>
---
 arch/arm/boot/dts/am437x-gp-evm.dts  | 4 +---
 arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/am437x-gp-evm.dts +1 -3
index d2450ab..fc4c371 100644
@@ -590,8 +590,6 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&pixcir_ts_pins>;
 		reg = <0x5c>;
-		interrupt-parent = <&gpio3>;
-		interrupts = <22 0>;
 
 		attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
 

@@ -599,7 +597,7 @@
 		 * 0x264 represents the offset of padconf register of
 		 * gpio3_22 from am43xx_pinmux base.
 		 */
-		interrupts-extended = <&gpio3 22 IRQ_TYPE_NONE>,
+		interrupts-extended = <&gpio3 22 IRQ_TYPE_EDGE_FALLING>,
 				      <&am43xx_pinmux 0x264>;
 		interrupt-names = "tsc", "wakeup";
arch/arm/boot/dts/am43x-epos-evm.dts +1 -1
index 47954ed..29c6580 100644
@@ -491,7 +491,7 @@
 		pinctrl-0 = <&pixcir_ts_pins>;
 		reg = <0x5c>;
 		interrupt-parent = <&gpio1>;
-		interrupts = <17 0>;
+		interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
 
 		attb-gpio = <&gpio1 17 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.6.4
#1 lore raw

PATCH 1/1 ARM: dts: am437x: pixcir_tangoc: use correct flags for irq types

Quoted 9 lines · Grygorii Strashko

Now IRQs for Pixcir Tangoc touchscreen are defined using IRQ_TYPE_NONE in am437x-gp-evm.dts and am43x-epos-evm.dts wich do not correspond HW.

Hence, update am437x-gp-evm.dts and am43x-epos-evm.dts files and use correct flag IRQ_TYPE_EDGE_FALLING for irq types.

While here, remove duplicated irq declaration for pixcir_ts at 5c node in am437x-gp-evm.dts.

Applying into omap-for-v4.5/fixes thanks.

Tony