Skip to contentSkip to conversation

ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

PATCH New Roger Shimizu 2 participants 6 messages Jan 27, 2016 – Feb 2, 2016 Device tree bindings

lore
Share & tools
lore

Roger Shimizu

author
#0 lore raw

PATCH 1/1 ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

MTD flash stores u-boot and u-boot environment on linkstation lswtgl. The latter one can be easily read/write by u-boot-tools package in Debian.

Signed-off-by Roger Shimizu <[email protected]>
---
 arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts | 30 ++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +30 -0
index 420788229e6f..16eabc524b27 100644
@@ -228,6 +228,36 @@
 	};
 };
 
+&devbus_bootcs {
+	status = "okay";
+	devbus,keep-config;
+
+	flash at 0 {
+		compatible = "jedec-flash";
+		reg = <0 0x40000>;
+		bank-width = <1>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		partition at 0 {
+			label = "header";
+			reg = <0 0x30000>;
+			read-only;
+		};
+
+		partition at 30000 {
+			label = "uboot";
+			reg = <0x30000 0xF000>;
+			read-only;
+		};
+
+		partition at 3F000 {
+			label = "uboot_env";
+			reg = <0x3F000 0x1000>;
+		};
+	};
+};
+
 &mdio {
 	status = "okay";
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

Quoted 17 lines · Roger Shimizu

MTD flash stores u-boot and u-boot environment on linkstation lswtgl. The latter one can be easily read/write by u-boot-tools package in Debian.

Signed-off-by Roger Shimizu <[email protected]>
---
 arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts | 30 ++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +1 -0
index 420788229e6f..16eabc524b27 100644
@@ -228,6 +228,36 @@
 	};
 };
 
+&devbus_bootcs {

arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts line 241

Quoted 10 lines
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +10 -0
+	status = "okay";
+	devbus,keep-config;
+
+	flash at 0 {
+		compatible = "jedec-flash";
+		reg = <0 0x40000>;
+		bank-width = <1>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+

Hi Roger

Same comment i just sent to Thomas:

The partition table should be a subnode of the mtd node and should be named 'partitions'. This node should have the following property:
- compatible : (required) must be "fixed-partitions"
Partitions are then defined in subnodes of the partitions node.

For backwards compatibility partitions as direct subnodes of the mtd device are supported. This use is discouraged.

Andrew

Quoted 25 lines
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +19 -0
+		partition at 0 {
+			label = "header";
+			reg = <0 0x30000>;
+			read-only;
+		};
+
+		partition at 30000 {
+			label = "uboot";
+			reg = <0x30000 0xF000>;
+			read-only;
+		};
+
+		partition at 3F000 {
+			label = "uboot_env";
+			reg = <0x3F000 0x1000>;
+		};
+	};
+};
+
 &mdio {
 	status = "okay";
Signature · 1 line
2.1.4
author
#2 lore raw

PATCH 1/1 ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

Dear Andrew,

Quoted 66 lines · Andrew Lunn
Quoted 17 lines · Roger Shimizu

MTD flash stores u-boot and u-boot environment on linkstation lswtgl. The latter one can be easily read/write by u-boot-tools package in Debian.

Signed-off-by Roger Shimizu <[email protected]>
---
 arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts | 30 ++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +1 -0
index 420788229e6f..16eabc524b27 100644
@@ -228,6 +228,36 @@
      };
 };
 
+&devbus_bootcs {

arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts line 241

Quoted 10 lines
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +10 -0
+     status = "okay";
+     devbus,keep-config;
+
+     flash at 0 {
+             compatible = "jedec-flash";
+             reg = <0 0x40000>;
+             bank-width = <1>;
+             #address-cells = <1>;
+             #size-cells = <1>;
+

Hi Roger

Same comment i just sent to Thomas:

The partition table should be a subnode of the mtd node and should be named 'partitions'. This node should have the following property:
- compatible : (required) must be "fixed-partitions"
Partitions are then defined in subnodes of the partitions node.

For backwards compatibility partitions as direct subnodes of the mtd device are supported. This use is discouraged.

Andrew

Quoted 22 lines
arch/arm/boot/dts/orion5x-linkstation-lswtgl.dts +19 -0
+             partition at 0 {
+                     label = "header";
+                     reg = <0 0x30000>;
+                     read-only;
+             };
+
+             partition at 30000 {
+                     label = "uboot";
+                     reg = <0x30000 0xF000>;
+                     read-only;
+             };
+
+             partition at 3F000 {
+                     label = "uboot_env";
+                     reg = <0x3F000 0x1000>;
+             };
+     };
+};
+
 &mdio {
      status = "okay";
Quoted 3 lines
Quoted 3 lines

--
2.1.4

Thanks for your comments!

Using the patch I submitted result in:

[    1.667440] Found: SST 39LF020
[    1.670613] f4000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank
[    1.676948] number of JEDEC chips: 1
[    1.698943] 3 ofpart partitions found on MTD device f4000000.flash
[    1.705222] Creating 3 MTD partitions on "f4000000.flash":
[    1.710803] 0x000000000000-0x000000030000 : "header"
[    1.719051] 0x000000030000-0x00000003f000 : "uboot"
[    1.727182] 0x00000003f000-0x000000040000 : "uboot_env"

Applying the partition DT proposed in Documentation/devicetree/bindings/mtd/partition.txt, result in:

[    1.667879] Found: SST 39LF020
[    1.671053] f4000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank
[    1.677389] number of JEDEC chips: 1

So the partitions are gone.

My modified DT is like:

&devbus_bootcs {
    status = "okay";
    devbus,keep-config;

    flash at 0 {
        compatible = "jedec-flash";
        reg = <0 0x40000>;
        bank-width = <1>;
        #address-cells = <1>;
        #size-cells = <1>;

        partitions {
            compatible = "fixed-partitions";
            #address-cells = <1>;
            #size-cells = <1>;

            partition at 0 {
                label = "header";
                reg = <0 0x30000>;
                read-only;
            };

            partition at 30000 {
                label = "uboot";
                reg = <0x30000 0xF000>;
                read-only;
            };

            partition at 3F000 {
                label = "uboot_env";
                reg = <0x3F000 0x1000>;
            };
        };
    };
};

Any comment would be appreciated!

Cheers,

Signature · 2 lines
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1
author
#3 lore raw

PATCH 1/1 ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

Dear Andrew,

Quoted 26 lines · Roger Shimizu
Quoted 11 lines · Andrew Lunn

Same comment i just sent to Thomas:

The partition table should be a subnode of the mtd node and should be named 'partitions'. This node should have the following property:
- compatible : (required) must be "fixed-partitions"
Partitions are then defined in subnodes of the partitions node.

For backwards compatibility partitions as direct subnodes of the mtd device are supported. This use is discouraged.

Andrew

Thanks for your comments!

Using the patch I submitted result in:

[    1.667440] Found: SST 39LF020
[    1.670613] f4000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank
[    1.676948] number of JEDEC chips: 1
[    1.698943] 3 ofpart partitions found on MTD device f4000000.flash
[    1.705222] Creating 3 MTD partitions on "f4000000.flash":
[    1.710803] 0x000000000000-0x000000030000 : "header"
[    1.719051] 0x000000030000-0x00000003f000 : "uboot"
[    1.727182] 0x00000003f000-0x000000040000 : "uboot_env"
Quoted 8 lines

Applying the partition DT proposed in Documentation/devicetree/bindings/mtd/partition.txt, result in:

[    1.667879] Found: SST 39LF020
[    1.671053] f4000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank
[    1.677389] number of JEDEC chips: 1

So the partitions are gone.

Now I'm thinking for my dts's case, which is orion5x, refer
- Documentation/devicetree/bindings/mtd/mtd-physmap.txt
- Documentation/devicetree/bindings/mtd/orion-nand.txt would be more proper.
And in the sample of mtd-physmap.txt, the structure described in partition.txt is not mentioned.

Could we go as the dts is, like the original patch I submitted?

Cheers,
Roger

author
#4 lore raw

PATCH 1/1 ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

Dear Andrew,

Quoted 38 lines · Roger Shimizu

Dear Andrew,

Quoted 26 lines · Roger Shimizu
Quoted 11 lines · Andrew Lunn

Same comment i just sent to Thomas:

The partition table should be a subnode of the mtd node and should be named 'partitions'. This node should have the following property:
- compatible : (required) must be "fixed-partitions"
Partitions are then defined in subnodes of the partitions node.

For backwards compatibility partitions as direct subnodes of the mtd device are supported. This use is discouraged.

Andrew

Thanks for your comments!

Using the patch I submitted result in:

[    1.667440] Found: SST 39LF020
[    1.670613] f4000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank
[    1.676948] number of JEDEC chips: 1
[    1.698943] 3 ofpart partitions found on MTD device f4000000.flash
[    1.705222] Creating 3 MTD partitions on "f4000000.flash":
[    1.710803] 0x000000000000-0x000000030000 : "header"
[    1.719051] 0x000000030000-0x00000003f000 : "uboot"
[    1.727182] 0x00000003f000-0x000000040000 : "uboot_env"
Quoted 8 lines

Applying the partition DT proposed in Documentation/devicetree/bindings/mtd/partition.txt, result in:

[    1.667879] Found: SST 39LF020
[    1.671053] f4000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank
[    1.677389] number of JEDEC chips: 1

So the partitions are gone.

Quoted 8 lines

Now I'm thinking for my dts's case, which is orion5x, refer
- Documentation/devicetree/bindings/mtd/mtd-physmap.txt
- Documentation/devicetree/bindings/mtd/orion-nand.txt would be more proper.
And in the sample of mtd-physmap.txt, the structure described in partition.txt is not mentioned.

Could we go as the dts is, like the original patch I submitted?

I find "Documentation/devicetree/bindings/mtd/partition.txt" is quite new and was just updated in kernel 4.4.
So I tried "linux-image-4.4.0-trunk-orion5x" in Debian experimental repo, YES, with my updated dts, the MTD goes back to work as partitioned as before.

In this way, if I write dts for partition like this, user cannot simply take dtb from kernel 4.4/4.5 to their stable kernel (such as Debian Jessie's 3.16-ckt series).
For some advanced functionality, this kind of non-backport capable change is deserved; but for partitions IMHO it doesn't deserve, especially for a device/platform existing for more than 5 years.

What do you think?

Signature · 2 lines
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1
#5 lore raw

PATCH 1/1 ARM: dts: orion5x: add mtd flash support to linkstation lswtgl

Quoted 6 lines

I find "Documentation/devicetree/bindings/mtd/partition.txt" is quite new and was just updated in kernel 4.4.
So I tried "linux-image-4.4.0-trunk-orion5x" in Debian experimental repo, YES, with my updated dts, the MTD goes back to work as partitioned as before.

Quoted 8 lines

In this way, if I write dts for partition like this, user cannot simply take dtb from kernel 4.4/4.5 to their stable kernel (such as Debian Jessie's 3.16-ckt series).
For some advanced functionality, this kind of non-backport capable change is deserved; but for partitions IMHO it doesn't deserve, especially for a device/platform existing for more than 5 years.

What do you think?

Since this might be used with older Debian kernel, skipping the partitions subnode is O.K. for me.

Andrew