Skip to contentSkip to conversation

amixer: skip showing asoc tlv byte controls

PATCH Superseded Vinod Koul 2 participants 3 messages Jan 28, 2016

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH v3 1/1 amixer: skip showing asoc tlv byte controls

ASoC TLV Byte controls are very large size controls so we should add new options for these. So skip dumping contents for these.

$amixer -c0 cget numid=16
numid=16,iface=MIXER,name='mdl params'
; type=BYTES,access=-----RW-,values=30336
: ASoC TLV Byte control, skipping bytes dump

---
 amixer/amixer.c | 8 ++++++++
 1 file changed, 8 insertions(+)
amixer/amixer.c +8 -0
index db1849333da3..e059c176f958 100644
@@ -682,6 +682,14 @@ static int show_control(const char *space, snd_hctl_elem_t *elem,
 	      __skip_read:
 		if (!snd_ctl_elem_info_is_tlv_readable(info))
 			goto __skip_tlv;
+		/* skip ASoC ext bytes controls that may have huge binary TLV data */
+		if (type == SND_CTL_ELEM_TYPE_BYTES &&
+				!snd_ctl_elem_info_is_readable(info) &&
+				!snd_ctl_elem_info_is_writable(info)) {
+			printf("%s: ASoC TLV Byte control, skipping bytes dump\n", space);
+			goto __skip_tlv;
+		}
+
 		tlv = malloc(4096);
 		if ((err = snd_hctl_elem_tlv_read(elem, tlv, 4096)) < 0) {
 			error("Control %s element TLV read error: %s\n", card, snd_strerror(err));
Signature · 1 line
1.9.1
#1 lore raw
Quoted 8 lines · Vinod Koul

ASoC TLV Byte controls are very large size controls so we should add new options for these. So skip dumping contents for these.

$amixer -c0 cget numid=16
numid=16,iface=MIXER,name='mdl params'
; type=BYTES,access=-----RW-,values=30336
: ASoC TLV Byte control, skipping bytes dump

Use semicolon instead.

Takashi

Quoted 28 lines
---
 amixer/amixer.c | 8 ++++++++
 1 file changed, 8 insertions(+)
amixer/amixer.c +8 -0
index db1849333da3..e059c176f958 100644
@@ -682,6 +682,14 @@ static int show_control(const char *space, snd_hctl_elem_t *elem,
 	      __skip_read:
 		if (!snd_ctl_elem_info_is_tlv_readable(info))
 			goto __skip_tlv;
+		/* skip ASoC ext bytes controls that may have huge binary TLV data */
+		if (type == SND_CTL_ELEM_TYPE_BYTES &&
+				!snd_ctl_elem_info_is_readable(info) &&
+				!snd_ctl_elem_info_is_writable(info)) {
+			printf("%s: ASoC TLV Byte control, skipping bytes dump\n", space);
+			goto __skip_tlv;
+		}
+
 		tlv = malloc(4096);
 		if ((err = snd_hctl_elem_tlv_read(elem, tlv, 4096)) < 0) {
 			error("Control %s element TLV read error: %s\n", card, snd_strerror(err));
Signature · 1 line
1.9.1
author
#2 lore raw
Quoted 6 lines · Takashi Iwai
Quoted 4 lines · Vinod Koul

ASoC TLV Byte controls are very large size controls so we should add new options for these. So skip dumping contents for these.

Quoted 6 lines
Quoted 4 lines

$amixer -c0 cget numid=16
numid=16,iface=MIXER,name='mdl params'
; type=BYTES,access=-----RW-,values=30336
: ASoC TLV Byte control, skipping bytes dump

Use semicolon instead.

Sure, I tried to use the existing style, what is the interpretation of these?

Signature · 1 line
~Vinod