numa_node_size: drop definition of numa_exit_on_error
PATCH 1/1 numa_node_size: drop definition of numa_exit_on_error
numa_exit_on_error is defined by numactl library in libnuma.c, at least since version 0.9. Re-defining it in test can cause compile problems.
--- testcases/kernel/numa/numa_node_size.c | 1 - 1 file changed, 1 deletion(-)
testcases/kernel/numa/numa_node_size.c +0 -1
@@ -38,7 +38,6 @@#include <numa.h> #endif -int numa_exit_on_error =0 ;char *fmt_mem (unsigned long long mem,char *buf) {if (mem ==-1L )
Signature · 1 line
1.8.3.1
PATCH 1/1 numa_node_size: drop definition of numa_exit_on_error
Hi!
Quoted 3 lines
numa_exit_on_erroris defined by numactl library inlibnuma.c, at least since version 0.9. Re-defining it in test can cause compile problems.
I've tried to rebuild LTP without the line in question on couple of SUSE distros and it haven't caused any problems. I wonder why it wasn't failing the compilation before though, the variable is defined right in the libnuma.c in the library.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 numa_node_size: drop definition of numa_exit_on_error
----- Original Message -----
Quoted 7 lines
From: "Cyril Hrubis" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Thursday, 28 January, 2016 2:41:27 PM
Subject: Re: [LTP] [PATCH]numa_node_size: drop definition ofnuma_exit_on_errorHi!
Quoted 8 lines
Quoted 3 lines
numa_exit_on_erroris defined by numactl library inlibnuma.c, at least since version 0.9. Re-defining it in test can cause compile problems.I've tried to rebuild LTP without the line in question on couple of SUSE distros and it haven't caused any problems. I wonder why it wasn't failing the compilation before though, the variable is defined right in the
libnuma.cin the library.
Linker doesn't seem to mind when linking against shared library.
His build had --static, so I'm guessing noone has tried (and reported) that before.
Regards,
Jan
Quoted 5 lines
--
Cyril Hrubis
[email protected]