staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
Subsystems (2)
PATCH 1/1 staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U_wx.c
clean up checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by Byeoungwook Kim <[email protected]>
--- drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 18 deletions(-)
drivers/staging/rtl8192u/r8192U_wx.c +20 -18
@@ -1,21 +1,23 @@ -/* -This file contains wireless extension handlers. - -This is part of rtl8180 OpenSource driver. -Copyright (C) Andrea Merello 2004-2005 <[email protected]> -Released under the terms of GPL (General Public Licence) - -Parts of this driver are based on the GPL part -of the official realtek driver. - -Parts of this driver are based on the rtl8180 driver skeleton -from Patric Schenke & Andres Salomon. - -Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - -We want to thank the Authors of those projects and the Ndiswrapper -project Authors. -*/ +/****************************************************************************** +* +* This file contains wireless extension handlers. +* +* This is part of rtl8180 OpenSource driver. +* Copyright (C) Andrea Merello 2004-2005 <[email protected]> +* Released under the terms of GPL (General Public Licence) +* +* Parts of this driver are based on the GPL part +* of the official realtek driver. +* +* Parts of this driver are based on the rtl8180 driver skeleton +* from Patric Schenke & Andres Salomon. +* +* Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. +* +* We want to thank the Authors of those projects and the Ndiswrapper +* project Authors. +* +*****************************************************************************/ #include <linux/string.h> #include "r8192U.h"
Signature · 1 line
2.5.0
Quoted 22 lines · Byeoungwook Kim
clean up checkpatch warning:
WARNING: Block comments use * on subsequent linesSigned-off-by Byeoungwook Kim <[email protected]>--- drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 18 deletions(-)drivers/staging/rtl8192u/r8192U_wx.c +0
-9@@ -1,21 +1,23 @@ -/* -This file contains wireless extension handlers. - -This is part of rtl8180 OpenSource driver. -Copyright (C) Andrea Merello 2004-2005 <[email protected]> -Released under the terms of GPL (General Public Licence) - -Parts of this driver are based on the GPL part -of the official realtek driver.
drivers/staging/rtl8192u/r8192U_wx.c line 1
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_wx.c +1
-9- -Parts of this driver are based on the rtl8180 driver skeleton -from Patric Schenke & Andres Salomon. - -Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - -We want to thank the Authors of those projects and the Ndiswrapper -project Authors. -*/ +/******************************************************************************
Is the row of *s needed?
julia
Quoted 30 lines
drivers/staging/rtl8192u/r8192U_wx.c +19
-0+* +* This file contains wireless extension handlers. +* +* This is part of rtl8180 OpenSource driver. +* Copyright (C) Andrea Merello 2004-2005 <[email protected]> +* Released under the terms of GPL (General Public Licence) +* +* Parts of this driver are based on the GPL part +* of the official realtek driver. +* +* Parts of this driver are based on the rtl8180 driver skeleton +* from Patric Schenke & Andres Salomon. +* +* Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. +* +* We want to thank the Authors of those projects and the Ndiswrapper +* project Authors. +* +*****************************************************************************/ #include <linux/string.h> #include "r8192U.h" Signature · 6 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
The current realtek driver was written like my patch comments. but Documentation/CodingStyle isn't before.
So I wrote patch like current realtek driver.
How should i do it?
Regards,
Byeoungwook.
2016-02-01 16:01 GMT+09:00 Julia Lawall <[email protected]>:
Quoted 71 lines · Byeoungwook Kim
Quoted 23 lines
clean up checkpatch warning:
WARNING: Block comments use * on subsequent linesSigned-off-by Byeoungwook Kim <[email protected]>--- drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 18 deletions(-)drivers/staging/rtl8192u/r8192U_wx.c +0
-9@@ -1,21 +1,23 @@ -/* -This file contains wireless extension handlers. - -This is part of rtl8180 OpenSource driver. -Copyright (C) Andrea Merello 2004-2005 <[email protected]> -Released under the terms of GPL (General Public Licence) - -Parts of this driver are based on the GPL part -of the official realtek driver. drivers/staging/rtl8192u/r8192U_wx.c line 1
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_wx.c +1
-9- -Parts of this driver are based on the rtl8180 driver skeleton -from Patric Schenke & Andres Salomon. - -Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - -We want to thank the Authors of those projects and the Ndiswrapper -project Authors. -*/ +/****************************************************************************** Is the row of *s needed?
julia
Quoted 30 lines
drivers/staging/rtl8192u/r8192U_wx.c +19
-1+* +* This file contains wireless extension handlers. +* +* This is part of rtl8180 OpenSource driver. +* Copyright (C) Andrea Merello 2004-2005 <[email protected]> +* Released under the terms of GPL (General Public Licence) +* +* Parts of this driver are based on the GPL part +* of the official realtek driver. +* +* Parts of this driver are based on the rtl8180 driver skeleton +* from Patric Schenke & Andres Salomon. +* +* Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. +* +* We want to thank the Authors of those projects and the Ndiswrapper +* project Authors. +* +*****************************************************************************/ #include <linux/string.h> #include "r8192U.h" --2.5.0
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · ByeoungWook Kim
The current realtek driver was written like my patch comments. but
Documentation/CodingStyleisn't before.
So I wrote patch like current realtek driver.
That is probably fine, then. Sorry for the noise. I looked at some other code in the kernel, and it didn't have it.
julia
Quoted 79 lines
How should i do it?
Regards,
Byeoungwook.2016-02-01 16:01 GMT+09:00 Julia Lawall <[email protected]>:
Quoted 71 lines · Byeoungwook Kim
Quoted 23 lines
clean up checkpatch warning:
WARNING: Block comments use * on subsequent linesSigned-off-by Byeoungwook Kim <[email protected]>--- drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 18 deletions(-)drivers/staging/rtl8192u/r8192U_wx.c +0
-9@@ -1,21 +1,23 @@ -/* -This file contains wireless extension handlers. - -This is part of rtl8180 OpenSource driver. -Copyright (C) Andrea Merello 2004-2005 <[email protected]> -Released under the terms of GPL (General Public Licence) - -Parts of this driver are based on the GPL part -of the official realtek driver. drivers/staging/rtl8192u/r8192U_wx.c line 1
Quoted 10 lines
drivers/staging/rtl8192u/r8192U_wx.c +1
-9- -Parts of this driver are based on the rtl8180 driver skeleton -from Patric Schenke & Andres Salomon. - -Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - -We want to thank the Authors of those projects and the Ndiswrapper -project Authors. -*/ +/****************************************************************************** Is the row of *s needed?
julia
Quoted 30 lines
drivers/staging/rtl8192u/r8192U_wx.c +19
-1+* +* This file contains wireless extension handlers. +* +* This is part of rtl8180 OpenSource driver. +* Copyright (C) Andrea Merello 2004-2005 <[email protected]> +* Released under the terms of GPL (General Public Licence) +* +* Parts of this driver are based on the GPL part +* of the official realtek driver. +* +* Parts of this driver are based on the rtl8180 driver skeleton +* from Patric Schenke & Andres Salomon. +* +* Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. +* +* We want to thank the Authors of those projects and the Ndiswrapper +* project Authors. +* +*****************************************************************************/ #include <linux/string.h> #include "r8192U.h" --2.5.0
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html