package: aespipe: add host variant
PATCH 1/1 package: aespipe: add host variant
--- package/Config.in.host | 1 + package/aespipe/Config.in.host | 10 ++++++++++ package/aespipe/aespipe.mk | 1 + 3 files changed, 12 insertions(+) create mode 100644 package/aespipe/Config.in.host
package/Config.in.host +1 -0
@@ -1,5 +1,6 @@ menu "Host utilities" + source "package/aespipe/Config.in.host" source "package/checkpolicy/Config.in.host" source "package/cramfs/Config.in.host" source "package/dfu-util/Config.in.host"
package/aespipe/Config.in.host new file +10 -0
@@ -0,0 +1,10 @@ +config BR2_PACKAGE_HOST_AESPIPE + bool "host aespipe" + depends on BR2_USE_MMU # fork() + help + aespipe program is AES encrypting or decrypting pipe. It reads from + standard input and writes to standard output. It can be used to + create and restore encrypted tar or cpio archives. It can be used to + encrypt and decrypt loop-AES compatible encrypted disk images. + + http://koti.tnnet.fi/jari.ruusu/linux/
package/aespipe/aespipe.mk +1 -0
@@ -10,3 +10,4 @@ AESPIPE_SITE = http://loop-aes.sourceforge.net/aespipe AESPIPE_LICENSE = GPL $(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
2.7.0
PATCH 1/1 package: aespipe: add host variant
Quoted 1 line · Ariel D'Alessandro
Signed-off-by Ariel D'Alessandro <[email protected]>
Your commit message should explain why this is needed. Something like:
Post-image scripts may want to encrypt the resulting image with aespipe (and decrypt it in the update tool on the target), so it is useful to have the host version and to be able to select it in the configuration.
Quoted 24 lines
--- package/Config.in.host | 1 + package/aespipe/Config.in.host | 10 ++++++++++ package/aespipe/aespipe.mk | 1 + 3 files changed, 12 insertions(+) create mode 100644 package/aespipe/Config.in.hostpackage/Config.in.host +1
-0@@ -1,5 +1,6 @@ menu "Host utilities" + source "package/aespipe/Config.in.host" source "package/checkpolicy/Config.in.host" source "package/cramfs/Config.in.host" source "package/dfu-util/Config.in.host"package/aespipe/Config.in.host new file +0
-0
package/aespipe/Config.in.host line 3
Quoted 3 lines
package/aespipe/Config.in.host new file +3
-0@@ -0,0 +1,10 @@ +config BR2_PACKAGE_HOST_AESPIPE + bool "host aespipe" + depends on BR2_USE_MMU # fork()
This shouldn't be there. If the target doesn't have a MMU, you can still build
it for the host.
Otherwise looks good to me.
Regards,
Arnout
Quoted 17 lines
package/aespipe/Config.in.host new file +7
-0+ help + aespipe program is AES encrypting or decrypting pipe. It reads from + standard input and writes to standard output. It can be used to + create and restore encrypted tar or cpio archives. It can be used to + encrypt and decrypt loop-AES compatible encrypted disk images. + + http://koti.tnnet.fi/jari.ruusu/linux/package/aespipe/aespipe.mk +1
-0@@ -10,3 +10,4 @@ AESPIPE_SITE = http://loop-aes.sourceforge.net/aespipe AESPIPE_LICENSE = GPL $(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 package: aespipe: add host variant
Arnout,
El 01/02/16 a las 15:41, Arnout Vandecappelle escribi?:
Quoted 8 lines · Ariel D'Alessandro
Quoted 1 line
Signed-off-by Ariel D'Alessandro <[email protected]>Your commit message should explain why this is needed. Something like:
Post-image scripts may want to encrypt the resulting image with aespipe (and decrypt it in the update tool on the target), so it is useful to have the host version and to be able to select it in the configuration.
Yeah, I think that explanation is pretty good. I'll add it.
Quoted 32 lines
Quoted 25 lines
--- package/Config.in.host | 1 + package/aespipe/Config.in.host | 10 ++++++++++ package/aespipe/aespipe.mk | 1 + 3 files changed, 12 insertions(+) create mode 100644 package/aespipe/Config.in.hostpackage/Config.in.host +1
-0@@ -1,5 +1,6 @@ menu "Host utilities" + source "package/aespipe/Config.in.host" source "package/checkpolicy/Config.in.host" source "package/cramfs/Config.in.host" source "package/dfu-util/Config.in.host"package/aespipe/Config.in.host new file +0
-0package/aespipe/Config.in.host line 3
Quoted 3 lines
package/aespipe/Config.in.host new file +3
-0@@ -0,0 +1,10 @@ +config BR2_PACKAGE_HOST_AESPIPE + bool "host aespipe" + depends on BR2_USE_MMU # fork()This shouldn't be there. If the target doesn't have a MMU, you can still build
it for the host.
Quoted 1 line
Otherwise looks good to me.
Oops, you're right, don't know why I missed that :(
Thanks!
Signature · 2 lines
Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar
PATCH 1/1 package: aespipe: add host variant
In reply to Ariel D'AlessandroDear Ariel D'Alessandro,
Quoted 7 lines · Ariel D'Alessandro
Signed-off-by Ariel D'Alessandro <[email protected]>--- package/Config.in.host | 1 + package/aespipe/Config.in.host | 10 ++++++++++ package/aespipe/aespipe.mk | 1 + 3 files changed, 12 insertions(+) create mode 100644 package/aespipe/Config.in.host
Can you give a justification as to why we would want to add aespipe as a host package ? We generally try to limit the number of host packages we add to package/Config.in.host, so it's good to include a justification as to why it is a good idea to include aespipe as a menuconfig-selectable host package.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package: aespipe: add host variant
Thomas,
El 01/02/16 a las 16:02, Thomas Petazzoni escribi?:
Quoted 11 lines
Dear Ariel D'Alessandro,
Quoted 7 lines · Ariel D'Alessandro
Signed-off-by Ariel D'Alessandro <[email protected]>--- package/Config.in.host | 1 + package/aespipe/Config.in.host | 10 ++++++++++ package/aespipe/aespipe.mk | 1 + 3 files changed, 12 insertions(+) create mode 100644 package/aespipe/Config.in.host
Quoted 5 lines
Can you give a justification as to why we would want to add aespipe as a host package ? We generally try to limit the number of host packages we add to package/Config.in.host, so it's good to include a justification as to why it is a good idea to include aespipe as a menuconfig-selectable host package.
The justification is pretty much what Arnout said:
""
Post-image scripts may want to encrypt the resulting image with aespipe (and decrypt it in the update tool on the target), so it is useful to have the host version and to be able to select it in the configuration. ""
In fact, that's exactly why I added host-aespipe to one of my projects. Is this enough to include it as a host package?
Thanks!
Signature · 2 lines
Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar
PATCH 1/1 package: aespipe: add host variant
Dear Ariel D'Alessandro,
Quoted 10 lines · Ariel D'Alessandro
The justification is pretty much what Arnout said:
""
Post-image scripts may want to encrypt the resulting image with aespipe (and decrypt it in the update tool on the target), so it is useful to have the host version and to be able to select it in the configuration. ""In fact, that's exactly why I added host-aespipe to one of my projects. Is this enough to include it as a host package?
Yes, this justification is good. It should have been part of the commit log originally though :-)
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com